New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678340 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: May 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

crosperf: results-chart.json clobbered by other runs

Project Member Reported by laszio@chromium.org, Jan 4 2017

Issue description

This happens on crosperf frequently.
 
Owner: laszio@chromium.org

Comment 2 by laszio@chromium.org, Apr 28 2017

Cc: cmt...@chromium.org
Labels: -Pri-3 Pri-2
Status: Started (was: Untriaged)
Summary: crosperf: results-chart.json clobbered by other runs (was: crosperf: Page_cycler_v2.typical_25 FAILED Extra data: line 28707 column 1 - line 28865 column 1 (char 958792 - 963466)
This happens more and more often in crosperf nightly tests. The error looks like :

Page_cycler_v2.typical_25 FAILED Extra data: line 28707 column 1 - line 28865 column 1 (char 958792 - 963466

I finally managed to get a good v.s. bad comparison between runs. The attached json results belong to speedometer, however, there are garbages in the end of bad.json. The garbage looks like a part of the result of smoothness.tough_webgl_cases.
good.json
9.2 KB View Download
bad.json
342 KB View Download
mmm. this is pretty bad! 
thanks for taking ownership.
Project Member

Comment 4 by bugdroid1@chromium.org, May 2 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/autotest/+/e0cbc35b4bf89398ba5f35c1b8f15b7a3d6bc596

commit e0cbc35b4bf89398ba5f35c1b8f15b7a3d6bc596
Author: Ting-Yuan Huang <laszio@chromium.org>
Date: Tue May 02 02:18:18 2017

telemetry_Crosperf: fix a concurrency issue

crosperf can run multiple telemetry tests simultaneously. By default,
the results are written to the same directory and collision happens.

BUG= chromium:678340 
TEST=crosperf runs successfully

Change-Id: Ia1d8dec730bf4f669c140c6a5bcbeb89c20f7be4
Reviewed-on: https://chromium-review.googlesource.com/490639
Commit-Ready: Ting-Yuan Huang <laszio@chromium.org>
Tested-by: Ting-Yuan Huang <laszio@chromium.org>
Reviewed-by: Caroline Tice <cmtice@chromium.org>

[modify] https://crrev.com/e0cbc35b4bf89398ba5f35c1b8f15b7a3d6bc596/server/site_tests/telemetry_Crosperf/telemetry_Crosperf.py

Status: Fixed (was: Started)
Status: Verified (was: Fixed)
No more such errors in nightly perf tests.

Sign in to add a comment