Issue metadata
Sign in to add a comment
|
MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video flaky |
||||||||||||||||||||||
Issue descriptionMediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video is flaky on all the platforms, including windows, mac and linux. It is flaky because sometimes it is failed to open MR dialog. [54468:779:0101/122612.429237:FATAL:media_router_integration_browsertest.cc(268)] Check failed: controller->ShowMediaRouterDialog(). The failure rate is less than 1/10.
,
Jan 4 2017
,
Jan 5 2017
It seems it is either failed to start mirroring or mirroring session is stopped unexpectedly. ../../chrome/test/media_router/media_router_e2e_ui_browsertest.cc:39: Failure Value of: !GetRouteId(receiver()).empty() Actual: false Expected: true
,
Jan 5 2017
I can try to repro this locally and get component logs to figure out why.
,
Jan 11 2017
,
Jan 13 2017
This appears to be a test bug: the test is looking for a receiver named "test-sink-1", but none is provided by the test media route provider included in the component extension, because it's not being configured with test data that includes the sinks. I'm not sure how this test worked to begin with? Maybe there's something I'm missing in how it works?
Here are some relevant log lines: the MR reports one Cast device, but not the sink (test-sink-1) the test is looking for.
[15278:15278:0112/182127.735099:INFO:CONSOLE(7121)] "[ 1.623][INFO][mr.ProviderManager] Sending 1 sinks to MR for urn:x-org.chromium.media:source:tab:2
", source: chrome-extension://enhhojjnijigcajfphajepfemndkmdlo/background_script.js (7121)
[15278:15278:0112/182127.741197:VERBOSE1:media_router_mojo_impl.cc(181)] MR #abef5c71-8b80-48b3-90b3-89e031b9c34c: OnSinksReceived
[15278:15278:0112/182129.723934:VERBOSE1:media_router_webui_message_handler.cc(409)] OnRequestInitialData
[15278:15278:0112/182129.727925:VERBOSE2:media_router_webui_message_handler.cc(314)] UpdateMaxDialogHeight
[15278:15278:0112/182129.729798:VERBOSE2:media_router_webui_message_handler.cc(314)] UpdateMaxDialogHeight
[15278:15278:0112/182129.745851:VERBOSE1:media_router_webui_message_handler.cc(646)] OnReportInitialState
[15278:15278:0112/182129.746712:VERBOSE1:media_router_webui_message_handler.cc(789)] OnInitialDataReceived
[15278:15278:0112/182130.160326:VERBOSE2:media_router_webui_message_handler.cc(314)] UpdateMaxDialogHeight
[15278:15278:0112/182130.989237:INFO:media_router_integration_browsertest.cc(408)] Receiver name: test-sink-1
[15278:15278:0112/182132.459580:VERBOSE1:media_router_webui_message_handler.cc(721)] OnReportSinkCount
Still waiting for the following processes to finish:
out/Default/browser_tests --allow-file-access --also-log-to-stderr --enable-logging --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --run-manual --single_process --user-data-dir=/tmp/.com.google.Chrome.EhlW8u/dwfrLjm --vmodule=presentation*=2,media_r*=2,extension*=2,capture_access*=2,desktop_capture*=2,media_stream*=2,user_media*=2
[15278:15278:0112/182141.388840:VERBOSE1:media_router_webui_message_handler.cc(611)] OnReportBlur
[15278:15278:0112/182142.257881:INFO:CONSOLE(7121)] "[ 16.158][INFO][mr.PersistentDataManager] onSuspend
", source: chrome-extension://enhhojjnijigcajfphajepfemndkmdlo/background_script.js (7121)
[15278:15312:0112/182147.307076:VERBOSE1:media_stream_dispatcher_host.cc(100)] MediaStreamDispatcherHost::OnChannelClosing
Still waiting for the following processes to finish:
out/Default/browser_tests --allow-file-access --also-log-to-stderr --enable-logging --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --run-manual --single_process --user-data-dir=/tmp/.com.google.Chrome.EhlW8u/dwfrLjm --vmodule=presentation*=2,media_r*=2,extension*=2,capture_access*=2,desktop_capture*=2,media_stream*=2,user_media*=2
../../chrome/test/media_router/media_router_integration_browsertest.cc:413: Failure
Value of: ConditionalWait( base::TimeDelta::FromSeconds(30), base::TimeDelta::FromSeconds(1), base::Bind(&MediaRouterIntegrationBrowserTest::IsSinkDiscoveredOnUI, base::Unretained(this)))
Actual: false
Expected: true
[15278:15278:0112/182201.424216:INFO:CONSOLE(1)] "kGetSinkIdScript.0: {"castModes":6,"iconType":0,"id":"rQYQhogQb2VWbrGfVhmcCLs7Qn1I.","isPseudoSink":false,"name":"foltzcast-sea"}", source: (1)
[15278:15278:0112/182201.424778:INFO:media_router_integration_browsertest.cc(328)] sink id:
[15278:15278:0112/182201.428968:INFO:media_router_integration_browsertest.cc(331)] route id:
[15278:15278:0112/182202.447159:INFO:CONSOLE(1)] "kGetSinkIdScript.0: {"castModes":6,"iconType":0,"id":"rQYQhogQb2VWbrGfVhmcCLs7Qn1I.","isPseudoSink":false,"name":"foltzcast-sea"}", source: (1)
[15278:15278:0112/182202.448439:INFO:media_router_integration_browsertest.cc(328)] sink id:
[15278:15278:0112/182202.453363:INFO:media_router_integration_browsertest.cc(331)] route id:
[15278:15278:0112/182203.468946:INFO:CONSOLE(1)] "kGetSinkIdScript.0: {"castModes":6,"iconType":0,"id":"rQYQhogQb2VWbrGfVhmcCLs7Qn1I.","isPseudoSink":false,"name":"foltzcast-sea"}", source: (1)
[15278:15278:0112/182203.469496:INFO:media_router_integration_browsertest.cc(328)] sink id:
[15278:15278:0112/182203.473362:INFO:media_router_integration_browsertest.cc(331)] route id:
[15278:15278:0112/182204.481195:INFO:CONSOLE(1)] "kGetSinkIdScript.0: {"castModes":6,"iconType":0,"id":"rQYQhogQb2VWbrGfVhmcCLs7Qn1I.","isPseudoSink":false,"name":"foltzcast-sea"}", source: (1)
[15278:15278:0112/182204.481785:INFO:media_router_integration_browsertest.cc(328)] sink id:
[15278:15278:0112/182204.484597:INFO:media_router_integration_browsertest.cc(331)] route id:
Still waiting for the following processes to finish:
out/Default/browser_tests --allow-file-access --also-log-to-stderr --enable-logging --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --run-manual --single_process --user-data-dir=/tmp/.com.google.Chrome.EhlW8u/dwfrLjm --vmodule=presentation*=2,media_r*=2,extension*=2,capture_access*=2,desktop_capture*=2,media_stream*=2,user_media*=2
[15278:15278:0112/182205.493732:INFO:CONSOLE(1)] "kGetSinkIdScript.0: {"castModes":6,"iconType":0,"id":"rQYQhogQb2VWbrGfVhmcCLs7Qn1I.","isPseudoSink":false,"name":"foltzcast-sea"}", source: (1)
[15278:15278:0112/182205.494454:INFO:media_router_integration_browsertest.cc(328)] sink id:
[15278:15278:0112/182205.501997:INFO:media_router_integration_browsertest.cc(331)] route id:
BrowserTestBase received signal: Terminated. Backtrace:
,
Jan 13 2017
Clifford, do you know if there is a problem with this test setup?
,
Jan 14 2017
I will take a look at it and update with more details. I checked the receivers today and they all look good to me, so I need more time to see where the connection/detection failed.
,
Jan 19 2017
I spent sometime to debug today. The flakiness is related to the performance. In the mirroring test, we 1) open the dialog, 2) select a sink, 3) re-open the dialog again and then 4) check if there is route. In most failures, (1) or (2) are not working as expected. The popup dialog sometime can take a long time to load or sometimes it can take a while for mirroring to start because the machine is so overloaded. Windows machine is the most under-powered machine and it runs into this situation most (then Linux and Mac). I am going to do a few tweaks, for example use a video with smaller resolution/bitrate and etc., to improve this situation and make it more stable.
,
Jan 23 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/3043d25a4eacdae09be2a4c8ea3155692620c9d4 commit 3043d25a4eacdae09be2a4c8ea3155692620c9d4 Author: Yunlian Jiang <yunlian@google.com> Date: Wed Jan 04 19:08:48 2017 llvm: upgrade to r285905 This upgrade llvm to r285905 and set llvm-next to r292065. BUG= chromium:678315 TEST=cbuildbot daisy-release falco-release oak-release x86-alex-release chromiumos-sdk No performance difference on the four major architecture. Change-Id: I721c75af6700e41539f86375f8f37eb1f58fbb1e Reviewed-on: https://chromium-review.googlesource.com/424979 Commit-Ready: Yunlian Jiang <yunlian@chromium.org> Tested-by: Yunlian Jiang <yunlian@chromium.org> Reviewed-by: Luis Lozano <llozano@chromium.org> [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cmake/llvm-3.7.0-ocaml-multilib.patch [rename] https://crrev.com/3043d25a4eacdae09be2a4c8ea3155692620c9d4/sys-devel/llvm/llvm-4.0_pre285905.ebuild [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cherry/5d36cf313ae9c9e6d475891ec2c0cb3a25ee62b1.patch [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cherry/567da71b9bac96d6e87854f330139710fa2653a7.patch [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cherry/f0ccaf3554182da4c7a038ae96a869e0e202bd2c.patch [rename] https://crrev.com/3043d25a4eacdae09be2a4c8ea3155692620c9d4/sys-devel/clang/clang-4.0_pre285905-r0.ebuild [modify] https://crrev.com/3043d25a4eacdae09be2a4c8ea3155692620c9d4/profiles/targets/chromeos/package.mask [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cmake/0002-cmake-Support-overriding-Sphinx-HTML-doc-install-dir.patch [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cherry/35470639d335074ed5f7de4644627496a4d03f32.patch [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cherry/7c4f7f326e3913a48168269198196efc9058b4b1.patch [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/llvm-3.9-build-id.patch [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cherry/2474f04f67a34476c16316ba0299237c3e6df6b0.patch [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cherry/47bc7ec72ef69769b6fa693d574e1f9159b0d6e6.patch [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cherry/2cef254afa0c2c82d87d37e7e5d57788061d44a2.patch [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cherry/b3419a9ef1857ae36a09cf845f8eec4abefdd159.patch [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cherry/4f4b87e93849eddd82a11c0d41c760aa6a5e8c31.patch [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cherry/ddc91cf1727ad03fcd091578a23c2bcde55b0761.patch [delete] https://crrev.com/3e227fa0efb766b2f54a87efe79f368c2f7e111c/sys-devel/llvm/files/cherry/90ce5cd716419c04a9402de118534ecb5f279ede.patch
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e66e46481c5417326acbed50046d24d43e9ba1b4 commit e66e46481c5417326acbed50046d24d43e9ba1b4 Author: cliffordcheng <cliffordcheng@chromium.org> Date: Thu Jan 26 07:58:18 2017 Change the flow for UI mirroring tests to start mirroing first then play the video. Replace WaitUntilRouteCreated() with some other checks to improve stability. BUG= 678315 Review-Url: https://codereview.chromium.org/2653493007 Cr-Commit-Position: refs/heads/master@{#446272} [modify] https://crrev.com/e66e46481c5417326acbed50046d24d43e9ba1b4/chrome/test/media_router/media_router_e2e_ui_browsertest.cc
,
Jan 26 2017
,
Feb 3 2017
This still seems to be an issue: [ RUN ] MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video [3419:3419:0203/123944.795058:WARNING:password_store_factory.cc(247)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options. [3419:3419:0203/123945.864455:ERROR:CONSOLE(1)] "Uncaught TypeError: Cannot read property 'getElementsByTagName' of null", source: (1) Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo [3419:3419:0203/124045.037521:ERROR:gcm_channel_status_request.cc(92)] GCM channel request failed. Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo [3419:3419:0203/124108.168664:ERROR:gcm_channel_status_request.cc(92)] GCM channel request failed. Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo [3419:3419:0203/124154.606826:ERROR:gcm_channel_status_request.cc(92)] GCM channel request failed. Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo Still waiting for the following processes to finish: ./browser_tests --enable-extension-action-redesign --enable-logging=stderr --enable-pixel-output-in-tests --extension-unpacked=mr_extension/ --gtest_also_run_disabled_tests --gtest_filter=MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video --receiver=mr-test-2 --run-manual --single_process --ui-test-action-timeout=200000 --user-data-dir=/tmp/.org.chromium.Chromium.9KQcIo/dGJiT11 --v=0 --vmodule=media_route*=2,presentation*=2 --whitelisted-extension-id=enhhojjnijigcajfphajepfemndkmdlo BrowserTestBase received signal: Terminated. Backtrace: #0 0x0000027b6147 base::debug::StackTrace::StackTrace() #1 0x000002d10996 content::(anonymous namespace)::DumpStackTraceSignalHandler() #2 0x7fb095643d40 <unknown> #3 0x7fb0956fa12d __poll #4 0x7fb09b0a0fe4 <unknown> #5 0x7fb09b0a10ec g_main_context_iteration #6 0x0000027cf986 base::MessagePumpGlib::Run() #7 0x0000027cdc77 base::MessageLoop::RunHandler() #8 0x0000027ecb0e base::RunLoop::Run() #9 0x000002d3b461 content::MessageLoopRunner::Run() #10 0x000002d13a87 content::DOMMessageQueue::WaitForMessage() #11 0x000002d12ab7 content::(anonymous namespace)::ExecuteScriptHelper() #12 0x000002d12dae content::ExecuteScriptAndExtractBool() #13 0x0000014a2ba6 media_router::MediaRouterIntegrationBrowserTest::IsSinkDiscoveredOnUI() #14 0x00000149ceda media_router::MediaRouterBaseBrowserTest::ConditionalWait() #15 0x0000014a2cf9 media_router::MediaRouterIntegrationBrowserTest::WaitUntilSinkDiscoveredOnUI() #16 0x00000149f3c1 media_router::MediaRouterE2EBrowserTest_MANUAL_MirrorHTML5Video_Test::RunTestOnMainThread() #17 0x000002857eef InProcessBrowserTest::RunTestOnMainThreadLoop() #18 0x000002d106f8 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #19 0x000002b8d813 ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #20 0x000002b8c901 ChromeBrowserMainParts::PreMainMessageLoopRun() #21 0x0000018d27e5 content::BrowserMainLoop::PreMainMessageLoopRun() #22 0x000001b93626 content::StartupTaskRunner::RunAllTasksNow() #23 0x0000018d097b content::BrowserMainLoop::CreateStartupTasks() #24 0x0000018d5f3b content::BrowserMainRunnerImpl::Initialize() #25 0x0000018cdff8 content::BrowserMain() #26 0x0000027a0a3c content::ContentMainRunnerImpl::Run() #27 0x00000279f600 content::ContentMain() #28 0x000002d10029 content::BrowserTestBase::SetUp() #29 0x000002856631 InProcessBrowserTest::SetUp() #30 0x0000032e8aee testing::Test::Run() #31 0x0000032e96b0 testing::TestInfo::Run() #32 0x0000032e9a27 testing::TestCase::Run() #33 0x0000032f0b07 testing::internal::UnitTestImpl::RunAllTests() #34 0x0000032f0787 testing::UnitTest::Run() #35 0x000002867491 base::TestSuite::Run() #36 0x0000027aa8e8 ChromeTestSuiteRunner::RunTestSuite() #37 0x000002d37a7a content::LaunchTests() #38 0x0000027aa867 main #39 0x7fb09562eec5 __libc_start_main #40 0x0000005f47b1 <unknown> [3/3] MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video (TIMED OUT) 1 test timed out: MediaRouterE2EBrowserTest.MANUAL_MirrorHTML5Video (../../chrome/test/media_router/media_router_e2e_ui_browsertest.cc:13)
,
Feb 3 2017
I looked into the code a little bit and I think it's because the receiver is not detected at the very beginning.
We used the JS kFindSinkScript to see if there is any show on UI.
But if there is no sink, and the dialog displays
"No Cast destinations found. Need help?", then this piece of JS will give an error message as above.
I think we should actually var sinks = document.getElementById('media-router-container').allSinks and the iterate to see if there is any sink's name that match the one we need to find.
I am going to prepare a fix for this.
,
Feb 4 2017
Is there an event fired by the dialog DOM when the sinks are loaded? Maybe we could add a handler for that.
,
Feb 4 2017
I don't see there is an event for it. The problem here is that the JS (kFindSinkScript) is looking for an element called 'sink-list', which will return an error there if the dialog can't find any sink. WaitUtilSinkDiscoveredOnUI use this JS to check if a specific sink shows up or not. If it can't find the sink, it waits for 1s and check again until timeout. This works fine if there is already some sinks in the dialog (there is a 'sink-list' already) but just a particular sink is not there. My guess is that in some runs, the detection didn't work fast enough so there isn't any sink. The test eventually gets an error message. allSinks should work much better in this case. I made the change and re-run the tests for a number of times and it works fine.
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/67d9e4ced4719f37cc758910bb32fdca538b3704 commit 67d9e4ced4719f37cc758910bb32fdca538b3704 Author: cliffordcheng <cliffordcheng@chromium.org> Date: Thu Feb 09 21:28:52 2017 Use allSinks to find a sink in kFindSinkScript. BUG= 678315 Review-Url: https://codereview.chromium.org/2674793005 Cr-Commit-Position: refs/heads/master@{#449414} [modify] https://crrev.com/67d9e4ced4719f37cc758910bb32fdca538b3704/chrome/test/media_router/media_router_integration_browsertest.cc
,
Feb 13 2017
,
Feb 14 2017
This is still failing on the Windows bots, [280:2592:0214/074505.798:WARNING:extension_protocols.cc(448)] Failed to GetPathForExtension: pkedcjkdefgpdelpbcmbmeomcjbeemfm [280:2592:0214/074505.798:WARNING:url_request_job_manager.cc(90)] Failed to map: chrome-extension://pkedcjkdefgpdelpbcmbmeomcjbeemfm/cast_sender.js [280:2592:0214/074505.834:WARNING:extension_protocols.cc(448)] Failed to GetPathForExtension: fjhoaacokmgbjemoflkofnenfaiekifl [280:2592:0214/074505.834:WARNING:url_request_job_manager.cc(90)] Failed to map: chrome-extension://fjhoaacokmgbjemoflkofnenfaiekifl/cast_sender.js [280:2592:0214/074505.839:WARNING:extension_protocols.cc(448)] Failed to GetPathForExtension: boadgeojelhgndaghljhdicfkmllpafd [280:2592:0214/074505.839:WARNING:url_request_job_manager.cc(90)] Failed to map: chrome-extension://boadgeojelhgndaghljhdicfkmllpafd/cast_sender.js [280:2592:0214/074505.847:WARNING:extension_protocols.cc(448)] Failed to GetPathForExtension: dliochdbjfkdbacpmhlcpmleaejidimm [280:2592:0214/074505.847:WARNING:url_request_job_manager.cc(90)] Failed to map: chrome-extension://dliochdbjfkdbacpmhlcpmleaejidimm/cast_sender.js e:\b\build\slave\windows_build\build\src\chrome\test\media_router\media_router_e2e_ui_browsertest.cc(31): error: Value of: !GetRouteId(receiver()).empty() Actual: false Expected: true The failure seems to be different than the one that was originally reported in this bug?
,
Feb 15 2017
I think it's all because of the Windows machine problem now. Mac and Linux (if the integration tests are fixed) are running fine now. When I tried to debug on that machine, the test failed either 1. Chrome freezes or 2. Mirroring immediately stops If you look at the telemetry results, the dialog latency of the Windows machine has been very unstable since I turned it back on. I am going to find a replacement for it and see if everything will be better.
,
Feb 25 2017
This test is running very stable for the past few days. Please reopen it if this still happens.
,
Feb 25 2017
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mfo...@chromium.org
, Jan 4 2017Labels: -Restrict-View-Google