New issue
Advanced search Search tips

Issue 678314 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

CBD can not remove website name other than www.netflix.com

Project Member Reported by yini...@chromium.org, Jan 4 2017

Issue description

Chrome Version: 57.0.2970.0
OS: Mac

This issue is only observed on Mac OS, it NOT repro on Win and CrOS device.

What steps will reproduce the problem?
1) Open chrome://settings.
2) Open Advanced Setting=>Clear browsing data
3) select Media License, note it displays message "You may lose access to premium content in https://www.netflix.com and some other sites"
4) click Clear Browsing Data button
5) Open Clear browsing data dialog again
6) select Media License

Expect:
message "You may lose access to premium content from some other sites" is displayed. www.netflix.com(or whatever website is displayed before in message) is NOT displayed in the message.

Actual:
message is not changed, the website is still shown.

 
Labels: Needs-Feedback
yiningc@, I tried this with 57.0.2974.0 on my Mac, and the message changes. Can you try again?
if the website is www.netflix.com, it seems can be removed. If it is others, e.g play.google.com, it seems can't.
this seems not related to OS, but related to the stored website name, if it is www.netflix.com, it can be removed. If it is others, e.g play.google.com or horcrux.kir.corp.google.com, it is not. I can repro the same issue on Windows.
Summary: CBD can not remove website name other than www.netflix.com (was: on Mac, clean media license using ClearBrowsingData->MediaLicense did not remove website name)
changed bug name to reflect the real bug. 
Labels: -Needs-Feedback
After more investigation on the test machine, it appears that the file system contains old data (since horcrux.kir hasn't been used in a long time). Deleting the old file (for the encrypted file system) removes the old names.

Will continue trying to find another site that persists EME data, so we can check that it does get cleared when selected.
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bd3656df6d9951d33d5ec0373996679fe0bfb571

commit bd3656df6d9951d33d5ec0373996679fe0bfb571
Author: jrummell <jrummell@chromium.org>
Date: Thu Jan 12 19:17:29 2017

Clear data for origin if no files found

Currently PluginPrivateDataByOriginChecker only deletes all the data
for the specified origin if it finds at least one file that matches
the time range specified. However, if the origin has no files, it
should be cleaned up as well.

Adds a test that deletes the file for a particular origin before
clearing all PluginPrivate storage to verify it works.

BUG= 678314 
TEST=new content_unittest passes

Review-Url: https://codereview.chromium.org/2622403002
Cr-Commit-Position: refs/heads/master@{#443320}

[modify] https://crrev.com/bd3656df6d9951d33d5ec0373996679fe0bfb571/content/browser/plugin_private_storage_helper.cc
[modify] https://crrev.com/bd3656df6d9951d33d5ec0373996679fe0bfb571/content/browser/storage_partition_impl_unittest.cc

Status: Fixed (was: Assigned)
This should be fixed now. yiningc@, can you check with your Mac once this makes it into a release?

Sign in to add a comment