New issue
Advanced search Search tips

Issue 678307 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner: ----
Closed: Aug 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

232 KB regression in sizes at 441014:441014

Project Member Reported by primiano@chromium.org, Jan 4 2017

Issue description

All graphs for this bug:
  https://chromeperf.appspot.com/group_report?bug_id=678307

Original alerts at time of bug-filing:
  https://chromeperf.appspot.com/group_report?keys=agxzfmNocm9tZXBlcmZyFAsSB0Fub21hbHkYgICgv8HnsAoM


Bot(s) for this bug's original alert(s):

mac

Comment 2 by dimu@chromium.org, Jan 25 2017

Components: UI>Localization Internals>Installer
Owner: ----
Status: Available (was: Assigned)
My changes is just uploading translation results. It looks like the translation result increases installer test by 232.0 KiB. It should be normal?

I'm not sure how these .xtb files are imported for Chrome though. Would it include all languages in one installer?

Comment 3 by grt@chromium.org, Jan 30 2017

Labels: OS-Mac

Comment 4 by jramil@google.com, Jun 13 2017

Components: -UI>Localization UI>Browser
This is not a localization bug. Have confirmed it on English UI.
Cc: tapted@chromium.org
cc tapted, really sorry we missed the questions in #2, tapted what do you think, probably too late to fix?

Comment 6 by tapted@chromium.org, Aug 18 2017

Seems there's just lots of new strings?

$ git show e6e7c46b18ef4958fde3b70ffe1c35fbf80b1f1d --stat=200  | grep GB
 ash/common/strings/ash_strings_en-GB.xtb                                            |   9 ++-
 blimp/client/core/resources/translations/blimp_strings_en-GB.xtb                    |   6 ++
 chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb           |  54 +++++++++++++++--
 chrome/app/resources/chromium_strings_en-GB.xtb                                     |   4 +-
 chrome/app/resources/generated_resources_en-GB.xtb                                  | 198 ++++++++++++++++++++++++++++++++++++-------------------------
 chrome/app/resources/google_chrome_strings_en-GB.xtb                                |   3 +-
 chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_en-GB.xtb     |  15 +++++
 components/policy/resources/policy_templates_en-GB.xtb                              | 111 ++++++++++++++++++++++++++--------
 components/strings/components_strings_en-GB.xtb                                     |  50 +++++++++++++++-
 content/app/strings/translations/content_strings_en-GB.xtb                          |  10 ----
 extensions/strings/extensions_strings_en-GB.xtb                                     |   5 +-
 ios/chrome/app/strings/resources/ios_chromium_strings_en-GB.xtb                     |   3 +-
 ios/chrome/app/strings/resources/ios_google_chrome_strings_en-GB.xtb                |   1 +
 ios/chrome/app/strings/resources/ios_strings_en-GB.xtb                              |  30 +++++++++-
 ios/chrome/share_extension/strings/resources/ios_share_extension_strings_en-GB.xtb  |   4 +-
 ui/strings/translations/ui_strings_en-GB.xtb                                        |  12 +++-

$ git show e6e7c46b18ef4958fde3b70ffe1c35fbf80b1f1d --stat=200  | tail -n 1
 815 files changed, 19113 insertions(+), 7821 deletions(-)

The only concern would be whether this is mac-specific. E.g. maybe things getting included multiple times, or if things like android_chrome_strings_en were getting included on Mac as well.

If resources.pak on other desktop platforms jumped the same amount I don't think we need to worry.
Status: WontFix (was: Available)
Thanks, tapted! Just wanted to double-check. Indeed, resources.pak does jump on other platforms.

Sign in to add a comment