Issue metadata
Sign in to add a comment
|
232 KB regression in sizes at 441014:441014 |
||||||||||||||||||||||
Issue descriptiondimu@ this seems due to https://chromium.googlesource.com/chromium/src/+/e6e7c46b18ef4958fde3b70ffe1c35fbf80b1f1d
,
Jan 25 2017
My changes is just uploading translation results. It looks like the translation result increases installer test by 232.0 KiB. It should be normal? I'm not sure how these .xtb files are imported for Chrome though. Would it include all languages in one installer?
,
Jan 30 2017
,
Jun 13 2017
This is not a localization bug. Have confirmed it on English UI.
,
Aug 17 2017
cc tapted, really sorry we missed the questions in #2, tapted what do you think, probably too late to fix?
,
Aug 18 2017
Seems there's just lots of new strings? $ git show e6e7c46b18ef4958fde3b70ffe1c35fbf80b1f1d --stat=200 | grep GB ash/common/strings/ash_strings_en-GB.xtb | 9 ++- blimp/client/core/resources/translations/blimp_strings_en-GB.xtb | 6 ++ chrome/android/java/strings/translations/android_chrome_strings_en-GB.xtb | 54 +++++++++++++++-- chrome/app/resources/chromium_strings_en-GB.xtb | 4 +- chrome/app/resources/generated_resources_en-GB.xtb | 198 ++++++++++++++++++++++++++++++++++++------------------------- chrome/app/resources/google_chrome_strings_en-GB.xtb | 3 +- chrome/browser/resources/chromeos/chromevox/strings/chromevox_strings_en-GB.xtb | 15 +++++ components/policy/resources/policy_templates_en-GB.xtb | 111 ++++++++++++++++++++++++++-------- components/strings/components_strings_en-GB.xtb | 50 +++++++++++++++- content/app/strings/translations/content_strings_en-GB.xtb | 10 ---- extensions/strings/extensions_strings_en-GB.xtb | 5 +- ios/chrome/app/strings/resources/ios_chromium_strings_en-GB.xtb | 3 +- ios/chrome/app/strings/resources/ios_google_chrome_strings_en-GB.xtb | 1 + ios/chrome/app/strings/resources/ios_strings_en-GB.xtb | 30 +++++++++- ios/chrome/share_extension/strings/resources/ios_share_extension_strings_en-GB.xtb | 4 +- ui/strings/translations/ui_strings_en-GB.xtb | 12 +++- $ git show e6e7c46b18ef4958fde3b70ffe1c35fbf80b1f1d --stat=200 | tail -n 1 815 files changed, 19113 insertions(+), 7821 deletions(-) The only concern would be whether this is mac-specific. E.g. maybe things getting included multiple times, or if things like android_chrome_strings_en were getting included on Mac as well. If resources.pak on other desktop platforms jumped the same amount I don't think we need to worry.
,
Aug 18 2017
Thanks, tapted! Just wanted to double-check. Indeed, resources.pak does jump on other platforms. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by primiano@chromium.org
, Jan 4 2017