New issue
Advanced search Search tips

Issue 678302 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 3
Type: Bug



Sign in to add a comment

[PR] Componentize PaymentRequestImpl

Project Member Reported by ma...@chromium.org, Jan 4 2017

Issue description

Most of the code should live in components/, with the chrome-specific bits in an interface. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f709499d132d767ce77caf04134cd231160835ac

commit f709499d132d767ce77caf04134cd231160835ac
Author: mathp <mathp@chromium.org>
Date: Mon Jan 09 20:48:36 2017

[Payment Request] Change the lifetime management of PaymentRequestImpl

Was previously 1 PaymentRequestImpl per WebContents. Now there is a
PaymentRequestWebContentsManager (1 per WebContents) that owns all the
PaymentRequestImpl's, whose raw pointers are shared with the delegate
and the mojo bindings.

Also, moving PaymentRequestImpl from chrome/ to components/ which creates
the need for a PaymentRequestDelegate (initially managing the Chrome
dialog).

BUG= 678302 

Review-Url: https://codereview.chromium.org/2611253004
Cr-Commit-Position: refs/heads/master@{#442335}

[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/BUILD.gn
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/chrome_content_browser_client.cc
[add] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/payments/chrome_payment_request_delegate.cc
[add] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/payments/chrome_payment_request_delegate.h
[add] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/payments/payment_request_factory.cc
[add] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/payments/payment_request_factory.h
[delete] https://crrev.com/9e47a74b21cb8b32e79eb8f41945afcc35d8a825/chrome/browser/payments/payment_request_impl.cc
[add] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/payments/payment_request_web_contents_manager_browsertest.cc
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/payments/site_per_process_payments_browsertest.cc
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/ui/browser_dialogs.h
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/ui/views/payments/order_summary_view_controller.cc
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/ui/views/payments/order_summary_view_controller.h
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/ui/views/payments/payment_request_dialog.cc
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/ui/views/payments/payment_request_dialog.h
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/ui/views/payments/payment_request_sheet_controller.h
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/ui/views/payments/payment_sheet_view_controller.cc
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/browser/ui/views/payments/payment_sheet_view_controller.h
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/test/BUILD.gn
[add] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/chrome/test/data/payment_request_multiple_requests.html
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/components/payments/BUILD.gn
[modify] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/components/payments/DEPS
[add] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/components/payments/payment_request.cc
[rename] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/components/payments/payment_request.h
[add] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/components/payments/payment_request_delegate.h
[add] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/components/payments/payment_request_web_contents_manager.cc
[add] https://crrev.com/f709499d132d767ce77caf04134cd231160835ac/components/payments/payment_request_web_contents_manager.h

Comment 2 by ma...@chromium.org, Jan 9 2017

Status: Fixed (was: Started)
More specific bug created around layered component
https://bugs.chromium.org/p/chromium/issues/detail?id=679381
Components: -UI>Browser>Autofill>Payments UI>Browser>Payments

Sign in to add a comment