New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678300 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: Windows
Pri: 2
Type: ----



Sign in to add a comment

SpellCheckTest.SpellCheckText failing on chromium.win/Win7 Tests (dbg)(1)

Project Member Reported by rdevlin....@chromium.org, Jan 4 2017

Issue description

components_unittests failing on chromium.win/Win7 Tests (dbg)(1)

Type: build-failure

Builders failed on: 
- Win7 Tests (dbg)(1): 


Example Failure:
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/56205
https://uberchromegw.corp.google.com/i/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/56193

Nothing in the regression log jumped out; disabling the test.

Assigning to spellcheck OWNER groby@ for triage.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4778979832743057ccb46aa95fa512db6722dd6

commit c4778979832743057ccb46aa95fa512db6722dd6
Author: rdevlin.cronin <rdevlin.cronin@chromium.org>
Date: Wed Jan 04 18:09:27 2017

[Sheriff] Disable SpellCheckTest.SpellCheckText on Windows

NOTRY=true
TBR=groby@chromium.org
BUG=678300

Review-Url: https://codereview.chromium.org/2611723003
Cr-Commit-Position: refs/heads/master@{#441408}

[modify] https://crrev.com/c4778979832743057ccb46aa95fa512db6722dd6/components/spellcheck/renderer/spellcheck_unittest.cc

Labels: -Sheriff-Chromium

Comment 3 by groby@chromium.org, Jan 11 2017

Cc: groby@chromium.org k...@chromium.org
Owner: ----
Status: Available (was: Assigned)
Seems to be yet another timeout issue. Kevin, any idea on when/if we can tackle the slowness issue?
FWIW, looking at the test, it seems as if it's running ~200 test cases.  Might be enough to just split it up into 2+ tests.

Comment 5 by k...@chromium.org, Jan 11 2017

We thought about splitting up another test, but it was really better to speed up the library. There are several optimizations in:

https://codereview.chromium.org/2587363003/
Project Member

Comment 6 by bugdroid1@chromium.org, Jan 25 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e2af7dcc6bf1147b230fe27a4487aeace6f315d3

commit e2af7dcc6bf1147b230fe27a4487aeace6f315d3
Author: krb <krb@chromium.org>
Date: Wed Jan 25 15:30:27 2017

Re-enable tests that timed-out on Windows (and one suspicious failure).

BUG= 678753 , 679549 ,678300

Review-Url: https://codereview.chromium.org/2645123002
Cr-Commit-Position: refs/heads/master@{#446024}

[modify] https://crrev.com/e2af7dcc6bf1147b230fe27a4487aeace6f315d3/components/spellcheck/renderer/spellcheck_unittest.cc

Comment 7 by k...@chromium.org, Jan 26 2017

Status: Fixed (was: Available)

Comment 8 by k...@chromium.org, Feb 6 2017

Cc: -k...@chromium.org
Owner: k...@chromium.org
Status: Assigned (was: Fixed)

Comment 9 by k...@chromium.org, Mar 6 2017

Cc: k...@chromium.org
 Issue 689101  has been merged into this issue.
Project Member

Comment 10 by bugdroid1@chromium.org, Mar 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/13934c3f62b6e223d085e10a3e2727c6701333e1

commit 13934c3f62b6e223d085e10a3e2727c6701333e1
Author: krb <krb@chromium.org>
Date: Mon Mar 06 20:10:49 2017

[spellcheck] Narrowly re-enabled some unit tests for Windows

Only a few of the languages in a unit test were taking so long that
they timed out. I re-enabled the others.

The activity that is taking a long time is the reading of the affix
file. There doesn't appear to be anything intrinsically wrong with it.
While en-US has 205 lines in its affix file, e.g. ko-KO has 78,256.

BUG=678300

Review-Url: https://codereview.chromium.org/2730663003
Cr-Commit-Position: refs/heads/master@{#454932}

[modify] https://crrev.com/13934c3f62b6e223d085e10a3e2727c6701333e1/components/spellcheck/renderer/spellcheck_unittest.cc

Labels: Pri-2
Setting defect without priority to Pri-2.

Sign in to add a comment