Loading Offline page on Pending items erase Last committed item |
|||
Issue description1. Put device on bad network conditioner 2. Open a NTP 3. Open a RL distilled issue 4. Press back 5. press forward Observe that NTP is displayed.
,
Jan 6 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9abd41a856d0d6ecf1f220181ffadac528290668 commit 9abd41a856d0d6ecf1f220181ffadac528290668 Author: olivierrobin <olivierrobin@chromium.org> Date: Fri Jan 06 12:30:12 2017 Do not reload pengingItem to open Reading List offline page. Reload will delete Pending Item so altering it and reload will reload the lastCommittedItem. If there is a pending item, stop loading and trigger a new navigation. BUG= 678293 Review-Url: https://codereview.chromium.org/2610953002 Cr-Commit-Position: refs/heads/master@{#441926} [modify] https://crrev.com/9abd41a856d0d6ecf1f220181ffadac528290668/ios/chrome/browser/reading_list/reading_list_web_state_observer.h [modify] https://crrev.com/9abd41a856d0d6ecf1f220181ffadac528290668/ios/chrome/browser/reading_list/reading_list_web_state_observer.mm [modify] https://crrev.com/9abd41a856d0d6ecf1f220181ffadac528290668/ios/chrome/browser/reading_list/reading_list_web_state_observer_unittest.mm
,
Jan 6 2017
,
Jan 13 2017
Verified in 57.0.2980.0 canary, iPhone 6 iOS 9.3.5, iPhone 6 plus 10.2, iPad mini 10.1 Followed steps on comment #0. |
|||
►
Sign in to add a comment |
|||
Comment 1 by cma...@chromium.org
, Jan 5 2017