webrtc-internals UI/UX improvements
Reported by
fi...@appear.in,
Jan 4 2017
|
||||||
Issue descriptionUserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Ubuntu Chromium/53.0.2785.143 Chrome/53.0.2785.143 Safari/537.36 Steps to reproduce the problem: feature request ;-) What is the expected behavior? What went wrong? 1) webrtc-internals is currently using internal event names instead of the the event names defined in the w3c-pc specificataion 2) adding the candidate type (host, srflx, relay) to the onicecandidate and addIceCandidate events would make it easier to check at a glance what candidate types were added without having to expand each of those events. 3) highlighting ice failure and any OnFailure would make it easier for users to see that something is wrong Did this work before? No Chrome version: 53.0.2785.143 Channel: n/a OS Version: Flash Version: Shockwave Flash 16.0 r0
,
Jan 10 2017
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/90c70c7ac3a6f823ec083829fad97016ef4d24b6 commit 90c70c7ac3a6f823ec083829fad97016ef4d24b6 Author: philipp.hancke <philipp.hancke@googlemail.com> Date: Fri Jan 13 09:58:08 2017 webrtc-internals: highlight failures Highlights both ICE failure (iceconnectionstatechange -> failed) and any error callbacks (indicated by ...OnFailure) so that they are more visible. BUG=678292 Review-Url: https://codereview.chromium.org/2621493002 Cr-Commit-Position: refs/heads/master@{#443523} [modify] https://crrev.com/90c70c7ac3a6f823ec083829fad97016ef4d24b6/content/browser/resources/media/peer_connection_update_table.js [modify] https://crrev.com/90c70c7ac3a6f823ec083829fad97016ef4d24b6/content/browser/resources/media/webrtc_internals.css
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6947bf33fca57e328ba961b246cb1b386da6c706 commit 6947bf33fca57e328ba961b246cb1b386da6c706 Author: philipp.hancke <philipp.hancke@googlemail.com> Date: Fri Jan 13 11:42:02 2017 webrtc-internals: show ice candidate type extracts the ice candidate type (host, srflx or relay) from the onicecandidate event and addIceCandidate call and shows it as part of the type. BUG=678292 Review-Url: https://codereview.chromium.org/2612063002 Cr-Commit-Position: refs/heads/master@{#443534} [modify] https://crrev.com/6947bf33fca57e328ba961b246cb1b386da6c706/content/browser/resources/media/peer_connection_update_table.js
,
Jan 17 2017
fippo@apper.in seems to be working on the issue. I am updating bug status to reflect that and assigning to the reviewer hta@ as a proxy for him.
,
Feb 1 2017
https://codereview.chromium.org/2602603002/ didn't show up. I'm done for now.
,
Feb 1 2017
,
Aug 15 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e18dba6665d8eba6632b04f003f1642e97825abf commit e18dba6665d8eba6632b04f003f1642e97825abf Author: Philipp Hancke <philipp.hancke@googlemail.com> Date: Tue Aug 15 13:34:53 2017 webrtc-internals: add stat type to graph container adds the stat report type to the graph container BUG=678292 Change-Id: Ic663156179c1562bd264b62f9ef2eca633ea0183 Reviewed-on: https://chromium-review.googlesource.com/594408 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#494368} [modify] https://crrev.com/e18dba6665d8eba6632b04f003f1642e97825abf/content/browser/resources/media/stats_graph_helper.js
,
Jan 22 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/52f4a38c35c8c29b981db3c8a441ab9128c339de commit 52f4a38c35c8c29b981db3c8a441ab9128c339de Author: Philipp Hancke <philipp.hancke@googlemail.com> Date: Mon Jan 22 12:21:04 2018 webrtc-internals: highlight legacy streams API usage highlights the legacy addStream/removeStream WebRTC API calls. Bug: 678292 Change-Id: I37babe06904603119d60cd86e209bbea039fc5ea Reviewed-on: https://chromium-review.googlesource.com/875967 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#530843} [modify] https://crrev.com/52f4a38c35c8c29b981db3c8a441ab9128c339de/content/browser/resources/media/peer_connection_update_table.js [modify] https://crrev.com/52f4a38c35c8c29b981db3c8a441ab9128c339de/content/browser/resources/media/webrtc_internals.css
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0de6d37e89509801197d7d5b3fc88490c0246d3 commit e0de6d37e89509801197d7d5b3fc88490c0246d3 Author: Philipp Hancke <philipp.hancke@googlemail.com> Date: Thu Mar 15 15:13:17 2018 webrtc-internals: dont repaint invisible graphs avoids repainting stats graphs that are not visible. Visibility is determined as described in https://stackoverflow.com/a/21696585/4352772 BUG=678292 Change-Id: Ib7ac623f8d961359e4915b3f5580734fb1328bec Reviewed-on: https://chromium-review.googlesource.com/602270 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#543372} [modify] https://crrev.com/e0de6d37e89509801197d7d5b3fc88490c0246d3/content/browser/resources/media/timeline_graph_view.js
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3ca584affef1e164fc3488bc0c20f8a5bc3f5c85 commit 3ca584affef1e164fc3488bc0c20f8a5bc3f5c85 Author: Roger Tawa <rogerta@chromium.org> Date: Thu Mar 15 15:39:04 2018 Revert "webrtc-internals: only highlight currently active connection" This reverts commit 9eaaf8d98dca80307d0ba8e4f2a9e942c613ca0a. Reason for revert: Speculatively reverting to try and fix compile error: https://ci.chromium.org/buildbot/chromium.webkit/Android%20Builder/133884 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FAndroid_Builder%2F133884%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > webrtc-internals: only highlight currently active connection > > and remove the class from any past ones. > > BUG=678292 > > Change-Id: I5a3bc354f45363573ed8604fbbc27ee2530faa66 > Reviewed-on: https://chromium-review.googlesource.com/615500 > Reviewed-by: Tommi <tommi@chromium.org> > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543371} TBR=tommi@chromium.org,hta@chromium.org,philipp.hancke@googlemail.com Change-Id: Ibaa7ea4489e195b39180ad24efdb21796e285faf No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 678292 Reviewed-on: https://chromium-review.googlesource.com/964394 Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#543376} [modify] https://crrev.com/3ca584affef1e164fc3488bc0c20f8a5bc3f5c85/content/browser/resources/media/stats_table.js
,
Mar 15 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fa9989eb3b492dd386e0395f7a59f1a506850159 commit fa9989eb3b492dd386e0395f7a59f1a506850159 Author: Roger Tawa <rogerta@chromium.org> Date: Thu Mar 15 15:41:33 2018 Revert "webrtc-internals: dont repaint invisible graphs" This reverts commit e0de6d37e89509801197d7d5b3fc88490c0246d3. Reason for revert: Speculatively reverting to try and fix compile error: https://ci.chromium.org/buildbot/chromium.webkit/Android%20Builder/133884 https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FAndroid_Builder%2F133884%2F%2B%2Frecipes%2Fsteps%2Fcompile%2F0%2Fstdout Original change's description: > webrtc-internals: dont repaint invisible graphs > > avoids repainting stats graphs that are not visible. > Visibility is determined as described in > https://stackoverflow.com/a/21696585/4352772 > > BUG=678292 > > Change-Id: Ib7ac623f8d961359e4915b3f5580734fb1328bec > Reviewed-on: https://chromium-review.googlesource.com/602270 > Reviewed-by: Tommi <tommi@chromium.org> > Commit-Queue: Harald Alvestrand <hta@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543372} TBR=tommi@chromium.org,hta@chromium.org,philipp.hancke@googlemail.com Change-Id: Id9328a3cc5275ae2143243055f575e142c88d943 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 678292 Reviewed-on: https://chromium-review.googlesource.com/963657 Reviewed-by: Roger Tawa <rogerta@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#543377} [modify] https://crrev.com/fa9989eb3b492dd386e0395f7a59f1a506850159/content/browser/resources/media/timeline_graph_view.js
,
Mar 15 2018
For the record the builder went green again after just the revert in #11 went in ( https://chromium-review.googlesource.com/964394 ) Here's the compile failure from the last build before it went green FAILED: gen/content/resources_stamp.d.stamp gen/content/grit/content_resources.h gen/content/content_resources.pak gen/content/content_resources.pak.info python ../../tools/grit/grit.py -i ../../content/content_resources.grd build -o gen/content --depdir . --depfile gen/content/resources_stamp.d --write-only-new=1 --depend-on-stamp -D _chromium -E CHROMIUM_BUILD=chromium -E ANDROID_JAVA_TAGGED_ONLY=true -t android -E root_gen_dir=gen -f ../../tools/gritsettings/resource_ids --assert-file-list=obj/content/resources_expected_outputs.txt --js-minifier /mnt/data/b/c/b/Android_Builder/src/third_party/closure_compiler/js_minify.py\ --closure_args\ extra_annotation_name=attribute\ extra_annotation_name=demo\ extra_annotation_name=element\ extra_annotation_name=group\ extra_annotation_name=hero\ extra_annotation_name=homepage\ extra_annotation_name=status\ extra_annotation_name=submodule\ compilation_level=WHITESPACE_ONLY\ language_in=ECMASCRIPT_NEXT\ language_out=ECMASCRIPT6\ emit_use_strict=false\ jscomp_off=duplicate Minification failed for ../../content/browser/resources/media/webrtc_internals.js (ERROR) Error in: /tmp/tmp_DV5_o.js ## /tmp/tmp_DV5_o.js:1568: ERROR - Parse error. ')' expected ## }; ## ^ ## ## /tmp/tmp_DV5_o.js:1570: ERROR - Parse error. return must be inside function ## return StatsTable; ## ^ ## ## /tmp/tmp_DV5_o.js:1571: ERROR - Parse error. Semi-colon expected ## })(); ## ^ ## ## /tmp/tmp_DV5_o.js:1571: ERROR - Parse error. primary expression expected ## })(); ## ^ ## ## /tmp/tmp_DV5_o.js:1571: ERROR - Parse error. primary expression expected ## })(); ## ^ /tmp/tmpJ8cmmc:1568: ERROR - Parse error. ')' expected }; ^ /tmp/tmpJ8cmmc:1570: ERROR - Parse error. return must be inside function return StatsTable; ^ /tmp/tmpJ8cmmc:1571: ERROR - Parse error. Semi-colon expected })(); ^ /tmp/tmpJ8cmmc:1571: ERROR - Parse error. primary expression expected })(); ^ /tmp/tmpJ8cmmc:1571: ERROR - Parse error. primary expression expected })(); ^ 5 error(s), 0 warning(s) Traceback (most recent call last): File "/mnt/data/b/c/b/Android_Builder/src/third_party/closure_compiler/js_minify.py", line 47, in <module> result = Minify(sys.stdin.read()) File "/mnt/data/b/c/b/Android_Builder/src/third_party/closure_compiler/js_minify.py", line 39, in Minify return result File "/usr/lib/python2.7/tempfile.py", line 427, in __exit__ self.close() File "/usr/lib/python2.7/tempfile.py", line 418, in close self.unlink(self.name) OSError: [Errno 2] No such file or directory: '/tmp/tmpzAEoHn.js' Error processing node <?xml version="1.0" encoding="UTF-8"?> <include compress="gzip" file="browser/resources/media/webrtc_internals.js" flattenhtml="true" name="IDR_WEBRTC_INTERNALS_JS" type="BINDATA" />
,
Mar 15 2018
Thanks - I filed https://bugs.chromium.org/p/chromium/issues/detail?id=822297 because this error wasn't caught by the trybots.
,
Apr 11 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/11e58cb159a62aa21afa484d6652ece24d3e0d74 commit 11e58cb159a62aa21afa484d6652ece24d3e0d74 Author: Philipp Hancke <philipp.hancke@googlemail.com> Date: Wed Apr 11 17:42:32 2018 webrtc-internals: more robust ice candidate type detection makes the ice candidate type detection on webrtc-internals more robust. BUG=678292 Change-Id: I8a6d8892a17a33ec2d69044c19a9e5b4d9cedbc3 Reviewed-on: https://chromium-review.googlesource.com/584753 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#549921} [modify] https://crrev.com/11e58cb159a62aa21afa484d6652ece24d3e0d74/content/browser/resources/media/peer_connection_update_table.js
,
Apr 16 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76f2f19d3854feb805f0eb853372ff44096e55c8 commit 76f2f19d3854feb805f0eb853372ff44096e55c8 Author: Philipp Hancke <philipp.hancke@googlemail.com> Date: Mon Apr 16 08:26:45 2018 webrtc-internals: only highlight currently active connection and remove the class from any past ones. Re-land of https://chromium-review.googlesource.com/c/chromium/src/+/615500 (with JS error fixed) BUG=678292 Change-Id: Icedc03ed30e2f4c0d36341db371ef3d12a679a94 Reviewed-on: https://chromium-review.googlesource.com/986139 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#550946} [modify] https://crrev.com/76f2f19d3854feb805f0eb853372ff44096e55c8/content/browser/resources/media/stats_table.js
,
Apr 17 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/76f2f19d3854feb805f0eb853372ff44096e55c8 commit 76f2f19d3854feb805f0eb853372ff44096e55c8 Author: Philipp Hancke <philipp.hancke@googlemail.com> Date: Mon Apr 16 08:26:45 2018 webrtc-internals: only highlight currently active connection and remove the class from any past ones. Re-land of https://chromium-review.googlesource.com/c/chromium/src/+/615500 (with JS error fixed) BUG=678292 Change-Id: Icedc03ed30e2f4c0d36341db371ef3d12a679a94 Reviewed-on: https://chromium-review.googlesource.com/986139 Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Harald Alvestrand <hta@chromium.org> Cr-Commit-Position: refs/heads/master@{#550946} [modify] https://crrev.com/76f2f19d3854feb805f0eb853372ff44096e55c8/content/browser/resources/media/stats_table.js
,
Apr 23 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/490346a1fa8e273a3cfd99c7846d24defbc0a520 commit 490346a1fa8e273a3cfd99c7846d24defbc0a520 Author: Philipp Hancke <philipp.hancke@googlemail.com> Date: Mon Apr 23 13:08:43 2018 webrtc-internals: dont repaint invisible graphs avoids repainting stats graphs that are not visible. Visibility is determined as described in https://stackoverflow.com/a/21696585/4352772 Re-lands https://chromium-review.googlesource.com/c/chromium/src/+/602270 BUG=678292 Change-Id: I6d6b51238660ce3e45c2905e13380faf4f9817c9 Reviewed-on: https://chromium-review.googlesource.com/986194 Reviewed-by: Harald Alvestrand <hta@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#552674} [modify] https://crrev.com/490346a1fa8e273a3cfd99c7846d24defbc0a520/content/browser/resources/media/timeline_graph_view.js
,
May 7 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/949b72f1de52c8e90043269ce26c8f96c8b1ff1b commit 949b72f1de52c8e90043269ce26c8f96c8b1ff1b Author: Philipp Hancke <philipp.hancke@googlemail.com> Date: Mon May 07 18:11:35 2018 webrtc-internals: clean up semicolon warnings as determined from running eslint BUG=678292 Change-Id: Ida48707222fbeb35f4bddf71df7c65186f449b73 Reviewed-on: https://chromium-review.googlesource.com/1047605 Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#556497} [modify] https://crrev.com/949b72f1de52c8e90043269ce26c8f96c8b1ff1b/content/browser/resources/media/client_renderer.js [modify] https://crrev.com/949b72f1de52c8e90043269ce26c8f96c8b1ff1b/content/browser/resources/media/main.js [modify] https://crrev.com/949b72f1de52c8e90043269ce26c8f96c8b1ff1b/content/browser/resources/media/peer_connection_update_table.js [modify] https://crrev.com/949b72f1de52c8e90043269ce26c8f96c8b1ff1b/content/browser/resources/media/ssrc_info_manager.js [modify] https://crrev.com/949b72f1de52c8e90043269ce26c8f96c8b1ff1b/content/browser/resources/media/webrtc_internals.js
,
May 18 2018
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fd80db4e6b2657e3dd5980002a822489c9dad4de commit fd80db4e6b2657e3dd5980002a822489c9dad4de Author: Philipp Hancke <philipp.hancke@googlemail.com> Date: Fri May 18 12:10:37 2018 webrtc-internals: fix active connection display unlike in getStats, googActiveConnection is a boolean value in webrtc-internals BUG=678292 Change-Id: If0bd555ee9edb20f1a41d5cc23d594c7a46f5c9d Reviewed-on: https://chromium-review.googlesource.com/1065872 Reviewed-by: Henrik Boström <hbos@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Commit-Queue: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#559869} [modify] https://crrev.com/fd80db4e6b2657e3dd5980002a822489c9dad4de/content/browser/resources/media/stats_table.js
,
Sep 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5405fb6e069723d5538739014b08bfbf1c99148 commit b5405fb6e069723d5538739014b08bfbf1c99148 Author: Philipp Hancke <philipp.hancke@googlemail.com> Date: Wed Sep 05 18:49:32 2018 webrtc-internals: round bits per second uses Math.floor() to round bits per second as fractions of a bit are not very meaningful Bug: 678292 Change-Id: I8b8f5cb9b4a88729d64fb37d8d05145b8330d421 Reviewed-on: https://chromium-review.googlesource.com/1207950 Commit-Queue: Philipp Hancke <philipp.hancke@googlemail.com> Commit-Queue: Tommi <tommi@chromium.org> Reviewed-by: Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#588950} [modify] https://crrev.com/b5405fb6e069723d5538739014b08bfbf1c99148/content/browser/resources/media/stats_graph_helper.js |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by jmukthavaram@chromium.org
, Jan 5 2017Status: Untriaged (was: Unconfirmed)