Project: chromium Issues People Development process History Sign in
New issue
Advanced search Search tips
Issue 678285 Deprecate and Remove "-internal" media controls CSS pseudo elements expose to web content
Starred by 3 users Project Member Reported by mlamouri@chromium.org, Jan 4 Back to list
Status: Started
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: 2017-02-25
OS: All
Pri: 2
Type: Bug



Sign in to add a comment
Based on https://cs.chromium.org/chromium/src/third_party/WebKit/Source/core/css/CSSSelector.cpp?rcl=0&l=288 we seem to have:

Cast related:
-internal-media-controls-cast-button
-internal-media-controls-overlay-cast-button

Text track related:
-internal-media-controls-text-track-list
-internal-media-controls-text-track-list-item
-internal-media-controls-text-track-list-item-input
-internal-media-controls-text-track-list-kind-captions
-internal-media-controls-text-track-list-kind-subtitles

The Cast ones are fairly old and already tracked by:
- https://www.chromestatus.com/metrics/feature/popularity#CSSSelectorInternalMediaControlsOverlayCastButton
- https://www.chromestatus.com/metrics/feature/popularity#CSSSelectorInternalMediaControlsCastButton

The other ones are not tracked but fairly new.
 
Labels: Hotlist-Interop
Labels: -Pri-3 M-59 Pri-1
Status: Started
Summary: Deprecate and Remove "-internal" media controls CSS pseudo elements expose to web content (was: Deprecate "-internal" media controls CSS pseudo elements expose to web content)
CL is read. Intent to Deprecate and Remove drafts are ready. We are targetting deprecation in M57 and removal in M59.
Project Member Comment 3 by bugdroid1@chromium.org, Jan 18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/37af6af68b5ef43dc3b2d588ea7a2a56a678b351

commit 37af6af68b5ef43dc3b2d588ea7a2a56a678b351
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Jan 18 13:54:05 2017

Deprecate all -internal-media-controls-* currently expose to web contents.

Exhaustive list is:
-internal-media-controls-cast-button
-internal-media-controls-overlay-cast-button
-internal-media-controls-text-track-list
-internal-media-controls-text-track-list-item
-internal-media-controls-text-track-list-item-input
-internal-media-controls-text-track-list-kind-captions
-internal-media-controls-text-track-list-kind-subtitles

Chrome Status entries are:
- https://www.chromestatus.com/feature/5734009183141888
- https://www.chromestatus.com/feature/5714245488476160
- https://www.chromestatus.com/feature/5661431349379072

BUG=678285
R=foolip@chromium.org, isherman@chromium.org

Review-Url: https://codereview.chromium.org/2628923006
Cr-Commit-Position: refs/heads/master@{#444346}

[add] https://crrev.com/37af6af68b5ef43dc3b2d588ea7a2a56a678b351/third_party/WebKit/LayoutTests/media/deprecated-css-selectors-expected.txt
[add] https://crrev.com/37af6af68b5ef43dc3b2d588ea7a2a56a678b351/third_party/WebKit/LayoutTests/media/deprecated-css-selectors.html
[modify] https://crrev.com/37af6af68b5ef43dc3b2d588ea7a2a56a678b351/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/37af6af68b5ef43dc3b2d588ea7a2a56a678b351/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.h
[modify] https://crrev.com/37af6af68b5ef43dc3b2d588ea7a2a56a678b351/third_party/WebKit/Source/core/frame/Deprecation.cpp
[modify] https://crrev.com/37af6af68b5ef43dc3b2d588ea7a2a56a678b351/third_party/WebKit/Source/core/frame/UseCounter.h
[modify] https://crrev.com/37af6af68b5ef43dc3b2d588ea7a2a56a678b351/tools/metrics/histograms/histograms.xml

NextAction: 2017-02-25
Deprecation has landed. We should remove the selectors in M59. Adding a next action in a bit more than a month to check the metrics.
Labels: Update-Monthly
Components: -Blink>Media>Controls
Project Member Comment 9 by bugdroid1@chromium.org, Apr 18
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/25800fa49e1e6176b11bac60f20e031363e1bd97

commit 25800fa49e1e6176b11bac60f20e031363e1bd97
Author: mlamouri <mlamouri@chromium.org>
Date: Tue Apr 18 21:49:29 2017

Move cast overlay CSS selector deprecation deadline to 61.

Unfortunately, the usage increased since the deprecation started,
making the deprecation a bit more involved.

BUG=678285
R=foolip@chromium.org

Review-Url: https://codereview.chromium.org/2827583003
Cr-Commit-Position: refs/heads/master@{#465387}

[modify] https://crrev.com/25800fa49e1e6176b11bac60f20e031363e1bd97/third_party/WebKit/LayoutTests/media/deprecated-css-selectors-expected.txt
[modify] https://crrev.com/25800fa49e1e6176b11bac60f20e031363e1bd97/third_party/WebKit/Source/core/frame/Deprecation.cpp

Project Member Comment 10 by bugdroid1@chromium.org, May 26
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ff8ac992b2d0476ee7806728fcbf003600807efd

commit ff8ac992b2d0476ee7806728fcbf003600807efd
Author: Rune Lillesveen <rune@opera.com>
Date: Fri May 26 12:42:34 2017

Drop author ::-internal-* pseudo at parse time.

The SelectorChecker already always failed, but the selector should be
invalid and the whole rule dropped. There is a single pseudo
::-internal-media-controls-overlay-cast-button which is still web-
facing. That is tracked by issue 678285.

Moved the update pseudo page in @page into a separate method.

BUG= 725480 ,678285

Change-Id: Ifca8a0e593c4d11720b0b0822e4c753ff45fb52b
Reviewed-on: https://chromium-review.googlesource.com/512827
Commit-Queue: Rune Lillesveen <rune@opera.com>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#474987}
[modify] https://crrev.com/ff8ac992b2d0476ee7806728fcbf003600807efd/third_party/WebKit/LayoutTests/FlagExpectations/enable-blink-features=LayoutNG
[delete] https://crrev.com/3e04e43e54065fb3b758200e23efb25697ead7e9/third_party/WebKit/LayoutTests/fast/css/invalidation/spatial-navigation-focus-pseudo-expected.txt
[delete] https://crrev.com/3e04e43e54065fb3b758200e23efb25697ead7e9/third_party/WebKit/LayoutTests/fast/css/invalidation/spatial-navigation-focus-pseudo.html
[modify] https://crrev.com/ff8ac992b2d0476ee7806728fcbf003600807efd/third_party/WebKit/LayoutTests/media/deprecated-css-selectors.html
[modify] https://crrev.com/ff8ac992b2d0476ee7806728fcbf003600807efd/third_party/WebKit/Source/core/css/CSSSelector.cpp
[modify] https://crrev.com/ff8ac992b2d0476ee7806728fcbf003600807efd/third_party/WebKit/Source/core/css/CSSSelector.h
[modify] https://crrev.com/ff8ac992b2d0476ee7806728fcbf003600807efd/third_party/WebKit/Source/core/css/SelectorChecker.cpp
[modify] https://crrev.com/ff8ac992b2d0476ee7806728fcbf003600807efd/third_party/WebKit/Source/core/css/parser/CSSParserImpl.cpp
[modify] https://crrev.com/ff8ac992b2d0476ee7806728fcbf003600807efd/third_party/WebKit/Source/core/css/parser/CSSParserSelector.h
[modify] https://crrev.com/ff8ac992b2d0476ee7806728fcbf003600807efd/third_party/WebKit/Source/core/css/parser/CSSSelectorParser.cpp
[modify] https://crrev.com/ff8ac992b2d0476ee7806728fcbf003600807efd/third_party/WebKit/Source/core/css/parser/CSSSelectorParserTest.cpp
[modify] https://crrev.com/ff8ac992b2d0476ee7806728fcbf003600807efd/third_party/WebKit/Source/core/html/HTMLVideoElementPersistentTest.cpp

Cc: meade@chromium.org
Hey mlamouri, is this done? If so, could you please mark as fixed?
All of the internal selectors are no longer web exposed except for:
-internal-media-controls-overlay-cast-button

We are looking into alternative solutions.
Cool ok, so there's one remaining. Is this still P1 though?
Labels: -Pri-1 -M-59 M-62 Pri-2
P-2 is fine :)
Thank you!
Sign in to add a comment