New issue
Advanced search Search tips

Issue 678270 link

Starred by 2 users
Status: WontFix
Owner: ----
Closed: Aug 14
Cc:
penghuang@chromium.org
sadrul@chromium.org
sky@chromium.org
mustash-bugs@google.com
EstimatedDays: ----
NextAction: ----
OS: All , Chrome
Pri: 2
Type: Bug

Blocking:
issue 670496



Sign in to add a comment

Exo should only use ash code in ash/public/cpp

Project Member Reported by penghuang@chromium.org, Jan 4 2017 
When the aura library is initialized with mus mode, the WindowState will not work. Calling ash::wm::GetWindowState will crash.

But the exo need read, write and observe WindowState. See[1]

[1]https://cs.chromium.org/search/?q=ash::wm::GetWindowState+file:%5Esrc/components/exo/&sq=package:chromium&type=cs

Comment 1 by sky@chromium.org, Jan 4 2017 

WindowState should only be used by code running in ash. All the usage you mention here needs to route through mojoms that are provided by ash. The code may have not crashed previously, but it wasn't really working correctly. exo shouldn't be using or linking with ash directly.

Comment 2 by penghuang@chromium.org, May 29 2017 

 Issue 697585  has been merged into this issue.

Comment 3 by sky@chromium.org, May 30 2017

Summary: Exo should only use ash code in ash/public/cpp (was: ash::wm::GetWindowState crashes when aura is initialized for mus)
I'm changing the subject to better reflect what needs to change.

Comment 4 by varkha@chromium.org, Jun 1 2017

Blocking: -672961 728695

Comment 5 by varkha@chromium.org, Jun 20 2017

Cc: penghuang@chromium.org

Comment 6 by varkha@chromium.org, Jun 20 2017

Labels: OS-Chrome
Status: Available (was: Untriaged)

Comment 7 by sky@chromium.org, Jun 20 2017 

This is only needed for mash, right? Isn't 728695 for mushrome, in which case this shouldn't be blocking 728695?

Comment 8 by sky@chromium.org, Jun 20 2017

Labels: Proj-Mustash

Comment 9 by penghuang@chromium.org, Jun 20 2017

Blocking: -728695 672961
Yes. It is not necessary for Mushrome.

Comment 10 by varkha@chromium.org, Sep 20 2017

Blocking: -672961 670496

Comment 11 by varkha@chromium.org, Sep 20 2017

Labels: -Pri-1 Pri-2

Comment 12 by jamescook@chromium.org, Aug 14

Status: WontFix (was: Available)
I don't think this is a problem with WS2 - mus+ash+exo are all in the same process now.

Please reopen if I'm wrong.
►

Sign in to add a comment