New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678260 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Rename RemoteSuggestionsScheduler::RescheduleFetching() to OnBrowserUpgraded()

Project Member Reported by jkrcal@chromium.org, Jan 4 2017

Issue description

To better indicate what is the event when this is called.
 

Comment 1 by jkrcal@chromium.org, Jun 12 2017

Cc: dgn@chromium.org
In the same CL, also rename 
   RemoteSuggestionsScheduler::OnNTPOpened()
to RemoteSuggestionsScheduler::OnSuggestionsSurfaceOpened() 
to better reflect both ChromeHome and old NTP (as discussed in  crbug.com/728997 ).
Project Member

Comment 2 by bugdroid1@chromium.org, Jul 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/54526ffcba714c1106181235cb63fdbb2aee3fbb

commit 54526ffcba714c1106181235cb63fdbb2aee3fbb
Author: Jan Krcal <jkrcal@chromium.org>
Date: Thu Jul 13 11:05:47 2017

[Remote scheduler] Naming clean-up

This CL cleans-up naming for RemoteSuggestionsScheduler:
 - RescheduleFetching() -> OnBrowserUpgraded() to keep the logic in the
   scheduler;
 - OnNTPOpened() -> OnSuggestionsSurfaceOpened() to reflect the change
   by Chrome Home;

It also cleans-up naming inconsistencies on the java side.

Bug:  678260 
Change-Id: Ice2bc5526dc8cc4e4f08d46257318df93a767e67
Reviewed-on: https://chromium-review.googlesource.com/561142
Commit-Queue: Jan Krcal <jkrcal@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: vitaliii <vitaliii@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#486338}
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsBridge.java
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsLauncher.java
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/chrome/browser/android/ntp/ntp_snippets_bridge.cc
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/chrome/browser/android/ntp/suggestions_event_reporter_bridge.cc
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/components/ntp_snippets/remote/persistent_scheduler.h
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/components/ntp_snippets/remote/remote_suggestions_provider_impl_unittest.cc
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/components/ntp_snippets/remote/remote_suggestions_scheduler.h
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.cc
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/components/ntp_snippets/remote/remote_suggestions_scheduler_impl.h
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/components/ntp_snippets/remote/remote_suggestions_scheduler_impl_unittest.cc
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/ios/chrome/browser/content_suggestions/content_suggestions_coordinator.mm
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/tools/metrics/histograms/enums.xml
[modify] https://crrev.com/54526ffcba714c1106181235cb63fdbb2aee3fbb/tools/metrics/histograms/histograms.xml

Comment 3 by jkrcal@chromium.org, Jul 24 2017

Status: Fixed (was: Assigned)

Sign in to add a comment