New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678257 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jun 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug



Sign in to add a comment

Cocoa browser decoration bubble direction needs to be reversed in RTL

Project Member Reported by lgrey@chromium.org, Jan 4 2017

Issue description

Currently, they point in the same direction as RTL and can go off-screen.
 

Comment 1 by lgrey@chromium.org, Feb 24 2017

Cc: ranjitkan@chromium.org lgrey@chromium.org tapted@chromium.org ellyjo...@chromium.org brajkumar@chromium.org rnimmagadda@chromium.org nyerramilli@chromium.org shrike@chromium.org
 Issue 645405  has been merged into this issue.
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 27 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0d2ad84ffb7dfb632cbfe9f847daa931ae128344

commit 0d2ad84ffb7dfb632cbfe9f847daa931ae128344
Author: lgrey <lgrey@chromium.org>
Date: Mon Feb 27 16:27:04 2017

[Mac] Make bubble arrow location/position RTL-aware

Instead of left and right, callers now specify leading and trailing. For
LTR, leading = left, and trailing = right, and in RTL they are reversed.

BUG= 678257 

Review-Url: https://codereview.chromium.org/2717603003
Cr-Commit-Position: refs/heads/master@{#453232}

[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/autofill/card_unmask_prompt_view_bridge.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/base_bubble_controller.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/base_bubble_controller_unittest.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/bookmarks/bookmark_bubble_controller.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/content_settings/content_setting_bubble_cocoa.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/extensions/extension_action_platform_delegate_cocoa.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/extensions/extension_installed_bubble_controller.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/extensions/toolbar_actions_bar_bubble_mac.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/info_bubble_view.h
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/info_bubble_view.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/passwords/passwords_bubble_controller.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/validation_message_bubble_cocoa.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/website_settings/chooser_bubble_ui_cocoa.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/website_settings/permission_bubble_controller.mm
[modify] https://crrev.com/0d2ad84ffb7dfb632cbfe9f847daa931ae128344/chrome/browser/ui/cocoa/website_settings/website_settings_bubble_controller.mm

Cc: lgar...@chromium.org
Labels: Needs-Feedback
Fixed?

Comment 5 by lgrey@chromium.org, Jun 23 2017

Status: Fixed (was: Assigned)

Sign in to add a comment