Implement DOMQuad and DOMQuadInit. we should implement DOMQuad and DOMQuadInit. spec link: https://drafts.fxtf.org/geometry/#domquad https://drafts.fxtf.org/geometry/#dictdef-domquadinit
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4ebe01d1636b1ed0b258584b2485470646f7aec9 commit 4ebe01d1636b1ed0b258584b2485470646f7aec9 Author: hs1217.lee <hs1217.lee@samsung.com> Date: Fri Jan 13 01:44:34 2017 [GeometryInterface] Implement DOMQuad and DOMQuadInit. Objects implementing the DOMQuad interface represents a quadrilateral. first, constructor was added in this CL. and i will add other functions in follow up CL. spec list: https://drafts.fxtf.org/geometry/#domquad https://drafts.fxtf.org/geometry/#dictdef-domquadinit BUG= 678237 Review-Url: https://codereview.chromium.org/2615653003 Cr-Commit-Position: refs/heads/master@{#443446} [add] https://crrev.com/4ebe01d1636b1ed0b258584b2485470646f7aec9/third_party/WebKit/LayoutTests/fast/dom/geometry-interface-dom-quad.html [modify] https://crrev.com/4ebe01d1636b1ed0b258584b2485470646f7aec9/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/4ebe01d1636b1ed0b258584b2485470646f7aec9/third_party/WebKit/Source/bindings/core/v8/BUILD.gn [modify] https://crrev.com/4ebe01d1636b1ed0b258584b2485470646f7aec9/third_party/WebKit/Source/core/core_idl_files.gni [modify] https://crrev.com/4ebe01d1636b1ed0b258584b2485470646f7aec9/third_party/WebKit/Source/core/dom/BUILD.gn [add] https://crrev.com/4ebe01d1636b1ed0b258584b2485470646f7aec9/third_party/WebKit/Source/core/dom/DOMQuad.cpp [add] https://crrev.com/4ebe01d1636b1ed0b258584b2485470646f7aec9/third_party/WebKit/Source/core/dom/DOMQuad.h [add] https://crrev.com/4ebe01d1636b1ed0b258584b2485470646f7aec9/third_party/WebKit/Source/core/dom/DOMQuad.idl [add] https://crrev.com/4ebe01d1636b1ed0b258584b2485470646f7aec9/third_party/WebKit/Source/core/dom/DOMQuadInit.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/35ae2da872692c4a5c9570dd5d70f1a13ac7f754 commit 35ae2da872692c4a5c9570dd5d70f1a13ac7f754 Author: hs1217.lee <hs1217.lee@samsung.com> Date: Wed Jan 18 13:49:47 2017 [GeometryInterface] add toJSON() function in DOMQuad Return the result of jsonObject which has all attributes. spec list: https://drafts.fxtf.org/geometry/#domquad BUG= 678237 Review-Url: https://codereview.chromium.org/2635543003 Cr-Commit-Position: refs/heads/master@{#444345} [modify] https://crrev.com/35ae2da872692c4a5c9570dd5d70f1a13ac7f754/third_party/WebKit/LayoutTests/fast/dom/geometry-interface-dom-quad.html [modify] https://crrev.com/35ae2da872692c4a5c9570dd5d70f1a13ac7f754/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/35ae2da872692c4a5c9570dd5d70f1a13ac7f754/third_party/WebKit/Source/core/dom/DOMQuad.cpp [modify] https://crrev.com/35ae2da872692c4a5c9570dd5d70f1a13ac7f754/third_party/WebKit/Source/core/dom/DOMQuad.h [modify] https://crrev.com/35ae2da872692c4a5c9570dd5d70f1a13ac7f754/third_party/WebKit/Source/core/dom/DOMQuad.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/05e25435cee9bdd3da715ed0725f06ee2b8cdd03 commit 05e25435cee9bdd3da715ed0725f06ee2b8cdd03 Author: hs1217.lee <hs1217.lee@samsung.com> Date: Thu Jan 19 06:39:08 2017 [GeometryInterface] add fromRect function in DOMQuad. The fromRect(other) static method on DOMQuad must create a DOMQuad from the DOMRectInit dictionary other. To create a DOMQuad from a DOMRectInit dictionary other, follow these steps: 1.Let x, y, width and height be the value of other’s x, y, width and height attributes, respectively. 2.Let point 1 be a new DOMPoint object with x set to x, y set to y, z set to zero and w set to one. 3.Let point 2 be a new DOMPoint object with x set to x + width, y set to y, z set to zero and w set to one. 4.Let point 3 be a new DOMPoint object with x set to x + width, y set to y + height, z set to zero and w set to one. 5.Let point 4 be a new DOMPoint object with x set to x, y set to y + height, z set to zero and w set to one. 6.Return a new DOMQuad with p1 set to point 1, p2 set to point 2, p3 set to point 3 and p4 set to point 4. spec list: https://drafts.fxtf.org/geometry/#dom-domquad-fromrect BUG= 678237 Review-Url: https://codereview.chromium.org/2639983002 Cr-Commit-Position: refs/heads/master@{#444666} [modify] https://crrev.com/05e25435cee9bdd3da715ed0725f06ee2b8cdd03/third_party/WebKit/LayoutTests/fast/dom/geometry-interface-dom-quad.html [modify] https://crrev.com/05e25435cee9bdd3da715ed0725f06ee2b8cdd03/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/05e25435cee9bdd3da715ed0725f06ee2b8cdd03/third_party/WebKit/Source/core/dom/DOMQuad.cpp [modify] https://crrev.com/05e25435cee9bdd3da715ed0725f06ee2b8cdd03/third_party/WebKit/Source/core/dom/DOMQuad.h [modify] https://crrev.com/05e25435cee9bdd3da715ed0725f06ee2b8cdd03/third_party/WebKit/Source/core/dom/DOMQuad.idl
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/d0ab8b3f65a2c53f1e050b808ea1dc3dae2f4508 commit d0ab8b3f65a2c53f1e050b808ea1dc3dae2f4508 Author: hs1217.lee <hs1217.lee@samsung.com> Date: Wed Feb 15 05:25:36 2017 [GeometryInterface] add getBounds function in DOMQaud. The getBounds() method, when invoked, must run the following algorithm: 1.Let bounds be a DOMRect object. 2.Let left be the minimum of p1.x, p2.x, p3.x and p4.x. 3.Let top be the minimum of p1.y, p2.y, p3.y and p4.y. 4.Let right be the maximum of p1.x, p2.x, p3.x and p4.x. 5.Let bottom be the maximum of p1.y, p2.y, p3.y and p4.y. 6.Let x coordinate of bounds be left, y coordinate of bounds be top, width dimension of bounds be right - left and height dimension of bounds be bottom - top. 7.Return bounds. spec list: https://drafts.fxtf.org/geometry/#dom-domquad-getbounds BUG= 678237 Review-Url: https://codereview.chromium.org/2680023003 Cr-Commit-Position: refs/heads/master@{#450556} [modify] https://crrev.com/d0ab8b3f65a2c53f1e050b808ea1dc3dae2f4508/third_party/WebKit/LayoutTests/fast/dom/geometry-interface-dom-quad.html [modify] https://crrev.com/d0ab8b3f65a2c53f1e050b808ea1dc3dae2f4508/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt [modify] https://crrev.com/d0ab8b3f65a2c53f1e050b808ea1dc3dae2f4508/third_party/WebKit/Source/core/dom/DOMQuad.cpp [modify] https://crrev.com/d0ab8b3f65a2c53f1e050b808ea1dc3dae2f4508/third_party/WebKit/Source/core/dom/DOMQuad.h [modify] https://crrev.com/d0ab8b3f65a2c53f1e050b808ea1dc3dae2f4508/third_party/WebKit/Source/core/dom/DOMQuad.idl
Hwanseung, please update this issue. I think you should update 'Exposed=' in WebIDL.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b9414864f5480e5f83d24ecb949e60834e388a79 commit b9414864f5480e5f83d24ecb949e60834e388a79 Author: hs1217.lee <hs1217.lee@samsung.com> Date: Mon Mar 13 23:34:03 2017 [GeometryInterface] file name was renamed for consistency with others. geometry-interface-dom-quad.html -> geometry-interfaces-dom-quad.html BUG= 678237 Review-Url: https://codereview.chromium.org/2734693003 Cr-Commit-Position: refs/heads/master@{#456543} [rename] https://crrev.com/b9414864f5480e5f83d24ecb949e60834e388a79/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-quad.html
@jinho.bang Exposed keyword was enabled. (https://chromium.googlesource.com/chromium/src/+/f1c3dbc05ae362562665108771589d20b1d499ac)
Comment 1 by hs1217....@samsung.com
, Jan 4 2017