New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678236 link

Starred by 3 users

Issue metadata

Status: Verified
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug

Blocking:
issue 678232



Sign in to add a comment

Add debug flag for slowing down all UI animations

Project Member Reported by reve...@chromium.org, Jan 4 2017

Issue description

This is useful when debugging ChromeOS UI performance problems.
 
Components: UI
Status: Fixed (was: Assigned)
Status: Verified (was: Fixed)
Project Member

Comment 5 by bugdroid1@chromium.org, Apr 14 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5be07ac89aea29234eb908ec661881fb977bdd9b

commit 5be07ac89aea29234eb908ec661881fb977bdd9b
Author: reveman <reveman@chromium.org>
Date: Fri Apr 14 01:06:05 2017

ui: Add debug flag to show composited layer borders in ChromeOS UI.

This adds an entry to chrome://flags that allows layer borders to be
enabled for Chrome OS UI.

It also makes the debug border setting a bitset so borders for individual
layer types can be enabled. This makes the debug flag more useful when
debugging a specific layer type (e.g. render surface layers).

BUG= 678236 
TEST=chrome --ui-show-composited-layer-borders=renderpass
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2795703002
Cr-Commit-Position: refs/heads/master@{#464640}

[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/ash/debug.cc
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/cc/base/switches.cc
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/cc/base/switches.h
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/cc/debug/layer_tree_debug_state.h
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/cc/layers/layer_impl.cc
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/cc/layers/layer_impl.h
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/cc/layers/picture_layer_impl.cc
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/cc/layers/render_surface_impl.cc
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/cc/layers/surface_layer_impl.cc
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/chrome/browser/about_flags.cc
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/content/renderer/gpu/render_widget_compositor.cc
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/tools/metrics/histograms/histograms.xml
[modify] https://crrev.com/5be07ac89aea29234eb908ec661881fb977bdd9b/ui/compositor/compositor.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Apr 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6d95550bbaff9236f28b6c4e48a6728bbd70a961

commit 6d95550bbaff9236f28b6c4e48a6728bbd70a961
Author: reveman <reveman@chromium.org>
Date: Mon Apr 17 19:25:16 2017

content: Fix devtools layer border rendering.

Set show_debug_borders field properly in
RenderWidgetCompositor::SetShowDebugBorders. This used to be
a boolean but is now a bitset.

BUG= 678236 
TEST=Inspect > Rendering > "layer borders"

Review-Url: https://codereview.chromium.org/2827433003
Cr-Commit-Position: refs/heads/master@{#464976}

[modify] https://crrev.com/6d95550bbaff9236f28b6c4e48a6728bbd70a961/content/renderer/gpu/render_widget_compositor.cc

Sign in to add a comment