chrome_public_test_apk on Android failing on chromium.linux/Android Tests |
|||
Issue descriptionBecause of CL https://codereview.chromium.org/2593393002 test org.chromium.chrome.browser.infobar.SearchGeolocationDisclosureInfoBarTest#testInfoBarAppears fails on Android Tests: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests, for example here https://uberchromegw.corp.google.com/i/chromium.linux/builders/Android%20Tests/builds/36590 . Revert is failed because of merge conflicts.
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3e6bea2055bd4ef651fbe9c58183abf7965726f commit a3e6bea2055bd4ef651fbe9c58183abf7965726f Author: mfomitchev <mfomitchev@chromium.org> Date: Wed Jan 04 18:36:43 2017 Marking SearchGeolocationDisclosureInfoBarTest#testInfoBarAppears as flaky. TBR=dfalcantara,benwells BUG= 678210 Review-Url: https://codereview.chromium.org/2610913002 Cr-Commit-Position: refs/heads/master@{#441415} [modify] https://crrev.com/a3e6bea2055bd4ef651fbe9c58183abf7965726f/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java
,
Jan 9 2017
ping, is this test assigned to the correct owner?
,
Jan 10 2017
Yes it's correctly assigned. Sorry about the silence. I can't repro the problem locally or on try bots ... I'm thinking the easiest thing to do would be to add some more logging to the test to find out exactly what is happening, land it temporarily, then take it from there.
,
Jan 10 2017
IIRC from the last sheriff looking at it, I wouldn't be surprised if it was because the infobar removal animation was still going on when the assert was checking if there were no infobars remaining after navigation. I don't know when the infobar is actually removed from the container, though.
,
Jan 10 2017
That makes sense and is probably it. Maybe there is something simple I can try and see if it works.
,
Jan 10 2017
Removing Sheriff-Chromium label since this is assigned now.
,
Jan 11 2017
SearchGeolocationDisclosureInfoBarTest#testInfoBarDismiss seems to also be flaky: https://build.chromium.org/p/chromium.linux/builders/Android%20Tests/builds/36739
,
Jan 13 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b21f1b10efb4895b91ef5ba1e445e38b6e64aaa3 commit b21f1b10efb4895b91ef5ba1e445e38b6e64aaa3 Author: benwells <benwells@chromium.org> Date: Fri Jan 13 05:39:03 2017 Fix flaky Android Search Geolocation Disclosure tests. These tests are flaky because there is a delay between infobars being removed in the native InfobarManager, and this flowing through the the Java side of things. This change introduces a polling loop whenever an infobar is removed to account for this. BUG= 678210 Review-Url: https://codereview.chromium.org/2621983003 Cr-Commit-Position: refs/heads/master@{#443500} [modify] https://crrev.com/b21f1b10efb4895b91ef5ba1e445e38b6e64aaa3/chrome/android/javatests/src/org/chromium/chrome/browser/banners/AppBannerManagerTest.java [modify] https://crrev.com/b21f1b10efb4895b91ef5ba1e445e38b6e64aaa3/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/InfoBarTest.java [modify] https://crrev.com/b21f1b10efb4895b91ef5ba1e445e38b6e64aaa3/chrome/android/javatests/src/org/chromium/chrome/browser/infobar/SearchGeolocationDisclosureInfoBarTest.java [modify] https://crrev.com/b21f1b10efb4895b91ef5ba1e445e38b6e64aaa3/chrome/test/android/javatests/src/org/chromium/chrome/test/util/InfoBarUtil.java
,
Jan 13 2017
Hopefully fixed now. |
|||
►
Sign in to add a comment |
|||
Comment 1 by mfomitchev@chromium.org
, Jan 4 2017