Issue metadata
Sign in to add a comment
|
Regression : Weird behaviour is seen on detaching a Tab in fullscreen mode.
Reported by
yfulgaon...@etouch.net,
Jan 4 2017
|
||||||||||||||||||||||
Issue descriptionChrome Version : 56.0.2924.51 (Official Build) a4bd8fa062f8116ca754c88c4c421187ff567555-refs/branch-heads/2924@{#663} 64 bit OS : Mac(10.12.1, 10.11.6, 10.12) Precondition : Freshly install chrome. What steps will reproduce the problem? 1. Launch chrome, open two tabs (Tab 1 and Tab 2) and click on browser fullscreen button (browser enters into fullscreen mode). 2. Drag Tab 2 and drop it to the extreme bottom right corner such that the tab get detached. 3. Now drag the Tab 2 to the middle of the screen and drop it. 4. Again drag Tab 2 (but do not release the mouse button) and observe. Actual : Weird behaviour is seen on detaching a Tab in fullscreen mode. Expected : Tab detaching should be proper in fullscreen mode. This is a regression issue broken in ‘M-53’, below is the Manual Regression range and Narrow Bisect info. Good build : 53.0.2748.0 Bad build : 53.0.2750.0 Narrow Bisect info : https://chromium.googlesource.com/chromium/src/+log/c3b3aeb0980b256b8234d5d836cae2e452ae9c82..540173f9b77d793d320d25468d5a775965344894?pretty=fuller&n=10000 Suspecting : r395772 from Narrow Bisect Note : This is Mac OS specific issue and the same is not reproducible on Windows & Linux OS.
,
Jan 23 2017
Just to update, still able to reproduce the issue on Mac 10.12.2 using latest chrome version #58.0.2990.0. spqchan@ - Gentle Ping...!! Could you please have a look into this issue. Thanks...!!
,
Jan 25 2017
,
Feb 2 2017
,
Feb 2 2017
The CL has landed: https://chromium.googlesource.com/chromium/src/+/a7140be113cefff6413d285e9bce20b513f52686 commit a7140be113cefff6413d285e9bce20b513f52686 [log] [tgz] author spqchan <spqchan@chromium.org> Thu Feb 02 18:39:19 2017 committer Commit bot <commit-bot@chromium.org> Thu Feb 02 18:39:19 2017 tree 9ac0dc28817cf1ef6f5f148aba712dbabbcbefde parent 5e86b62256b5d7cdc7a10f57c06a1b040e2bbede [diff] [Mac] Fullscreen layout issues - Fixed the incorrect y offset for tab detached windows in fullscreen - Fixed the layout issue with the infobar in fullscreen BUG= 670445 , 678204 Review-Url: https://codereview.chromium.org/2666213003 Cr-Commit-Position: refs/heads/master@{#447804}
,
Feb 2 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a7140be113cefff6413d285e9bce20b513f52686 commit a7140be113cefff6413d285e9bce20b513f52686 Author: spqchan <spqchan@chromium.org> Date: Thu Feb 02 18:39:19 2017 [Mac] Fullscreen layout issues - Fixed the incorrect y offset for tab detached windows in fullscreen - Fixed the layout issue with the infobar in fullscreen BUG= 670445 , 678204 Review-Url: https://codereview.chromium.org/2666213003 Cr-Commit-Position: refs/heads/master@{#447804} [modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h [modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm [modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm [modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm [modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/tabs/tab_window_controller.h [modify] https://crrev.com/a7140be113cefff6413d285e9bce20b513f52686/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
,
Feb 3 2017
Your change meets the bar and is auto-approved for M57. Please go ahead and merge the CL to branch 2987 manually. Please contact milestone owner if you have questions. Owners: amineer@(clank), cmasso@(bling), ketakid@(cros), govind@(desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Feb 3 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9045f614d43726ac315078312899f4973db5be64 commit 9045f614d43726ac315078312899f4973db5be64 Author: spqchan <spqchan@chromium.org> Date: Fri Feb 03 21:32:39 2017 [Mac] Fullscreen layout issues - Fixed the incorrect y offset for tab detached windows in fullscreen - Fixed the layout issue with the infobar in fullscreen BUG= 670445 , 678204 Review-Url: https://codereview.chromium.org/2666213003 Cr-Commit-Position: refs/heads/master@{#447804} (cherry picked from commit a7140be113cefff6413d285e9bce20b513f52686) Review-Url: https://codereview.chromium.org/2671073002 . Cr-Commit-Position: refs/branch-heads/2987@{#300} Cr-Branched-From: ad51088c0e8776e8dcd963dbe752c4035ba6dab6-refs/heads/master@{#444943} [modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/browser_window_controller.mm [modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/browser_window_controller_private.mm [modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.h [modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller.mm [modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/fullscreen/fullscreen_toolbar_controller_unittest.mm [modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/tabs/tab_strip_drag_controller.mm [modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/tabs/tab_window_controller.h [modify] https://crrev.com/9045f614d43726ac315078312899f4973db5be64/chrome/browser/ui/cocoa/tabs/tab_window_controller.mm
,
Feb 8 2017
Tested this issue on Mac OS 10.12 using chrome latest M57-57.0.2987.37 by following steps mentioned in the original comment. Observed still black screen is seen while detaching the tab in full screen. spqchan@ Attaching the screen-cast of the behavior, could you please let us know what's the expected behavior of this issue to verify it from chrome-TE end. Thanks!
,
Feb 8 2017
Based on comment#9 comparison with bug report part of the bug looks to be fixed i.e., when we drag a tab out from the browser we still have the "New Tab", Where in the later part still was the same once the tab is completely dragged to the bottom of the page.
,
Feb 8 2017
I can't reproduce any of the issues on the screencast at #9
,
Feb 9 2017
The problem in c#9 (steps to reproduce in the original bug report) still exists. This is in 58.0.3006.0 Canary. Here are steps: 1. Create a new window with two tabs (call them, ordered left to right, A and B) 2. Place the window in fullscreen mode 3. Drag tab B down to the lower-right corner of the screen (your mouse should be placed as far down and to the right as possible) 4. Release the mouse - tab B now snaps to its own space 5. Drag tab B out of its window - I'm not sure you should be able to do this because it's the only tab in the window. When you do this, tab B exits its dedicated space and you see tab A again. 6. Release tab B in the middle of the screen. 7. Start dragging tab B again At this point Chrome window dragging gets really confused.
,
Feb 9 2017
Sorry, should've mentioned more in #11. I can't drag tab B out of its own window.
,
Feb 9 2017
See Issue 690257 for a screengrab movie of Tab B dragging out of a fullscreen window in the latest canary.
,
Feb 10 2017
,
Mar 4 2017
,
Mar 15 2017
,
Mar 15 2017
,
Aug 27
,
Aug 27
,
Aug 31
,
Nov 15
Update: ***Mass UI Triage*** We were unable to reproduce this bug on latest Canary version #72.0.3611.0. If this bug still reproduces for you, please reopen or file a new issue. Thanks! |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by rbasuvula@chromium.org
, Jan 17 2017