New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678166 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Make bots in chromium.webrtc[.fyi] report to flakiness dashboard

Project Member Reported by kjellander@chromium.org, Jan 4 2017

Issue description

It would be useful if our bots in chromium.webrtc[.fyi] waterfalls could report to flakiness dashboard. I investigated a test today and noticed they're not:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=content_browsertests&tests=WebRtcDataChannelTest.DataChannelGC

Since these bots are using plain Chromium recipes, I think it's very simple to do. It might be only a configuration thing for the flakiness dashboard?



 
Cc: sergeybe...@chromium.org
+sergeyberezin to be sure, since the Infra>Flakiness>Dashboard component doesn't seem to have any default owner (but maybe it's triaged anyway?).
Cc: -sergeybe...@chromium.org serg...@chromium.org
Status: Available (was: Untriaged)
I think you meant the other Sergiy, who has been working with this code recently. (changed on the cc line)

Sergiy is out this week but if you want to send me a CL to add chromium.webrtc.* here:
https://chromium.googlesource.com/infra/infra/+/master/go/src/infra/appengine/test-results/masters/masters.go

I will approve it and deploy it and we can see if that fixes it. Do you see the upload steps on the builder already?
Thanks Erik, you're right.
I created https://chromium-review.googlesource.com/422773 for the test-results change. I don't see any separate upload steps on our bots, so I can look into updating the recipes for that once the server-side change is landed + deployed.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/infra/infra.git/+/99520980888a8d660b5b6cabb3112f8e158e840b

commit 99520980888a8d660b5b6cabb3112f8e158e840b
Author: Henrik Kjellander <kjellander@chromium.org>
Date: Wed Jan 04 07:41:05 2017

Add chromium.webrtc[.fyi] masters to flakiness dashboard

BUG= 678166 

Change-Id: I58a94c9542c233593c0208ec986ef0ad54290cac
Reviewed-on: https://chromium-review.googlesource.com/422773
Reviewed-by: Erik Staab <estaab@chromium.org>
Commit-Queue: Henrik Kjellander <kjellander@chromium.org>

[modify] https://crrev.com/99520980888a8d660b5b6cabb3112f8e158e840b/go/src/infra/appengine/test-results/masters/masters.go

Owner: kjellander@chromium.org
Status: Fixed (was: Available)
Deploying #4 to prod.
Status: Assigned (was: Fixed)
Looks like the masters are still not listed in the list of builders on https://test-results.appspot.com/dashboards/flakiness_dashboard.html for browser_tests. Looks like results are not being uploaded, so there is more work to be done on this bug.
Right, I mistakenly assumed it would just work when whitelisting the master. 
I'll make sure the missing steps are added to our bots.
Status: Fixed (was: Assigned)
Well, that was useless it seems. 
We still have perf tests in browser_tests and content_browsertests binaries, so we have to have perf reporting enabled. That however (correctly) prevents us from enabling flakiness dashboard reporting for these tests (https://cs.chromium.org/chromium/build/scripts/slave/recipe_modules/chromium/api.py?rcl=0&l=338) so I guess to get this we first need to finish our work moving these tests out of there.
Marking this as fixed since what we asked for here is done. Thanks!
It wasn't useless, since otherwise Test Results Server would be ignoring data uploaded from chromium.webkit.fyi master. But o'course you'd need to actually upload the data to see the results on the Flakiness Dashboard.

Sign in to add a comment