New issue
Advanced search Search tips

Issue 678165 link

Starred by 1 user
Status: Fixed
Owner:
karandeepb@chromium.org
Closed: Jan 2017
Cc:
ellyjo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

MacViews: Cancel button can still get default button styling with Harmony enabled.

Project Member Reported by karandeepb@chromium.org, Jan 4 2017 
Chrome Version: 57.0.2970.0
OS: Mac

What steps will reproduce the problem?
(1) Enable chrome://flags//secondary-ui-md.
(2) Open Collected Cookies dialog.

What is the expected result?
Close Button should not have default button styling.

What happens instead?
Close Button has default button styling, but it does not behave like the default button (Doesn't respond to Return).

Comment 1 Deleted

Comment 2 by karandeepb@chromium.org, Jan 4 2017

Cc: ellyjo...@chromium.org
See related  issue 605652 . https://codereview.chromium.org/2151933002 added kDialogDefaultButtonCanBeCancel but this probably regressed later.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/eaff8e380fa4ef7ad90a5929eb35ce81df786f70

commit eaff8e380fa4ef7ad90a5929eb35ce81df786f70
Author: karandeepb <karandeepb@chromium.org>
Date: Thu Jan 05 10:03:31 2017

MacViews: Ensure cancel buttons don't get default button styling.

r406276 introduced kDialogDefaultButtonCanBeCancel to ensure buttons with the
type DIALOG_BUTTON_CANCEL do not have default button styling on Mac.
Subsequently, r420488 made all default dialog buttons blue on Harfmony. This CL
changes DialogClientView::CreateDialogButton to take
kDialogDefaultButtonCanBeCancel into consideration before applying the default
button styling on Harmony. This ensures Cancel buttons under Harmony on MacViews
do not get the default button styling.

BUG=  678165 ,  605652 
TEST= On Mac, enable chrome://flags//secondary-ui-md. Open Collected Cookies
dialog. Ensure close button does not have default button styling.

Review-Url: https://codereview.chromium.org/2615563003
Cr-Commit-Position: refs/heads/master@{#441615}

[modify] https://crrev.com/eaff8e380fa4ef7ad90a5929eb35ce81df786f70/ui/views/window/dialog_client_view.cc

Comment 4 by karandeepb@chromium.org, Jan 5 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment