New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 678145 link

Starred by 1 user
Status: Fixed
Owner:
hansberry@chromium.org
Closed: Jan 2017
Cc:
█ jlklein@chromium.org
khorimoto@chromium.org
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

CryptAuthDeviceManager incorrectly assumes BeaconSeed data from server is Base64 encoded, resulting in garbled data on database persistence

Project Member Reported by hansberry@chromium.org, Jan 4 2017 
Values stored in the dictionary backing CryptauthDeviceManager must be valid UTF strings. The incoming raw BeaconSeed data are not valid UTF strings. When pulled out of the dictionary, they are garbled and incorrect.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac31f879c80a4bbb2a1b089da4ea073d87d5060b

commit ac31f879c80a4bbb2a1b089da4ea073d87d5060b
Author: hansberry <hansberry@chromium.org>
Date: Wed Jan 04 20:16:03 2017

Tweak CryptauthDeviceManager to store fetched BeaconSeed data in Base64URL encoding, and retrieve it as raw data. This is necessary because CryptauthDeviceManager assumed that BeacondSeed data from the server was Base64 encoded, when in reality it was raw.

BUG= 678145 

Review-Url: https://codereview.chromium.org/2611913002
Cr-Commit-Position: refs/heads/master@{#441450}

[modify] https://crrev.com/ac31f879c80a4bbb2a1b089da4ea073d87d5060b/components/cryptauth/cryptauth_device_manager.cc
[modify] https://crrev.com/ac31f879c80a4bbb2a1b089da4ea073d87d5060b/components/cryptauth/cryptauth_device_manager_unittest.cc
[modify] https://crrev.com/ac31f879c80a4bbb2a1b089da4ea073d87d5060b/components/cryptauth/eid_generator.cc
[modify] https://crrev.com/ac31f879c80a4bbb2a1b089da4ea073d87d5060b/components/cryptauth/eid_generator_unittest.cc

Comment 2 by khorimoto@chromium.org, Jan 4 2017

Status: Fixed (was: Untriaged)
►

Sign in to add a comment