Parameters (even const parameters) shouldn't be renamed into kConstantStyle |
|||
Issue description
One known case where this currently occurs is in:
third_party/WebKit/Source/core/editing/commands/TypingCommand.cpp:
void TypingCommand::insertText(Document& document,
EditCommandSource source,
const String& text,
Options options,
TextCompositionType composition,
HERE ----> const bool kIsIncrementalInsertion) {
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ec5c0edf462ee18823f505a754a53622a77a104b commit ec5c0edf462ee18823f505a754a53622a77a104b Author: lukasza <lukasza@chromium.org> Date: Wed Jan 04 23:43:27 2017 ParamVarDecl should never be renamed to kConstantStyle. BUG= 678137 Review-Url: https://codereview.chromium.org/2618543002 Cr-Commit-Position: refs/heads/master@{#441515} [modify] https://crrev.com/ec5c0edf462ee18823f505a754a53622a77a104b/tools/clang/rewrite_to_chrome_style/RewriteToChromeStyle.cpp [modify] https://crrev.com/ec5c0edf462ee18823f505a754a53622a77a104b/tools/clang/rewrite_to_chrome_style/tests/constants-expected.cc [modify] https://crrev.com/ec5c0edf462ee18823f505a754a53622a77a104b/tools/clang/rewrite_to_chrome_style/tests/constants-original.cc
,
Jan 5 2017
,
Apr 17 2017
|
|||
►
Sign in to add a comment |
|||
Comment 1 by lukasza@chromium.org
, Jan 4 2017Owner: ----
Status: Available (was: Assigned)