New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 678108 link

Starred by 1 user
Status: Fixed
Owner:
█ avayvod@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
█ hdodda@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug



Sign in to add a comment

Media.Video.KeyFrameDistance reports constantly incrementing values

Project Member Reported by avayvod@chromium.org, Jan 3 2017 
Seems like the previous frame timestamp is not updated with each keyframe...

Should be a one-line fix that I'd love to merge to 56.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1b539730c8c3ce51ec2f58a3aae2a43af4f32eaa

commit 1b539730c8c3ce51ec2f58a3aae2a43af4f32eaa
Author: avayvod <avayvod@chromium.org>
Date: Wed Jan 04 15:50:19 2017

Fix Media.Video.KeyFrameDistance metric calculation

BUG= 678108 
TEST=manual

Review-Url: https://codereview.chromium.org/2614583002
Cr-Commit-Position: refs/heads/master@{#441381}

[modify] https://crrev.com/1b539730c8c3ce51ec2f58a3aae2a43af4f32eaa/media/filters/decoder_stream_traits.cc

Comment 2 by avayvod@chromium.org, Jan 4 2017

Labels: Merge-Request-56
Project Member

Comment 3 by sheriffbot@chromium.org, Jan 5 2017

Labels: -Merge-Request-56 Hotlist-Merge-Approved Merge-Approved-56
Your change meets the bar and is auto-approved for M56. Please go ahead and merge the CL manually. Please contact milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 5 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3b97686ee715967490e649a302329371893ae05b

commit 3b97686ee715967490e649a302329371893ae05b
Author: Anton Vayvod <avayvod@google.com>
Date: Thu Jan 05 18:24:34 2017

Fix Media.Video.KeyFrameDistance metric calculation

BUG= 678108 
TEST=manual

Review-Url: https://codereview.chromium.org/2614583002
Cr-Commit-Position: refs/heads/master@{#441381}
(cherry picked from commit 1b539730c8c3ce51ec2f58a3aae2a43af4f32eaa)

Review-Url: https://codereview.chromium.org/2614823004 .
Cr-Commit-Position: refs/branch-heads/2924@{#681}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/3b97686ee715967490e649a302329371893ae05b/media/filters/decoder_stream_traits.cc

Comment 5 by avayvod@chromium.org, Jan 5 2017

Status: Fixed (was: Started)

Comment 6 by hdodda@chromium.org, Jan 10 2017

Cc: hdodda@chromium.org
Labels: Needs-Feedback
@avayvod-- Could you please let us know if there are any manual repro steps to reproduce the issue, if there is , please provide us the expected result . So , that we can verify it from Chrome-TE end.

Thanks!

Comment 7 by avayvod@chromium.org, Jan 10 2017 

hdodda@ - not sure, the fix was to make Media.Video.KeyframeDistance report correct values. You could play a video with known time intervals between its keyframes and compare the values collected in the histogram during/after playback.
►

Sign in to add a comment