New issue
Advanced search Search tips

Issue 678100 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 634944
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: ----


Previous locations:
gerrit:5214


Sign in to add a comment

BuildBucket plugin: Issue marked as passing try bots but bots not run?

Project Member Reported by dsinclair@chromium.org, Jan 3 2017

Issue description

I had run the try bots on a previous patchset of https://pdfium-review.googlesource.com/c/2134/ then on PatchSet 3 I clicked the CQ Dry Run button. 

The system then sent https://pdfium-review.googlesource.com/c/2134/#message-39b84c443cc11337e893905bf223ad3c709bd3d0 saying the patch had passed the try jobs but there were no bot results attached to the patchset and our tests take longer to run then 0 seconds.

I then tried clicking the 'x' beside my name in the Commit-Queue +1 section and doing 'CQ Dry Run' again but with the same results. Bots never ran but it's being reported as passed?
 
Labels: -Restrict-View-Google
Project: chromium
Moved issue gerrit:5214 to now be  issue chromium:678100 .
Cc: tandrii@chromium.org
Components: Infra>Codereview>Gerrit
Labels: Milestone-Dogfood Proj-Gerrit-Migration Pri-2
Owner: aga...@chromium.org
Status: Assigned (was: New)
Summary: BuildBucket plugin: Issue marked as passing try bots but bots not run? (was: Issue marked as passing try bots but bots not run?)
We've made CQ smarter and it doesn't re-run jobs if they are already green (except special presubmit builders). The diff between PS 2 and 3 is just commit message (https://pdfium-review.googlesource.com/c/2134/2..3), and hence deemed equivalent by CQ.

I agree that we could perhaps make UI better - agable@ why is PS#3 not displaying  results from PS#2 (see https://pdfium-review.googlesource.com/c/2134/3)? Have we forgotten some kind of config for pdfium host?
Mergedinto: 634944
Status: Duplicate (was: Assigned)
Nope, the plugin has been updated to exhibit that behavior (i.e. show builds from previous patchsets that have identical code to the current one) but (due to the prod freeze) that change hasn't yet been deployed to Gerrit. It will be deployed soon.
As of today, I see the tryjobs from PS2 displayed on PS3.

I don't see them displayed on PS4 (the autogenerated patchset from when the CL was committed). I'll try to figure out why that is.

Sign in to add a comment