New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678090 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug



Sign in to add a comment

[veyron] Audio node selection is not remembered after reboot.

Project Member Reported by son...@google.com, Jan 3 2017

Issue description

ChromeOS Version: 9147.0.0
Device: Speedy

What steps will reproduce the problem?
(1) Sign in to the device.
(2) Plug USB headset and 3.5 mm headset.
(3) change the audio input to onboard speaker.
(4) Reboot the device.
(5) check the audio node settings.

What is the expected result?
Audio node selection should be remembered across the reboots.

What happens instead?
Audio node selection is not remembered across the reboots.
USB audio node is selected after rebooting the device.

Please use labels and text to provide additional information.


For graphics-related bugs, please copy/paste the contents of the about:gpu
page at the end of this report.

 
Owner: hychao@chromium.org
Status: Assigned (was: Untriaged)
Is this a side effect of the change to how persistent USB IDs were generated?

Comment 3 by son...@google.com, Jan 4 2017

Summary: [veyron] Audio node selection is not remembered after reboot. (was: [veyron-speedy] Audio node selection is not remembered after reboot.)
Able to reproduce this issue on 9147.0.0_minnie 

Not able to reproduce on Candy and daisy-skate
Unable to reproduce on Peppy.
Cc: hychao@chromium.org jen...@chromium.org
Owner: tbarzic@chromium.org
Reproduced on veyron_speedy, and after bisect(57.0.2955.0 - bad, 57.0.2952.0 - good). I believe the causing CL is https://codereview.chromium.org/2510093003

The new stable id change somehow causes problem on veyron, but not on other devices.
According to my experience, USB headsets are discovered with a longer delay on veyron devices compared to others. Maybe that has bad effect with this CL?

I don't see any trivial problem in the code, assign to tbarzic@.

After reboot, CrasAudioHandler::HandleHotPlugDevice() should find out the USB headset wasn't in 'active' state and stick active node to internal speaker.
Status: Started (was: Assigned)
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 13 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/adhd/+/29ff3ba4f2470ee5ac22d947f3509021541453f0

commit 29ff3ba4f2470ee5ac22d947f3509021541453f0
Author: Toni Barzic <tbarzic@google.com>
Date: Wed Jan 04 23:06:38 2017

CRAS: cras_udev - zero USB card info when created

USB card info is used to derive the device's stable ID.
If any of USB properties that are part of card info is not
properly initialized (which was the case when reading USB
system attributes failed), stable ID will be derived from
unpredictable data - and end up being unstable across reboots.

BUG= chromium:678090 
TEST=1. plug in USB headset,
     2. change active output to another device,
     3. unplug the USB headset
     4. reboot
     5. plug the USB headset again
     6. verify that the USB headset is not activated

Change-Id: I986be152ca6bd97431766d745ffa023afe973237
Reviewed-on: https://chromium-review.googlesource.com/424938
Commit-Ready: Toni Barzic <tbarzic@chromium.org>
Tested-by: Toni Barzic <tbarzic@chromium.org>
Reviewed-by: Hsinyu Chao <hychao@chromium.org>
Reviewed-by: Dylan Reid <dgreid@chromium.org>

[modify] https://crrev.com/29ff3ba4f2470ee5ac22d947f3509021541453f0/cras/src/server/cras_udev.c

Status: Fixed (was: Started)

Comment 9 by son...@google.com, Jan 19 2017

Status: Verified (was: Fixed)
Verified on build 9199.0.0

Sign in to add a comment