Issue metadata
Sign in to add a comment
|
Omnibox append button not reversed for RTL when highlighted |
||||||||||||||||||||||
Issue descriptionChrome Version: Chromium 57.0.2971.0 (ToT) OS: iOS 10.2.1 What steps will reproduce the problem? (0) Switch the system language to an RTL language. (eg: Hebrew) (1) Open Chromium and type a query in the omnibox so that autocomplete suggestions are displayed. (2) Press and hold the append button in a suggestion. What is the expected result? For RTL languages, the append button should appear on the left side of the suggestion and should point to the upper right. Pressing the button should cause it to display the blue, highlighted version of the icon. What happens instead? The blue, highlighted version of the icon is displayed but it is not reversed, so it points to the upper left. Screenshot: (I don't read Hebrew so I hope I didn't write anything offensive...) https://drive.google.com/open?id=1z7YnAEYA-sSr3hmBaX4lEGCWKQpycUIBMA
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6613efc1e1e34ef8da08158330112926c6afd3b8 commit 6613efc1e1e34ef8da08158330112926c6afd3b8 Author: mattreynolds <mattreynolds@chromium.org> Date: Wed Jan 04 18:44:03 2017 Fix iOS omnibox append button highlighted icon for RTL The omnibox append button's normal (un-highlighted) image is correctly reversed for RTL languages, but the imaged displayed when the button is tapped is not. BUG= 678085 Review-Url: https://codereview.chromium.org/2606353004 Cr-Commit-Position: refs/heads/master@{#441418} [modify] https://crrev.com/6613efc1e1e34ef8da08158330112926c6afd3b8/ios/chrome/browser/ui/omnibox/omnibox_popup_material_row.mm
,
Jan 4 2017
,
Jan 10 2017
Verified on M57.0.2976.0 dev Device: iPhone 6 plus iOS: 9.3.5 Append button is displayed correctly with tap and hold. Screenshot: https://drive.google.com/file/d/0B-xmXLQhjeKucTEyM2NpRENlZmM/view |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mattreynolds@chromium.org
, Jan 4 2017