New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 678077 link

Starred by 3 users
Status: Fixed
Owner:
qyears...@chromium.org
Closed: Jan 2017
Cc:
panicker@chromium.org
tkent@chromium.org
jeffcarp@chromium.org
█ sunjian@chromium.org
dpranke@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

[W3C auto-import] Imports are failing on manifest generation stage (due to new upstream format).

Project Member Reported by qyears...@chromium.org, Jan 3 2017 
The latest W3C test import runs are failing with an error like this:

Log excerpt:
...
Deleting any orphaned baselines.
Generating MANIFEST.json
Running command: /mnt/data/b/rr/tmp_NmIEj/w/src/third_party/WebKit/wpt/manifest --tests-root /mnt/data/b/rr/tmp_NmIEj/w/src/third_party/WebKit/LayoutTests/imported/wpt
# ret> 1
# err> DEBUG:manifest:Creating new manifest at /mnt/data/b/rr/tmp_NmIEj/w/src/third_party/WebKit/LayoutTests/imported/wpt/MANIFEST.json
# err> INFO:manifest:Updating manifest
# err> Traceback (most recent call last):
# err>   File "/mnt/data/b/rr/tmp_NmIEj/w/src/third_party/WebKit/wpt/manifest", line 8, in <module>
# err>     os.path.abspath(os.path.dirname(__file__)))
# err>   File "/mnt/data/b/rr/tmp_NmIEj/w/src/third_party/WebKit/wpt/tools/manifest/update.py", line 104, in main
# err>     update_from_cli(**vars(opts))
# err>   File "/mnt/data/b/rr/tmp_NmIEj/w/src/third_party/WebKit/wpt/tools/manifest/update.py", line 46, in update_from_cli
# err>     working_copy=kwargs["work"])
# err>   File "/mnt/data/b/rr/tmp_NmIEj/w/src/third_party/WebKit/wpt/tools/manifest/update.py", line 21, in update
# err>     return manifest.update(tree)
# err>   File "/mnt/data/b/rr/tmp_NmIEj/w/src/third_party/WebKit/wpt/tools/manifest/manifest.py", line 74, in update
# err>     file_hash = source_file.hash
# err>   File "/mnt/data/b/rr/tmp_NmIEj/w/src/third_party/WebKit/wpt/tools/manifest/utils.py", line 49, in __get__
# err>     obj.__dict__[self.name] = self.func(obj)
# err>   File "/mnt/data/b/rr/tmp_NmIEj/w/src/third_party/WebKit/wpt/tools/manifest/sourcefile.py", line 117, in hash
# err>     with self.open() as f:
# err>   File "/mnt/data/b/rr/tmp_NmIEj/w/src/third_party/WebKit/wpt/tools/manifest/sourcefile.py", line 104, in open
# err>     file_obj = open(self.path, 'rb')
# err> IOError: [Errno 2] No such file or directory: '/mnt/data/b/rr/tmp_NmIEj/w/src/third_party/WebKit/LayoutTests/imported/wpt/MANIFEST.json'
step returned non-zero exit code: 1
@@@STEP_FAILURE@@@

This is from https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7851.

Next step: Figure out why this is happening. Also, if the manifest update fails in the future, perhaps we could output a warning and continue trying to import? Or maybe it's better just to fail, but perhaps with a better message.
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/787a1e7a701b094d4c208820f94b3830b35515f3

commit 787a1e7a701b094d4c208820f94b3830b35515f3
Author: qyearsley <qyearsley@chromium.org>
Date: Wed Jan 04 22:51:12 2017

W3C import: Update manifest-updating step after upstream changes.

Background: The recent change https://github.com/w3c/web-platform-tests/commit/758f6c45dd335e276ab822ef5d96ac31398b76e9 updated wpt-tools to include https://github.com/w3c/wpt-tools/commit/8777171a5568e9fa967ef7a807dc400d89a07637, which changed some things about the manifest format and also the way that the manifest update is done.

After that change, the manifest update script looked at all files in the current repo, which in our case is the whole Chromium repo. This CL resolves this by passing the flag --work to the manifest script.

BUG= 678077 

Review-Url: https://codereview.chromium.org/2613753002
Cr-Commit-Position: refs/heads/master@{#441499}

[modify] https://crrev.com/787a1e7a701b094d4c208820f94b3830b35515f3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
[modify] https://crrev.com/787a1e7a701b094d4c208820f94b3830b35515f3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

Comment 2 by qyears...@chromium.org, Jan 5 2017

Status: Started (was: Assigned)
After updating the manifest-generating script, the manifest format is now different, so https://cs.chromium.org/chromium/src/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py?l=815 has to be updated before it will continue to work, and this has to be done before auto-import will work again.

Comment 3 by qyears...@chromium.org, Jan 5 2017

Summary: [W3C auto-import] Imports are failing on manifest generation stage (due to new upstream format). (was: [W3C auto-import] Imports are failing on manifest generation stage)
Update: Now made an import CL (https://codereview.chromium.org/2610243002).

As a follow-up, I'd like to use a pinned revision of the manifest script used by the importer by putting it in webkitpy/thirdparty instead of using the newly-imported copy, so that updates can't unexpectedly break us like this.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 5 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/885339bf7e721e9e4d1afb2c5eb328144b9ab82f

commit 885339bf7e721e9e4d1afb2c5eb328144b9ab82f
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Jan 05 20:54:09 2017

Import wpt@5e1a3b80cea8d36774d2afd78b29a74792e9f15a

Using update-w3c-deps in Chromium 787a1e7a701b094d4c208820f94b3830b35515f3.

Includes a change to port/base.py (and unittest) since the manifest format has now changed ( http://crbug.com/678077 ).

TBR=jsbell,tkent

BUG= 678077 

Review-Url: https://codereview.chromium.org/2610243002
Cr-Commit-Position: refs/heads/master@{#441745}

[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/TestExpectations
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/FileReader-multiple-reads.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/idbindex-rename.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/IndexedDB/idbobjectstore-rename-store.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/WebIDL/current-realm.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/check_stability.py
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/dom/historical.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-exit-fullscreen-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-exit-fullscreen-timing-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-exit-fullscreen-twice-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-fullscreen-element-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/document-onfullscreenchange-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-containing-iframe-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-enabled-flag-not-set-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-fullscreen-element-sibling-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-fullscreen-iframe-child-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-iframe-child-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-ready-check-not-in-document-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-exit-iframe-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-move-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-move-to-iframe-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-remove-iframe-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-and-remove-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-non-top-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-same-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-svg-rect-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-svg-svg-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-timing-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-top-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-twice-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-two-elements-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/api/element-request-fullscreen-two-iframes-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/model/remove-child-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/model/remove-first-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/model/remove-last-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/model/remove-parent-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/model/remove-single-manual.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/fullscreen/trusted-click.js
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/resources/post_name_on_load.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/browsing-the-web/history-traversal/persisted-user-state-restoration/resume-timer-on-history-back.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/history/the-location-interface/location-pathname-setter-question-mark.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/frame.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/win-documentdomain.sub.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/dom/elements/elements-in-the-dom/historical.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-img-element/image.png
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/embedded-content/the-img-element/update-src-complete.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-form-element/form-nameditem.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-input-element/clone.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-select-element/select-validity.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-showModal.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-add.js
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-delete.js
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-match.js
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-matchAll.js
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-put.js
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/script-tests/cache-storage-match.js
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/extendable-event-async-waituntil.https.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/extendable-event-waituntil.https.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/fetch-event.https.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/oninstall-script-error.https.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/performance-timeline.https.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/empty-but-slow-worker.js
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/extendable-event-async-waituntil.js
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/fetch-cors-xhr-iframe.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/fetch-event-network-error-controllee-iframe.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/fetch-event-network-error-worker.js
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/fetch-event-test-worker.js
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/fetch-rewrite-worker.js
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/service-workers/service-worker/resources/oninstall-waituntil-throw-error-worker.js
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/uievents/order-of-events/focus-events/focus-automated-blink-webkit.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/user-timing/resources/webperftestharness.js
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/user-timing/test_user_timing_mark_and_measure_exception_when_invoke_with_timing_attributes.js
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/animation-model/animation-types/addition-per-property.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/animation-model/animation-types/interpolation-per-property.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/animation-model/animation-types/property-list.js
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/animation-model/animation-types/property-types.js
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/animation-model/animation-types/spacing-keyframes-filters.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/animation-model/animation-types/spacing-keyframes-shapes.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/animation-model/animation-types/spacing-keyframes-transform.html
[delete] https://crrev.com/b69a8c43e07497ebd2d6603bbda27ed36a1cc541/third_party/WebKit/LayoutTests/imported/wpt/web-animations/animation-model/animation-types/type-per-property.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/animation-model/combining-effects/effect-composition.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/AnimationEffectTiming/endDelay.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/KeyframeEffect/composite.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/KeyframeEffect/constructor.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/KeyframeEffect/copy-contructor.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/KeyframeEffect/iterationComposite.html
[add] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/KeyframeEffectReadOnly/copy-contructor.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/resources/keyframe-utils.js
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/testcommon.js
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/web-animations/timing-model/animations/current-time.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/LayoutTests/imported/wpt/webrtc/datachannel-emptystring.html
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
[modify] https://crrev.com/885339bf7e721e9e4d1afb2c5eb328144b9ab82f/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base_unittest.py

Comment 5 by qyears...@chromium.org, Jan 5 2017

Cc: sunjian@chromium.org panicker@chromium.org
Status: Fixed (was: Started)
Expected to be fixed now; trying a new auto-import job: https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7854

Comment 6 by delph...@chromium.org, Jan 6 2017 

After this or perhaps the auto-import, none of the imported/wpt tests can be found:

$ python third_party/WebKit/Tools/Scripts/run-webkit-tests -t Default -n third_party/WebKit/LayoutTests/imported/wpt/

...

Found 0 tests; running 0, skipping 0.
No tests to run.

Comment 7 by qyears...@chromium.org, Jan 6 2017

Status: Started (was: Fixed)
Ack! This is almost certainly the cause -- now looking into this, if I can't fix it very quickly, then let's revert that last commit (885339bf7e721e9e4d1afb2c5eb328144b9ab82f)

Comment 8 by qyears...@chromium.org, Jan 6 2017 

Update about what I think happened here: doing that last import updated MANIFEST.json locally as expected, and running the tests worked locally, but the actual MANIFEST.json wasn't uploaded to Rietveld because it's too large, so after commit, the code in port/base.py related to finding layout tests based on MANIFEST.json didn't work with the old MANIFEST.json file.

Comment 9 by qyears...@chromium.org, Jan 6 2017

Cc: dpranke@chromium.org
That is, if I generate the new version of MANIFEST.json locally, then all the tests are found again -- just uploaded a CL to do this (https://codereview.chromium.org/2615903004), although on Rietveld that CL shows up as empty.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d

commit dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d
Author: Quinten Yearsley <qyearsley@google.com>
Date: Fri Jan 06 19:05:20 2017

Update MANIFEST.json to newest version.

Background: Recently in web-platform-tests the format of MANIFEST.json changed, and I filed  http://crbug.com/678077  for this. I committed a change http://crrev.com/2610243002 which updated the layout test runner to find web-platform-tests with the new manifest format, but the actual manifest file was too large to upload to Rietveld and was not committed. After that change, no wpt tests are found when running run-webkit-tests imported/wpt.

This change would update MANIFEST.json, although the actual file is still too large to upload to Rietveld, so this CL (in patch 1 at least) appears empty. I believe it would have to be landed directly.

TBR=dpranke

BUG= 678077 

Review-Url: https://codereview.chromium.org/2615903004 .
Cr-Commit-Position: refs/heads/master@{#441999}

[modify] https://crrev.com/dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d/third_party/WebKit/LayoutTests/imported/wpt/MANIFEST.json

Comment 11 by qyears...@chromium.org, Jan 6 2017

Status: Fixed (was: Started)
Tests are now found again at ToT.

Thanks delphick@ for posting the problem above :-)
Project Member

Comment 12 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e0615e1b33112564698760629bef4b56d80572cd

commit e0615e1b33112564698760629bef4b56d80572cd
Author: Justin DeWitt <dewittj@chromium.org>
Date: Fri Jan 06 21:20:40 2017

Revert of:

    "Import wpt@eeecf3e14368d4ab5221cde688003dedeca30dba"
    This reverts commit cfd8c14d3a0f7fd474248428d230845812848038.

    "Update MANIFEST.json to newest version."
    This reverts commit dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d.

Reason for revert:
Begins running layout tests without proper expectations.

Original issue's description:
> Update MANIFEST.json to newest version.
>
> Background: Recently in web-platform-tests the format of MANIFEST.json changed, and I filed  http://crbug.com/678077  for this. I committed a change http://crrev.com/2610243002 which updated the layout test runner to find web-platform-tests with the new manifest format, but the actual manifest file was too large to upload to Rietveld and was not committed. After that change, no wpt tests are found when running run-webkit-tests imported/wpt.
>
> This change would update MANIFEST.json, although the actual file is still too large to upload to Rietveld, so this CL (in patch 1 at least) appears empty. I believe it would have to be landed directly.
>
> TBR=dpranke
>
> BUG= 678077 
>
> Review-Url: https://codereview.chromium.org/2615903004 .
> Cr-Commit-Position: refs/heads/master@{#441999}
> Committed: https://chromium.googlesource.com/chromium/src/+/dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d

TBR=dpranke@chromium.org,qyearsley@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 678077 

Review-Url: https://codereview.chromium.org/2619613002 .
Cr-Commit-Position: refs/heads/master@{#442054}

[modify] https://crrev.com/e0615e1b33112564698760629bef4b56d80572cd/third_party/WebKit/LayoutTests/imported/wpt/MANIFEST.json

Comment 13 by dewittj@chromium.org, Jan 6 2017

Status: Started (was: Fixed)
I reverted that change and the subsequent roll because it caused widespread webkit_tests failures, eg: 

https://uberchromegw.corp.google.com/i/chromium.webkit/builders/WebKit%20Linux%20Trusty/builds/21810

Comment 14 by qyears...@chromium.org, Jan 6 2017 

Update and explanation: In http://crrev.com/2615903004, the manifest was actually updated, so tests started being run, but the newly-imported failing tests didn't have correct baselines/expectations.

Now trying to fix this by updating the expectations with a new CL, http://crrev.com/2614253003.
Project Member

Comment 15 by bugdroid1@chromium.org, Jan 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2cdab23afa9bf4d85db6926da0bdae66133f3212

commit 2cdab23afa9bf4d85db6926da0bdae66133f3212
Author: qyearsley <qyearsley@chromium.org>
Date: Mon Jan 09 21:29:02 2017

Support both MANIFEST.json formats and update wpt test expectations.

Background: In http://crrev.com/2610243002 web-platform-tests were imported, and the Port class was updated to handle the new MANIFEST.json format. I originally believed that the new MANIFEST.json would also be committed in that CL, but it wasn't, due to file size. So tests were updated, but no tests were run because they weren't found.

Then, in http://crrev.com/2615903004, the manifest was actually updated, so tests started being run, but because of the earlier CL, the newly-imported failing tests didn't have expectations updated.

This CL adds a temporary change to the Port class to support both manifest formats, and updates test expectations.

After this CL:
 - The new MANIFEST.json should be re-added.
 - Port should be updated to support only the new format again.

BUG= 678077 

Review-Url: https://codereview.chromium.org/2614253003
Cr-Commit-Position: refs/heads/master@{#442354}

[modify] https://crrev.com/2cdab23afa9bf4d85db6926da0bdae66133f3212/third_party/WebKit/LayoutTests/TestExpectations
[delete] https://crrev.com/2267cfcce06c92602376754343e5f45effeee1f1/third_party/WebKit/LayoutTests/imported/wpt/FileAPI/reading-data-section/FileReader-multiple-reads-expected.txt
[modify] https://crrev.com/2cdab23afa9bf4d85db6926da0bdae66133f3212/third_party/WebKit/LayoutTests/imported/wpt/dom/historical-expected.txt
[modify] https://crrev.com/2cdab23afa9bf4d85db6926da0bdae66133f3212/third_party/WebKit/LayoutTests/imported/wpt/html/browsers/origin/cross-origin-objects/cross-origin-objects-exceptions-expected.txt
[modify] https://crrev.com/2cdab23afa9bf4d85db6926da0bdae66133f3212/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/forms/the-form-element/form-nameditem-expected.txt
[modify] https://crrev.com/2cdab23afa9bf4d85db6926da0bdae66133f3212/third_party/WebKit/LayoutTests/imported/wpt/html/semantics/interactive-elements/the-dialog-element/dialog-showModal-expected.txt
[modify] https://crrev.com/2cdab23afa9bf4d85db6926da0bdae66133f3212/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/window/cache-matchAll.https-expected.txt
[modify] https://crrev.com/2cdab23afa9bf4d85db6926da0bdae66133f3212/third_party/WebKit/LayoutTests/imported/wpt/service-workers/cache-storage/worker/cache-matchAll.https-expected.txt
[modify] https://crrev.com/2cdab23afa9bf4d85db6926da0bdae66133f3212/third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/Animation/finish-expected.txt
[modify] https://crrev.com/2cdab23afa9bf4d85db6926da0bdae66133f3212/third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/KeyframeEffect/constructor-expected.txt
[modify] https://crrev.com/2cdab23afa9bf4d85db6926da0bdae66133f3212/third_party/WebKit/LayoutTests/imported/wpt/web-animations/interfaces/KeyframeEffect/iterationComposite-expected.txt
[modify] https://crrev.com/2cdab23afa9bf4d85db6926da0bdae66133f3212/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1297046888300e6524fd1aab198e78bf67481674

commit 1297046888300e6524fd1aab198e78bf67481674
Author: Quinten Yearsley <qyearsley@google.com>
Date: Tue Jan 10 02:49:55 2017

Reland of Update MANIFEST.json to newest version. (patchset #3 id:20001 of https://codereview.chromium.org/2619613002/ )

Reason for revert:
Test expectations were updated in http://crrev.com/2614253003, so layout test baselines and expectations should be up-to-date.

Original issue's description:
> Revert of:
>
>     "Import wpt@eeecf3e14368d4ab5221cde688003dedeca30dba"
>     This reverts commit cfd8c14d3a0f7fd474248428d230845812848038.
>
>     "Update MANIFEST.json to newest version."
>     This reverts commit dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d.
>
> Reason for revert:
> Begins running layout tests without proper expectations.
>
> Original issue's description:
> > Update MANIFEST.json to newest version.
> >
> > Background: Recently in web-platform-tests the format of MANIFEST.json changed, and I filed  http://crbug.com/678077  for this. I committed a change http://crrev.com/2610243002 which updated the layout test runner to find web-platform-tests with the new manifest format, but the actual manifest file was too large to upload to Rietveld and was not committed. After that change, no wpt tests are found when running run-webkit-tests imported/wpt.
> >
> > This change would update MANIFEST.json, although the actual file is still too large to upload to Rietveld, so this CL (in patch 1 at least) appears empty. I believe it would have to be landed directly.
> >
> > TBR=dpranke
> >
> > BUG= 678077 
> >
> > Review-Url: https://codereview.chromium.org/2615903004 .
> > Cr-Commit-Position: refs/heads/master@{#441999}
> > Committed: https://chromium.googlesource.com/chromium/src/+/dc2a9e048fd191a43a35c8f6ee1e4cecb7fc919d
>
> TBR=dpranke@chromium.org,qyearsley@chromium.org
> # Skipping CQ checks because original CL landed less than 1 days ago.
> NOPRESUBMIT=true
> NOTREECHECKS=true
> NOTRY=true
> BUG= 678077 
>
> Review-Url: https://codereview.chromium.org/2619613002 .
> Cr-Commit-Position: refs/heads/master@{#442054}
> Committed: https://chromium.googlesource.com/chromium/src/+/e0615e1b33112564698760629bef4b56d80572cd

R=dpranke@chromium.org
TBR=dewittj@chromium.org, dpranke@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG= 678077 

Review-Url: https://codereview.chromium.org/2625523002 .
Cr-Commit-Position: refs/heads/master@{#442457}

[modify] https://crrev.com/1297046888300e6524fd1aab198e78bf67481674/third_party/WebKit/LayoutTests/imported/wpt/MANIFEST.json
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 12 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4aeafe93320a3851cdebc37a86ec19770c53ade9

commit 4aeafe93320a3851cdebc37a86ec19770c53ade9
Author: qyearsley <qyearsley@chromium.org>
Date: Thu Jan 12 05:08:55 2017

Use a pinned version of web-platform-tests/manifest.

Purpose: This should prevent upstream changes in manifest from breaking
import or test runner unexpectedly.

BUG= 678077 

Review-Url: https://codereview.chromium.org/2630493002
Cr-Commit-Position: refs/heads/master@{#443158}

[modify] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTHeads
[modify] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList
[modify] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/.gitignore
[delete] https://crrev.com/13a86c2faeebcbc12dd4a7e8dea54318da635c19/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/LICENSE
[add] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/LICENSE.md
[add] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest
[add] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/XMLParser.py
[add] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/__init__.py
[add] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/catalog/xhtml.dtd
[add] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/item.py
[add] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/log.py
[add] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/manifest.py
[add] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/sourcefile.py
[add] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/update.py
[add] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/utils.py
[add] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/manifest/vcs.py
[modify] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/serve/serve.py
[modify] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/handlers.py
[modify] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/wptserve/wptserve/server.py
[modify] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
[modify] https://crrev.com/4aeafe93320a3851cdebc37a86ec19770c53ade9/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b8c6519a9b138d12402e34fd305b9fab6f7b403e

commit b8c6519a9b138d12402e34fd305b9fab6f7b403e
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Jan 13 01:38:20 2017

Simplify manifest-related code in Port to only support new format.

BUG= 678077 

Review-Url: https://codereview.chromium.org/2624333004
Cr-Commit-Position: refs/heads/master@{#443441}

[modify] https://crrev.com/b8c6519a9b138d12402e34fd305b9fab6f7b403e/third_party/WebKit/Tools/Scripts/webkitpy/layout_tests/port/base.py
Project Member

Comment 19 by bugdroid1@chromium.org, Jan 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/198405bd55b43aa21b7d76e4188fa44528c2bdc3

commit 198405bd55b43aa21b7d76e4188fa44528c2bdc3
Author: qyearsley <qyearsley@chromium.org>
Date: Fri Jan 13 03:49:34 2017

W3C test importer: Fix path to manifest command.

This is a follow-up fix to http://crrev.com/2630493002.

In that CL, I changed the path to the manifest command but
used the wrong path, resulting in the latest import failing:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7868

The manifest script is actually checked into:
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest

BUG= 678077 

Review-Url: https://codereview.chromium.org/2626183004
Cr-Commit-Position: refs/heads/master@{#443480}

[modify] https://crrev.com/198405bd55b43aa21b7d76e4188fa44528c2bdc3/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/WPTWhiteList
[add] https://crrev.com/198405bd55b43aa21b7d76e4188fa44528c2bdc3/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/gitignore/__init__.py
[add] https://crrev.com/198405bd55b43aa21b7d76e4188fa44528c2bdc3/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/tools/gitignore/gitignore.py
[modify] https://crrev.com/198405bd55b43aa21b7d76e4188fa44528c2bdc3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater.py
[modify] https://crrev.com/198405bd55b43aa21b7d76e4188fa44528c2bdc3/third_party/WebKit/Tools/Scripts/webkitpy/w3c/deps_updater_unittest.py

Comment 20 by qyears...@chromium.org, Jan 13 2017

Status: Fixed (was: Started)

Comment 21 by foolip@chromium.org, Jul 3 2017

Components: Blink>Infra>Ecosystem

Comment 22 by foolip@chromium.org, Jul 3 2017

Components: -Blink>Infra>Predictability
►

Sign in to add a comment