New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678072 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jul 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 669732



Sign in to add a comment

[Predator] Ignore blink reformat cls.

Project Member Reported by kateso...@chromium.org, Jan 3 2017

Issue description

[Predator] Ignore blink reformat cls.

Findit/Predator blame in Clusterfuzz is broken due to the large blink reformat cls, like: https://cluster-fuzz.appspot.com/v2/testcase-detail/5522703487598592

Should ignore this kind of cls.
 

Comment 1 by st...@chromium.org, Jan 3 2017

It seems straightforward to ignore those CLs from author "blink-reformat@chromium.org" or with title "Reformat blink.".
Yes, it's easy to just ignore them for now. And it would be great if we can automatically ignore this kind of cls in smart blame, and get the cls before the reformating cls.
Blocking: 669732
Owner: kateso...@chromium.org
Status: Fixed (was: Available)
Fixed by https://chromereviews.googleplex.com/560037013/

Comment 5 by thakis@chromium.org, Apr 25 2017

FWIW, https://cs.chromium.org/chromium/src/.git-blame-ignore-revs?q=.git-blame-i+package:%5Echromium$&l=1 lists "boring" CLs that should be ignored, so maybe you could use that list for findit too.

Comment 6 by st...@chromium.org, Apr 25 2017

Status: Assigned (was: Fixed)
Thanks Nico for the suggestion!
Reopen for Sharu to make the change in Predator.
Thanks for the link. This was actually planned, but I can't find a tracking bug for it. Might have been intended as part of issue 605762 but the scope of that is a bit larger, so I'm just going to reopen this.
Status: Fixed (was: Assigned)
fixed by this cl:
https://chromium-review.googlesource.com/c/541998/

Sign in to add a comment