New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 678070 link

Starred by 1 user
Status: Archived
Owner:
█ e...@chromium.org
Last visit > 30 days ago
Closed: Jan 2017
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 660994
issue 663618



Sign in to add a comment

Activation isn't wired correctly for aura-mus

Project Member Reported by sky@chromium.org, Jan 3 2017 
DesktopNativeWidgetAura adds itself as an ActivationChangeObserver for the content_window_. This is problematic with aura-mus as activation happens at the window associated with the WindowTreeHost, which is the parent of content_window_.

This causes WidgetTestInteractive.DisableViewDoesNotActivateWidget to fail because the widget is never told it loses activation so that state isn't stored correctly.

Comment 1 by e...@chromium.org, Jan 4 2017

Blocking: 663618
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4eff32a08d7a941ffb0eec7919b7de3361201551

commit 4eff32a08d7a941ffb0eec7919b7de3361201551
Author: erg <erg@chromium.org>
Date: Tue Jan 10 22:10:10 2017

view-mus: Fix DisableViewDoesNotActivateWidget by adding Show().

NWA was allowing invisible widgets to be activated, which
doesn't work in mus.

BUG= 678070 

Review-Url: https://codereview.chromium.org/2615743003
Cr-Commit-Position: refs/heads/master@{#442705}

[modify] https://crrev.com/4eff32a08d7a941ffb0eec7919b7de3361201551/ui/views/widget/widget_interactive_uitest.cc
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 13 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/02ba4e291b70651fe0813d70d24bea60fd64cfea

commit 02ba4e291b70651fe0813d70d24bea60fd64cfea
Author: erg <erg@chromium.org>
Date: Fri Jan 13 21:13:48 2017

aura-mus: Implement Deactivate() and fix Activation.

This adds a Deactivate() call for a window to request
deactivation in the window server, which passes that
request on to the window manager.

This also hooks up activation to focus changes caused
by the window server.

BUG= 663618 , 678070 

Review-Url: https://codereview.chromium.org/2568303006
Cr-Commit-Position: refs/heads/master@{#443668}

[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ash/mus/window_manager.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ash/mus/window_manager.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/mash/simple_wm/simple_wm.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/mash/simple_wm/simple_wm.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/demo/mus_demo.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/demo/mus_demo.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/public/cpp/tests/test_window_tree.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/public/cpp/tests/test_window_tree.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/public/cpp/window_tree_client.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/public/cpp/window_tree_client.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/public/interfaces/window_manager.mojom
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/public/interfaces/window_tree.mojom
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/test_wm/test_wm.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/ws/test_utils.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/ws/test_utils.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/ws/window_manager_client_unittest.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/ws/window_server_test_base.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/ws/window_server_test_base.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/ws/window_tree.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/ws/window_tree.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/services/ui/ws/window_tree_client_unittest.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/aura/mus/window_manager_delegate.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/aura/mus/window_tree_client.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/aura/mus/window_tree_client.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/aura/mus/window_tree_host_mus.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/aura/mus/window_tree_host_mus.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/aura/mus/window_tree_host_mus_delegate.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/aura/test/aura_test_base.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/aura/test/aura_test_base.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/aura/test/mus/test_window_tree.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/aura/test/mus/test_window_tree.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/views/mus/desktop_window_tree_host_mus.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/views/mus/desktop_window_tree_host_mus.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/views/mus/desktop_window_tree_host_mus_unittest.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/views/widget/desktop_aura/desktop_native_widget_aura.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/views/widget/desktop_aura/desktop_window_tree_host.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/views/widget/desktop_aura/desktop_window_tree_host_win.h
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.cc
[modify] https://crrev.com/02ba4e291b70651fe0813d70d24bea60fd64cfea/ui/views/widget/desktop_aura/desktop_window_tree_host_x11.h

Comment 4 by e...@chromium.org, Jan 13 2017

Owner: e...@chromium.org
Status: Fixed (was: Untriaged)
The second patch should fix activation when the window server changes focus now.

Comment 5 by dchan@google.com, Mar 4 2017

Labels: VerifyIn-58

Comment 6 by dchan@google.com, Apr 17 2017

Labels: VerifyIn-59

Comment 7 by dchan@google.com, May 30 2017

Labels: VerifyIn-60

Comment 8 by dchan@chromium.org, Aug 1 2017

Labels: VerifyIn-61

Comment 9 by dchan@chromium.org, Oct 14 2017

Status: Archived (was: Fixed)
►

Sign in to add a comment