New issue
Advanced search Search tips

Issue 678069 link

Starred by 1 user
Status: Fixed
Owner:
rtoy@chromium.org
Closed: Jan 2017
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

automatic-pull-node incorrectly tests results.

Project Member Reported by rtoy@chromium.org, Jan 3 2017 
automatic-pull-node.html does this:

  context.startRendering()
    .then(test1Finished(should))

where test1Finished is just a function (that doesn't return a function).  Hence the test is flaky because it depends on rendering to have started before test1Finished is called.

Fix this
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/26fdde80ab962b093cc9a45819ae86187261abe5

commit 26fdde80ab962b093cc9a45819ae86187261abe5
Author: rtoy <rtoy@chromium.org>
Date: Wed Jan 04 23:28:15 2017

Fix flaky automatic-pull-node test

This test is incorrect and flaky because it was depending on the
context being rendered before the test function was called.

BUG= 678069 
TEST=automatic-pull-node.html

Review-Url: https://codereview.chromium.org/2611823002
Cr-Commit-Position: refs/heads/master@{#441506}

[modify] https://crrev.com/26fdde80ab962b093cc9a45819ae86187261abe5/third_party/WebKit/LayoutTests/webaudio/Analyser/automatic-pull-node.html

Comment 2 by rtoy@chromium.org, Jan 10 2017

Status: Fixed (was: Started)
►

Sign in to add a comment