No in-omnibox active state for Views page info |
||||||
Issue descriptionMac Canary shows the gray "anchor" arrow for omnibox icons (lock/ev/etc), but Views doesn't. See https://groups.google.com/a/google.com/d/msg/chrome-ui-review/skVgN38u-gs/YrHUILG4EgAJ.
,
Jan 3 2017
The move away from the arrow is deliberate (part of Harmony). But the gray active state is what's missing for Page Info.
,
Jan 6 2017
Since there are a lot of moving parts in the relevant surfaces, this bug is too vague for me to triage right now. emilyschecher@, could you describe exactly what the bug is (repro steps) and attach screenshots?
,
Jan 6 2017
+bettes@ and maxwalker@: correct me if i'm wrong in the following. I think this is a Mac bug, not Views platform bug. We're keeping the arrow until Harmony launches, correct? Then, with the arrow, the active state (gray background) is not necessary yet. The gray bg is going to replace the arrow in Harmony. Until then, the gray bg should not show. With that, the title of this bug should be "Do not show gray bg for page info on OSX" and OS should be corrected to "Mac".
,
Jan 6 2017
,
Jan 6 2017
No, I think this is referring to the fact that Views does not persist the "clicked" dark-grey hover state when PageInfo is expanded.
,
Jan 6 2017
+bettes, could you confirm we're gonna have both "clicked" dark-grey state AND arrow for the time being until Harmony lands?
,
Jan 19 2017
,
Feb 7 2017
Still not clear what the bug here is :) Could someone please add screenshots of existing and desired states so that we can triage and assign the bug properly? Thanks!
,
Feb 8 2017
Got clarification from bettes. c6 is correct (both graybg and triangle on active state) and c4 is incorrect. I'll add screenshots once I get to a views device tomorrow.
,
Feb 8 2017
Bug: gray highlight missing on hover and active on Views platforms (Win, CrOS, Linux) Desired: gray highlight on hover and active on Views platforms (OSX implementation is correct) Note: The triangle should be removed later with Harmony.
,
Feb 8 2017
hwi: Thanks! I don't know who the best person to work on this is. lgarron?
,
Feb 10 2017
spqchan, can you take this please?
,
Feb 10 2017
Good timing, I was about to file a bug about this :)
,
Feb 10 2017
How is this different than bug 588377 ?
,
Feb 24 2017
Ah right, let me dupe this. Thanks for pointing that out! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by ainslie@chromium.org
, Jan 3 2017