New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678063 link

Starred by 2 users

Issue metadata

Status: Duplicate
Merged: issue 588377
Owner:
Last visit > 30 days ago
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 2
Type: Bug



Sign in to add a comment

No in-omnibox active state for Views page info

Project Member Reported by emilyschechter@chromium.org, Jan 3 2017

Issue description

Mac Canary shows the gray "anchor" arrow for omnibox icons (lock/ev/etc), but Views doesn't.

See https://groups.google.com/a/google.com/d/msg/chrome-ui-review/skVgN38u-gs/YrHUILG4EgAJ.
 
Cc: maxwalker@chromium.org
Summary: No in-omnibox active state for Views page info (was: No "arrow" for Views omnibox dialogs)
The move away from the arrow is deliberate (part of Harmony). 
But the gray active state is what's missing for Page Info.
Since there are a lot of moving parts in the relevant surfaces, this bug is too vague for me to triage right now.
emilyschecher@, could you describe exactly what the bug is (repro steps) and attach screenshots?

Comment 4 by hwi@chromium.org, Jan 6 2017

+bettes@ and maxwalker@: correct me if i'm wrong in the following. 

I think this is a Mac bug, not Views platform bug. 

We're keeping the arrow until Harmony launches, correct?
Then, with the arrow, the active state (gray background) is not necessary yet. 
The gray bg is going to replace the arrow in Harmony. Until then, the gray bg should not show.

With that, the title of this bug should be "Do not show gray bg for page info on OSX" and OS should be corrected to "Mac". 



Comment 5 by hwi@chromium.org, Jan 6 2017

Cc: bettes@chromium.org
No, I think this is referring to the fact that Views does not persist the "clicked" dark-grey hover state when PageInfo is expanded.

Comment 7 by hwi@chromium.org, Jan 6 2017

+bettes, could you confirm we're gonna have both "clicked" dark-grey state AND arrow for the time being until Harmony lands?

Comment 8 by ketakid@google.com, Jan 19 2017

Labels: omnibox
Still not clear what the bug here is :) Could someone please add screenshots of existing and desired states so that we can triage and assign the bug properly? Thanks!

Comment 10 by hwi@chromium.org, Feb 8 2017

Got clarification from bettes. c6 is correct (both graybg and triangle on active state) and c4 is incorrect. 

I'll add screenshots once I get to a views device tomorrow. 

Comment 11 by hwi@chromium.org, Feb 8 2017

Bug:
gray highlight missing on hover and active on Views platforms (Win, CrOS, Linux)

Desired:
gray highlight on hover and active on Views platforms (OSX implementation is correct)

Note:
The triangle should be removed later with Harmony. 
678063.png
88.2 KB View Download
hwi: Thanks! I don't know who the best person to work on this is. lgarron?
Components: -UI>Browser>Bubbles>PageInfo UI>Browser>Omnibox>SecurityIndicators
Labels: -Pri-3 -omnibox Team-Security-UX M-58 Pri-2
Owner: spqc...@chromium.org
Status: Assigned (was: Untriaged)
spqchan, can you take this please?
Good timing, I was about to file a bug about this :)
How is this different than  bug 588377 ?
Mergedinto: 588377
Status: Duplicate (was: Assigned)
Ah right, let me dupe this. Thanks for pointing that out!

Sign in to add a comment