Add Compressed page size to the DRP pingback |
|||||
Issue descriptionAdd compressed page size data to the DRP pingback. This is included in the proto already, but is not filled in.
,
Jan 17 2017
Comment 1 reflects an end goal, but for now, the PLM approach should be sufficient.
,
Jan 18 2017
Just to update, M-57 gets branched tomorrow and would probably go to Beta during 1st week of Feb. Please prioritize and update the blocker and milestone accordingly.
,
Jan 18 2017
If I don't land this for the branch this week, ideally we'd merge it in soon after (before the first week in February). The change will be small and well scoped.
,
Jan 23 2017
Is this change applicable to any specific OS or All OSs?
,
Jan 25 2017
A friendly reminder that M57 Beta launch is coming soon on February 2nd (in a week)! Your bug is labelled as Beta ReleaseBlock, pls make sure to land the fix and get it merged into the release branch (2987) ASAP so it gets enough baking time in Dev (before Beta promotion). Thank you!
,
Jan 25 2017
,
Jan 25 2017
Removing Release-BlockBeta as this is not Beta blocking. This has relatively low impact, but still might be merged once it lands.
,
Jan 26 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c19a210cab019968afc9e2a93f6c738030574d49 commit c19a210cab019968afc9e2a93f6c738030574d49 Author: ryansturm <ryansturm@chromium.org> Date: Thu Jan 26 00:16:24 2017 Adding compressed bytes to DRP pingback Compressed bytes represents the network bytes used for the page load. This is accessible through page load metrics observer interface now. BUG= 678061 Review-Url: https://codereview.chromium.org/2615493002 Cr-Commit-Position: refs/heads/master@{#446169} [modify] https://crrev.com/c19a210cab019968afc9e2a93f6c738030574d49/chrome/browser/page_load_metrics/observers/data_reduction_proxy_metrics_observer.cc [modify] https://crrev.com/c19a210cab019968afc9e2a93f6c738030574d49/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client.cc [modify] https://crrev.com/c19a210cab019968afc9e2a93f6c738030574d49/components/data_reduction_proxy/core/browser/data_reduction_proxy_pingback_client_unittest.cc [modify] https://crrev.com/c19a210cab019968afc9e2a93f6c738030574d49/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.cc [modify] https://crrev.com/c19a210cab019968afc9e2a93f6c738030574d49/components/data_reduction_proxy/core/common/data_reduction_proxy_page_load_timing.h [modify] https://crrev.com/c19a210cab019968afc9e2a93f6c738030574d49/components/data_reduction_proxy/proto/pageload_metrics.proto
,
Jan 26 2017
Not merging this back; the UMA with this data isn't as promising as I like, so I will be taking a look at changing the underlying implementation in M58 to get better results. |
|||||
►
Sign in to add a comment |
|||||
Comment 1 by ryansturm@chromium.org
, Jan 3 2017