New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678052 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: All
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Bots don't recompile again to make sure rebuilds aren't needed

Project Member Reported by jam@chromium.org, Jan 3 2017

Issue description

If I build content.dll and then try again, instead of not doing any work it keeps trying to build some angle/vulkan code.

[0/19] ACTION //third_party/angle/src/vulkan_support:vulkan_gen_struct_wrappers(//build/toolchain/win:x86)
[10/19] STAMP obj/third_party/angle/src/vulkan_support/vulkan_layer_table.inputdeps.stamp
and so on

This is a debug Windows build with GN.

Ken: can you please triage? I'd assign this to Antoine but he's gone.
 
The bots build a second time after a build, so they should in theory catch this. I wanted to send you a link, but https://build.chromium.org/p/chromium/builders/Win has been not loading for 30s now.

What's the output of `ninja -d explain -C out/gn content`?

Comment 2 by jam@chromium.org, Jan 3 2017

D:\src\chrome3\src>ninja -d explain -C out\Debug content
ninja: Entering directory `out\Debug'
ninja explain: output gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_string_helper_no_addr.h doesn't exist
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_safe_struct.cpp is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_safe_struct.h is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_size_helper.h is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_string_helper_cpp.h is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_safe_struct.cpp is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_safe_struct.h is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_size_helper.c is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_size_helper.h is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_string_helper.h is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_string_helper_cpp.h is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_string_helper_no_addr.h is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_string_helper_no_addr_cpp.h is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_validate_helper.h is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_wrappers.cpp is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_wrappers.h is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/vulkan_gen_struct_wrappers.stamp is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/VkLayer_core_validation/core_validation.obj is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_safe_struct.h is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/VkLayer_core_validation/descriptor_sets.obj is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/vulkan_gen_struct_wrappers.stamp is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_string_helper_cpp.h is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/vulkan_gen_struct_wrappers.stamp is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/VkLayer_image/image.obj is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/vulkan_gen_struct_wrappers.stamp is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/vulkan_gen_struct_wrappers.stamp is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_safe_struct.cpp is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_safe_struct.h is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_string_helper_cpp.h is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/vulkan_gen_struct_wrappers.stamp is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/VkLayer_threading/unique_objects.obj is dirty
ninja explain: gen/third_party/angle/src/vulkan_support/angle/vulkan/vk_struct_string_helper_cpp.h is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/vulkan_gen_struct_wrappers.stamp is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/VkLayer_unique_objects/threading.obj is dirty
ninja explain: obj/third_party/angle/src/vulkan_support/vulkan_gen_struct_wrappers.stamp is dirty
[19/19] LINK(DLL) VkLayer_core_validation.dll VkLayer_core_validation.dll.lib VkLayer_core_validation.dll.pdb

Comment 3 by jam@chromium.org, Jan 3 2017

Cc: dpranke@chromium.org

Comment 4 by kbr@chromium.org, Jan 3 2017

Cc: kbr@chromium.org
Components: Internals>GPU>ANGLE
Owner: jmad...@chromium.org

Comment 5 by kbr@chromium.org, Jan 3 2017

Assigning to Jamie who's working on Vulkan support in ANGLE.

Jamie, it sounds like there's a bug in the dependencies in this area.

Cc: tikuta@chromium.org
It looks like https://chromium-review.googlesource.com/c/421239/5/scripts/slave/recipe_modules/chromium/api.py deleted the build noop checking. If I understand that right, this is a serious regression. (In that case, tikuta, this needs to be reverted)
Status: Fixed (was: Assigned)
Sorry about this, it's already fixed. Needs an ANGLE roll.

Comment 8 by jam@chromium.org, Jan 3 2017

Owner: tikuta@chromium.org
Status: Assigned (was: Fixed)
Summary: Bots don't recompile again to make sure rebuilds aren't needed (was: Vulkan code is always rebuilding)
Thanks Jamie, we still need the recipe revert though to make sure regressions like this don't creep again.

Comment 9 by jam@chromium.org, Jan 3 2017

Labels: -OS-Windows -Type-Bug OS-All Type-Bug-Regression

Comment 10 by kbr@chromium.org, Jan 3 2017

Jamie, could you point to the commit or ANGLE bug in which this was fixed? Thanks.

Fixed in https://chromium-review.googlesource.com/#/c/424592/, rolled into Chrome in https://codereview.chromium.org/2609943003/. Sorry, had fixed this before this issue was opened.
Owner: jam@chromium.org
Sorry, I do not understand the context of this issue.

Change of chromium/api.py is only removing deadcode.
Reverting the CL should not change buildbot behavior.
And I'm not sure which part was handling such situation.
https://chromium-review.googlesource.com/c/421239/5/scripts/slave/recipe_modules/chromium/api.py

Is this the issue actually related to above CL?
Owner: tikuta@chromium.org
@tikuta - 

The issue is that you are supposed to be able to run `ninja chrome && ninja chrome` and be sure that the second invocation has no work to do (which indicates that we got the dependencies right). The angle change didn't get the dependencies right, so that broke.

However, thakis@ is pointing out in comment #6 that one of the things we did in compile.py was to have an --ensure-up-to-date flag that would issue the second ninja invocation automatically and fail the compile if there was still work to do.

In https://chromium-review.googlesource.com/c/421239/5/scripts/slave/recipe_modules/chromium/api.py#b250 , you removed that line. 

We need to add that functionality back in.

Does that make sense?
Components: Infra>Goma
Status: Started (was: Assigned)
Thank you for your explanation, Dirk.

I got. Let me fix this in goma module.

Comment 17 by ajuma@chromium.org, Jan 20 2017

P1 bug ping, is the CL from #16 just blocked on review or is there more to do here?
Project Member

Comment 18 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/tools/build.git/+/f305cbc5994c4d16004944dd3f10b335e8ef6ea9

commit f305cbc5994c4d16004944dd3f10b335e8ef6ea9
Author: Takuto Ikuta <tikuta@google.com>
Date: Mon Jan 23 02:36:01 2017

Support ninja_confirm_noop in chromium module

Changed python files
* scripts/slave/recipe_modules/chromium/api.py
* scripts/slave/recipe_modules/goma/api.py

BUG= 678052 

Change-Id: Ibaa5c697efbabd6c6dd0e13381d5cc2ae78e0cf0
Reviewed-on: https://chromium-review.googlesource.com/425233
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Fumitoshi Ukai <ukai@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@google.com>

[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipe_modules/chromium/api.py
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipe_modules/goma/api.py
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipe_modules/syzygy/example.expected/full_master_client_syzygy_Syzygy_Coverage.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipe_modules/syzygy/example.expected/full_master_client_syzygy_Syzygy_Debug.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipe_modules/syzygy/example.expected/full_master_client_syzygy_Syzygy_Official.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/build_dynamic_isolated_script_test_compile_target_overriden.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/build_dynamic_swarmed_isolated_script_test_compile_target_overidden.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/chromium_webkit_crash.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_chromium.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/chromium_webkit_revision_webkit.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/chromium_webkit_warnings.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/dynamic_gtest_on_builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/dynamic_swarmed_gtest_override_compile_targets.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/ensure_goma_fail.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_Linux_x64.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_Mac.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_Win.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_Win_x64.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_amd64_generic_Compile.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_daisy_Compile.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_ChromiumOS_x86_generic_Compile.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Full.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_chromiumos_Linux_ChromiumOS_Ozone_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_ARM.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Linux_remote_run_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_fyi_Site_Isolation_Linux.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux___RandomOrder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux___TraceWrappables.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux___WPTServe.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Linux_slimming_paint_v2_Dummy_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Mac___RandomOrder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Mac___WPTServe.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Win___RandomOrder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_fyi_WebKit_Win___WPTServe.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Linux_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Linux_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Mac_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Mac_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Win_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_GPU_Win_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Fake_Linux_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Linux_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Mac_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_Clang_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_x64_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_GPU_Win_x64_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_ChromiumOS_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Linux_ChromiumOS_Ozone_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_gpu_fyi_Mac_GPU_ASAN_Release.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_linux_Cast_Linux.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_linux_Cast_Linux_Trusty.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder_Trusty.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder_Trusty__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder_Trusty__dbg__32_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_linux_Linux_Builder__dbg__32_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_mac_Mac_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_webkit_WebKit_Linux_Trusty.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_chromium_win_Win_x64_Builder__dbg_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_client_skia_Linux_Builder_Trybot.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_client_skia_Mac_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_client_skia_Mac_Builder_Trybot.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_client_skia_Win_Builder_Trybot.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Linux_Debug_Builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Linux_Release__NVIDIA_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Mac_Release__Intel_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_client_v8_fyi_V8_Linux_GN.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/full_client_v8_fyi_Win_Release__NVIDIA_.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium.expected/kitchen_path_config.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/analyze_webkit.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/blink_compile_without_patch_fails.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/blink_minimal_pass_continues.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/clobber_analyze.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_matching_exclusion.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_compile_targets_exclude_all.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/compile_because_of_analyze_with_filtered_tests_no_builder.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/compile_failure_infra.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/compile_failure_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/compile_failure_with_component_rev.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/compile_failure_without_patch_deapply_fn.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/dont_analyze_for_non_src_project.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/dont_deapply_patch.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/dynamic_isolated_script_test_with_args_on_trybot.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_luci_chromium_try_LUCI_linux_chromium_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_trusty_blink_compile_rel.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_blink_linux_trusty_blink_rel.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_angle_linux_angle_chromeos_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_cast_shell_linux.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_cast_shell_linux_trusty.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromeos_amd64_generic_chromium_compile_only_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromeos_daisy_chromium_compile_only_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_chromeos_x86_generic_chromium_compile_only_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_dbg_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_compile_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_dbg_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_ozone_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_chromeos_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_dbg_32_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_trusty_dbg_32_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_compile_trusty_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_dbg_32_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty_dbg_32_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_chromium_trusty_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_layout_tests_slimming_paint_v2.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_linux_linux_site_isolation.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_10_10_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_archive_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_dbg_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_compile_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_dbg_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_mac_mac_chromium_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win10_chromium_x64_rel_ng_exp.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_archive.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_dbg_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_compile_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_dbg_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_chromium_x64_rel_ng.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_chromium_win_win_x64_archive.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_v8_v8_linux_blink_rel.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/full_tryserver_v8_v8_linux_chromium_gn_rel.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/invalid_results.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/process_dumps_failure.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/recipe_config_changes_not_retried_without_patch.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_cq.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/swarming_basic_try_job.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/swarming_missing_isolated.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/swarming_test_failure.json
[modify] https://crrev.com/f305cbc5994c4d16004944dd3f10b335e8ef6ea9/scripts/slave/recipes/chromium_trybot.expected/swarming_test_with_priority_expiration_and_timeout.json
[modify] https://crrev.com/f305cbc599
Status: Fixed (was: Started)
Looks working correctly.

Sign in to add a comment