Swarming UI confusing for expired tasks that are disabled |
||||
Issue descriptionSee build https://luci-milo.appspot.com/buildbot/chromium.perf/Win%2010%20High-DPI%20Perf/153 https://chromium-swarm.appspot.com/task?id=337c567e60cdc010&refresh=10&show_raw=1 was triggered, which is running v8 mobile tests. As far as I can tell, the corresponding test is https://cs.chromium.org/chromium/src/tools/perf/benchmarks/v8_browsing.py?l=101. It looks like it shouldn't be running, but it is??
,
Jan 3 2017
They are triggered, but not run. Looks for "DISABLED_BENCHMARK" text in https://build.chromium.org/p/chromium.perf/builders/Win%2010%20High-DPI%20Perf/builds/153
,
Jan 3 2017
Maybe someone can change the buildbot UI so that the color is grey if the test is skipped?
,
Jan 3 2017
What I see is actually DISABLED_BENCHMARK+green for v8.browsing_mobile but no disabled text+red for v8.browsing_mobile_ignition. See screenshot.
,
Jan 3 2017
This seems like a swarming infra issue. The sharding link for that test shows the test was EXPIRED: https://chromium-swarm.appspot.com/task?id=337c567e60cdc010&refresh=10&show_raw=1
,
Jan 3 2017
Wow, this is super confusing UI. Updating bug title and assigning back to Stephen since he's been working on buildbot status page UX for swarming.
,
Jan 3 2017
Yeah, this is a semi known issue. I'll look at it again, to see if I can figure out what's happening.
,
Jan 3 2017
Ok, I think I found something. The json we're getting from `swarming.py collect` is in a different format than what the swarming recipe module expects. CL should be out and landed soon...
,
Jan 4 2017
I am slightly confused. This task expired so was never run. For the recipe to know that a benchmark is disabled the task has to at least be scheduled and run and the returned json from telemetry tells us it is in fact successful, but successful because it was disabled. Therefore, I think the issue here is that this should actually be purple, expired swarming task, and I believe maruel@ had a CL out for this but had to revert. Other than that, we didn't get to the point where we knew it was disabled.
,
Jan 4 2017
There is a CL which maruel landed which is supposed to turn it purple. There's a bug in it, so it doesn't. At least as far as I can tell.
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/3f0f31bf7787eb399ee0c091278093a31c596686 commit 3f0f31bf7787eb399ee0c091278093a31c596686 Author: Stephen Martinis <martiniss@google.com> Date: Wed Jan 04 00:51:43 2017 swarming: Add new state enum workaround Swarming changed from using integers to strings, to represent the state of a bot. The current swarming recipe module still uses integers. This behavior should be changed. This CL is a temporary hack to unblock the speed infra team, since the broken behavior now is really confusing for infra breakages on the chromium.perf waterfall. BUG= 678049 Change-Id: Ifb335973a623b834b4788657a7d699b6e1065614 Reviewed-on: https://chromium-review.googlesource.com/424734 Reviewed-by: Vadim Shtayura <vadimsh@chromium.org> Commit-Queue: Stephen Martinis <martiniss@chromium.org> [modify] https://crrev.com/3f0f31bf7787eb399ee0c091278093a31c596686/scripts/slave/recipe_modules/swarming/api.py
,
Jan 4 2017
So hopefully the chromium.perf waterfall will now turn purple when jobs expire. I'll mark this as fixed and confirm tomorrow. |
||||
►
Sign in to add a comment |
||||
Comment 1 by sullivan@chromium.org
, Jan 3 2017Components: Tests>Telemetry