LogDog uses the wrong host name when generating viewer URLs. |
||
Issue descriptionLogDog is currently given a single value - the Coordinator host. For production, this value targets the services module using "services-dot-luci-logdog.appspot.com", since it's a better endpoint for services. However, this means that viewer URL generation also targets that endpoint, which results in an invalid viewer URL. Pass the Coordinator host separately from the output host. The former will be forwarded to applications to represent the Coordinator service itself, while the latter will be used for specifically Butler output. One CL for this has already landed: https://github.com/luci/luci-go/commit/645b0830d90861a407b450f08c5ed81e850cad37
,
Jan 3 2017
Should be fixed in new builds, now.
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/603490c636b1da5e2425388c0a41476e6bcf5e57 commit 603490c636b1da5e2425388c0a41476e6bcf5e57 Author: Daniel Jacques <dnj@chromium.org> Date: Wed Jan 04 23:12:31 2017 Revert "Bump LogDog Stable, remove API v1." This reverts commit 7a02e109f530c978854ea364649a286866612462. Reason for revert: Stripping more than it intended to (STEP_LOG_LINE). Original change's description: > Bump LogDog Stable, remove API v1. > > BUG= chromium:678045 , chromium:676409 > TEST=None > > Change-Id: Ia18403d32ad1446707f3457501567941ce338746 > Reviewed-on: https://chromium-review.googlesource.com/424131 > Reviewed-by: Erik Staab <estaab@chromium.org> > Commit-Queue: Daniel Jacques <dnj@chromium.org> > TBR=agable@chromium.org,dnj@chromium.org,estaab@chromium.org,chromium-reviews@chromium.org BUG= chromium:678045 , chromium:676409 NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Change-Id: Ia9f907df374f0dddfd8ee6b0566851a05d215004 Reviewed-on: https://chromium-review.googlesource.com/424864 Commit-Queue: Daniel Jacques <dnj@chromium.org> Reviewed-by: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/603490c636b1da5e2425388c0a41476e6bcf5e57/scripts/slave/logdog_bootstrap.py [modify] https://crrev.com/603490c636b1da5e2425388c0a41476e6bcf5e57/scripts/slave/unittests/logdog_bootstrap_test.py
,
Jan 5 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/tools/build.git/+/e21073d2085429d606223172b886a6991b78441b commit e21073d2085429d606223172b886a6991b78441b Author: Dan Jacques <dnj@chromium.org> Date: Thu Jan 05 03:19:32 2017 Re-land "Bump LogDog Stable, remove API v1." This reverts commit 603490c636b1da5e2425388c0a41476e6bcf5e57, which reverted commit 7a02e109f530c978854ea364649a286866612462. The commit was reverted due to a bug in LogDog/Annotee which stripped STEP_LOG_LINES even when tee'ing text. This bug was fixed in: https://github.com/luci/luci-go/commit/3b9b350e96778cdf0bd6381a2b3c23503faed52d The canary has passed a round of builds successfully on Infra waterfall, so let's bump it to stable again. BUG= chromium:678045 , chromium:676409 ,chromium:678412 TEST=canary - Successfully canaried a round of builds on "chromium.infra". Change-Id: I7e7734c3f3415755335bfe8959ee0df5030d162f Reviewed-on: https://chromium-review.googlesource.com/425001 Reviewed-by: Erik Staab <estaab@chromium.org> Commit-Queue: Daniel Jacques <dnj@chromium.org> [modify] https://crrev.com/e21073d2085429d606223172b886a6991b78441b/scripts/slave/logdog_bootstrap.py [modify] https://crrev.com/e21073d2085429d606223172b886a6991b78441b/scripts/slave/unittests/logdog_bootstrap_test.py |
||
►
Sign in to add a comment |
||
Comment 1 by bugdroid1@chromium.org
, Jan 3 2017