New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678034 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Jan 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Small visual tweaks needed for palette tray

Project Member Reported by jdufault@chromium.org, Jan 3 2017

Issue description

Small visual tweaks needed for palette tray
 
Blockedon: 676835
Also see issue 676835.
Blockedon: -676835
Project Member

Comment 5 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c808c7c92eb71b4d529bf00b3a65a012e2962c99

commit c808c7c92eb71b4d529bf00b3a65a012e2962c99
Author: dcheng <dcheng@chromium.org>
Date: Fri Jan 06 03:05:45 2017

Revert of cros: Small visual tweaks for material design palette. (patchset #2 id:20001 of https://codereview.chromium.org/2608343002/ )

Reason for revert:
Fails to build on Linux ChromiumOS Builder (dbg) since SkColorSetARGB is not a constexpr function

Original issue's description:
> cros: Small visual tweaks for material design palette.
>
> BUG= 678034 
>
> Review-Url: https://codereview.chromium.org/2608343002
> Cr-Commit-Position: refs/heads/master@{#441800}
> Committed: https://chromium.googlesource.com/chromium/src/+/9abb5f3f351b0d3831f79da9980a00db4d7d4815

TBR=stevenjb@chromium.org,jdufault@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 678034 

Review-Url: https://codereview.chromium.org/2614063005
Cr-Commit-Position: refs/heads/master@{#441858}

[modify] https://crrev.com/c808c7c92eb71b4d529bf00b3a65a012e2962c99/ash/common/system/chromeos/palette/common_palette_tool.cc
[modify] https://crrev.com/c808c7c92eb71b4d529bf00b3a65a012e2962c99/ash/common/system/chromeos/palette/palette_tray.cc

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 6 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11072c1640f0f7c4b141f7425b26d014ad52d74a

commit 11072c1640f0f7c4b141f7425b26d014ad52d74a
Author: jdufault <jdufault@chromium.org>
Date: Fri Jan 06 21:28:34 2017

Reland cros: Small visual tweaks for material design palette.

Original patch got reverted due to compile error.

BUG= 678034 

Review-Url: https://codereview.chromium.org/2615263002
Cr-Commit-Position: refs/heads/master@{#442056}

[modify] https://crrev.com/11072c1640f0f7c4b141f7425b26d014ad52d74a/ash/common/system/chromeos/palette/common_palette_tool.cc
[modify] https://crrev.com/11072c1640f0f7c4b141f7425b26d014ad52d74a/ash/common/system/chromeos/palette/palette_tray.cc

Issue 674793 has been merged into this issue.
Cc: tbuck...@chromium.org bruthig@chromium.org
Labels: Proj-MaterialDesign-CrOS
Jacob, I see this is targeted for m-56. Did you plan to have this merged back?
Labels: Merge-Request-56
Yes, that's probably a good idea. I'll file a merge request.
Status: Started (was: Assigned)
Project Member

Comment 11 by sheriffbot@chromium.org, Jan 11 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: Reverts referenced in bugdroid comments after merge request.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: OS-Chrome
Looks like OS-Chrome, release teams use OS tags to review merges, please ensure you apply one in the future.
Labels: Merge-Request-56
Ping for merge request into m-56.
Project Member

Comment 14 by sheriffbot@chromium.org, Jan 17 2017

Labels: -Merge-Request-56
This bug requires manual review: We are only 13 days from stable.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: Merge-Approved-56
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 23 2017

Labels: -merge-approved-56 merge-merged-2924
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4bab87acaab81dd97e0db1e61410d96c216f5001

commit 4bab87acaab81dd97e0db1e61410d96c216f5001
Author: Jacob Dufault <jdufault@google.com>
Date: Mon Jan 23 21:41:46 2017

Reland cros: Small visual tweaks for material design palette.

Original patch got reverted due to compile error.

BUG= 678034 

Review-Url: https://codereview.chromium.org/2615263002
Cr-Commit-Position: refs/heads/master@{#442056}
(cherry picked from commit 11072c1640f0f7c4b141f7425b26d014ad52d74a)

Review-Url: https://codereview.chromium.org/2655483003 .
Cr-Commit-Position: refs/branch-heads/2924@{#846}
Cr-Branched-From: 3a87aecc31cd1ffe751dd72c04e5a96a1fc8108a-refs/heads/master@{#433059}

[modify] https://crrev.com/4bab87acaab81dd97e0db1e61410d96c216f5001/ash/common/system/chromeos/palette/common_palette_tool.cc
[modify] https://crrev.com/4bab87acaab81dd97e0db1e61410d96c216f5001/ash/common/system/chromeos/palette/palette_tray.cc

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment