Issue 678023 link

Starred by 3 users

Issue metadata

Status:	Fixed
Owner:	█ gog...@gmail.com Last visit > 30 days ago
Closed:	Mar 2017
Components:	Blink>DOM
EstimatedDays:	----
NextAction:	----
OS:	----
Pri:	2
Type:	Bug
Needs-Milestone

Blocking:
issue 388780

The DOMRect/DOMRectReadOnly implementation are different with spec.

Reported by gog...@gmail.com, Jan 3 2017

Issue description

The DOMRect/DOMRectReadOnly implementation are different with spec. 
They should match up with the spec.
- The DOMRectReadOnly constructor shoud have default value.
- The DOMRectReadOnly interface requires serializer.
- The two interfaces require fromRect function.
- Old test should be rewritten using the testharness.js testing framework
- Add DOMRect dictionary

Related spec links:
- https://drafts.fxtf.org/geometry/#domrect
- https://drafts.fxtf.org/geometry/#domrectreadonly

Comment 1 by gog...@gmail.com, Jan 3 2017

I'll start to work on this issue.

Comment 2 by ajha@chromium.org, Jan 4 2017

Labels: Needs-Milestone

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b4ef1f0666d5ab777050caf256bfd1ec7ceb67aa

commit b4ef1f0666d5ab777050caf256bfd1ec7ceb67aa
Author: gogag2 <gogag2@gmail.com>
Date: Wed Jan 04 17:53:57 2017

Rewrite the layout test for DOMRect interface.

For historical reasons, older tests are written using the js-test harness.
This harness is deprecated, and should not be used for new tests. So, rewrite
The layout test as following new tests guide[1].

[1] https://chromium.googlesource.com/chromium/src/+/master/docs/testing/writing_layout_tests.md#The-js_test_js-Legacy-Harness

BUG= 678023 

Review-Url: https://codereview.chromium.org/2611713002
Cr-Commit-Position: refs/heads/master@{#441405}

[delete] https://crrev.com/b81742a8fd075e6cd228f4bf742744253aea769a/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect-expected.txt
[modify] https://crrev.com/b4ef1f0666d5ab777050caf256bfd1ec7ceb67aa/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html
[modify] https://crrev.com/b4ef1f0666d5ab777050caf256bfd1ec7ceb67aa/third_party/WebKit/LayoutTests/fast/dom/resources/geometry-interfaces-test-helpers.js

Comment 4 by dtapu...@chromium.org, Jan 4 2017

Components: Blink>DOM

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c883c90a96a245e289a850f2fd98584ff6098f92

commit c883c90a96a245e289a850f2fd98584ff6098f92
Author: gogag2 <gogag2@gmail.com>
Date: Sat Jan 07 11:54:21 2017

The DOMRectReadOnly implementation are different with spec.

The DOMRectReadOnly implementation are different with spec.
They should match up with the spec[1].
The DOMRectReadOnly constructor should have default value.

[1]https://drafts.fxtf.org/geometry/#dom-domrectreadonly-domrectreadonly

BUG= 678023 

Review-Url: https://codereview.chromium.org/2603393002
Cr-Commit-Position: refs/heads/master@{#442163}

[modify] https://crrev.com/c883c90a96a245e289a850f2fd98584ff6098f92/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html
[modify] https://crrev.com/c883c90a96a245e289a850f2fd98584ff6098f92/third_party/WebKit/Source/core/dom/DOMRectReadOnly.idl

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 7 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1973750ff59aedf91e56ac03754673d22f8f11de

commit 1973750ff59aedf91e56ac03754673d22f8f11de
Author: gogag2 <gogag2@gmail.com>
Date: Sat Jan 07 13:16:57 2017

The DOMRectReadOnly interface requires serializer.

The DOMRectReadOnly interface requires serializer.
The DOMRectReadOnly implementation is different with spec.
It should match up with the spec[1].

[1] https://drafts.fxtf.org/geometry/#domrectreadonly

BUG= 678023 

Review-Url: https://codereview.chromium.org/2611703002
Cr-Commit-Position: refs/heads/master@{#442164}

[modify] https://crrev.com/1973750ff59aedf91e56ac03754673d22f8f11de/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html
[modify] https://crrev.com/1973750ff59aedf91e56ac03754673d22f8f11de/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/1973750ff59aedf91e56ac03754673d22f8f11de/third_party/WebKit/Source/core/dom/DOMRectReadOnly.cpp
[modify] https://crrev.com/1973750ff59aedf91e56ac03754673d22f8f11de/third_party/WebKit/Source/core/dom/DOMRectReadOnly.h
[modify] https://crrev.com/1973750ff59aedf91e56ac03754673d22f8f11de/third_party/WebKit/Source/core/dom/DOMRectReadOnly.idl

Comment 7 by jinho.b...@samsung.com, Jan 13 2017

Blocking: 388780
Labels: -Pri-3 Pri-2
Owner: gog...@gmail.com
Status: Started (was: Unconfirmed)

Project Member

Comment 8 by bugdroid1@chromium.org, Jan 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5be3a2ab80dff22d41a0a5e99a586272208dac37

commit 5be3a2ab80dff22d41a0a5e99a586272208dac37
Author: gogag2 <gogag2@gmail.com>
Date: Mon Jan 16 12:48:57 2017

Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.

Adding fromRect to DOMRect and DOMRectReadOnly interfaces following spec.
The two interfaces require fromRect function as following spec[1].
And DOMRectInit is added[2].

[1] https://drafts.fxtf.org/geometry/#dom-domrectreadonly-fromrect
[2] https://drafts.fxtf.org/geometry/#dictdef-domrectinit

BUG= 678023 

Review-Url: https://codereview.chromium.org/2612263002
Cr-Commit-Position: refs/heads/master@{#443878}

[modify] https://crrev.com/5be3a2ab80dff22d41a0a5e99a586272208dac37/third_party/WebKit/LayoutTests/fast/dom/geometry-interfaces-dom-rect.html
[modify] https://crrev.com/5be3a2ab80dff22d41a0a5e99a586272208dac37/third_party/WebKit/LayoutTests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/5be3a2ab80dff22d41a0a5e99a586272208dac37/third_party/WebKit/Source/bindings/core/v8/BUILD.gn
[modify] https://crrev.com/5be3a2ab80dff22d41a0a5e99a586272208dac37/third_party/WebKit/Source/core/core_idl_files.gni
[modify] https://crrev.com/5be3a2ab80dff22d41a0a5e99a586272208dac37/third_party/WebKit/Source/core/dom/DOMRect.cpp
[modify] https://crrev.com/5be3a2ab80dff22d41a0a5e99a586272208dac37/third_party/WebKit/Source/core/dom/DOMRect.h
[modify] https://crrev.com/5be3a2ab80dff22d41a0a5e99a586272208dac37/third_party/WebKit/Source/core/dom/DOMRect.idl
[add] https://crrev.com/5be3a2ab80dff22d41a0a5e99a586272208dac37/third_party/WebKit/Source/core/dom/DOMRectInit.idl
[modify] https://crrev.com/5be3a2ab80dff22d41a0a5e99a586272208dac37/third_party/WebKit/Source/core/dom/DOMRectReadOnly.cpp
[modify] https://crrev.com/5be3a2ab80dff22d41a0a5e99a586272208dac37/third_party/WebKit/Source/core/dom/DOMRectReadOnly.h
[modify] https://crrev.com/5be3a2ab80dff22d41a0a5e99a586272208dac37/third_party/WebKit/Source/core/dom/DOMRectReadOnly.idl

Comment 9 by jinho.b...@samsung.com, Mar 9 2017

Status: Fixed (was: Started)

►

Issue 678023 link

Issue metadata

The DOMRect/DOMRectReadOnly implementation are different with spec.

Issue description

Comment 1 by gog...@gmail.com, Jan 3 2017

Comment 1 Deleted

Comment 2 by ajha@chromium.org, Jan 4 2017

Comment 2 Deleted

Comment 3 by bugdroid1@chromium.org, Jan 4 2017

Comment 3 Deleted

Comment 4 by dtapu...@chromium.org, Jan 4 2017

Comment 4 Deleted

Comment 5 by bugdroid1@chromium.org, Jan 7 2017

Comment 5 Deleted

Comment 6 by bugdroid1@chromium.org, Jan 7 2017

Comment 6 Deleted

Comment 7 by jinho.b...@samsung.com, Jan 13 2017

Comment 7 Deleted

Comment 8 by bugdroid1@chromium.org, Jan 16 2017

Comment 8 Deleted

Comment 9 by jinho.b...@samsung.com, Mar 9 2017

Comment 9 Deleted

Sign in to add a comment