New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678018 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Bug
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

disable vrshell experiment by default

Project Member Reported by liber...@chromium.org, Jan 3 2017

Issue description

the VrShell feature is enabled in non-channel builds, which turns off video overlay.  since nothing is relying on this, set the default to off.
 
Summary: disable vrshell experiment by default (was: disable vrshell)

Comment 2 by amp@chromium.org, Jan 3 2017

Some clarification on why this can be disabled.

Experiments for VrShell will require this field to be enabled, but since overlay's working correctly in VrShell ( issue 673886 ) is currently blocking the launch of VrShell (issue 641038), it is fine to disable the tests for now.  I'll add a note to the VrShell overlay  issue 673886  about making sure to re-enable these when that is fixed.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7345d7850f8c96020a2a43792b699b70093e9ac4

commit 7345d7850f8c96020a2a43792b699b70093e9ac4
Author: liberato <liberato@chromium.org>
Date: Wed Jan 04 00:54:13 2017

Turn off VrShell experiment in testing config.

Don't enable VrShell experiment in non-channel builds, since it
turns off overlay support for video playback on Android.  Enabling
tests is blocked on supporting overlay video properly anyway, so
nothing depends on this default.

BUG= 678018 

Review-Url: https://codereview.chromium.org/2613543002
Cr-Commit-Position: refs/heads/master@{#441272}

[modify] https://crrev.com/7345d7850f8c96020a2a43792b699b70093e9ac4/testing/variations/fieldtrial_testing_config.json

Status: Fixed (was: Started)

Sign in to add a comment