New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 678008 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Apr 2017
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 675877



Sign in to add a comment

Blink things declared in the global namespace won't be automatically renamed

Project Member Reported by lukasza@chromium.org, Jan 3 2017

Issue description

Some things in Blink are declared in the global namespace and therefore won't be recognized as belonging to Blink by the automatic rename tool.  Example:

third_party/WebKit/Source/core/xml/XPathParser.cpp

This isn't technically blocking the automatic renaming (e.g.  issue 578344 ) - we can fix a few of these things manually.  OTOH, we should recognize this as a limitation of the automatic renaming and as something that might need to be fixed in a manual follow-up.
 
Blocking: -578344 675877
Judging from the naming, it looks like this used to interact with bison.

Let's just mark this blocking the post rename cleanup, since it shouldn't break anything.
Summary: Blink things declared in the global namespace won't be automatically renamed (was: Blink things are declared in the global namespace won't be automatically renamed)

Comment 3 by dcheng@chromium.org, Apr 10 2017

Owner: lukasza@chromium.org
Status: Fixed (was: Available)
Looks like this was fixed in https://chromium.googlesource.com/chromium/src/+/3acb55665c4761345907f1fcc13027eb69c1bf95.

Sign in to add a comment