No longer require default experiments in study definitions and add end_date filtering. |
|
Issue descriptionNo longer require default experiments in a study definition. As part of this, we are adding support for end_date filtering, to replace expiry_date. end_date will act as a normal filter, causing the study to not be created when the date is past.
,
Jan 4 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/582227f037556baea1e228ced47eefed03758cb1 commit 582227f037556baea1e228ced47eefed03758cb1 Author: rdevlin.cronin <rdevlin.cronin@chromium.org> Date: Wed Jan 04 23:15:18 2017 Revert of Supporting study definitions without default groups and end_date filtering. (patchset #2 id:80001 of https://codereview.chromium.org/2614443002/ ) Reason for revert: Sheriff: Broke sizes on linux (see comment in CL) Original issue's description: > Supporting study definitions without default groups and end_date filtering. > > end_date is a replacement for expiry_date, which is deprecated by this change. The difference is that end_date is acts as a normal filter, and causes study to not be created when the date is past. expiry_date caused the study to be created, and forced to the default group. > > This change introduces a generic default group name, which is used for the field trial API when a study doesn't specify one. > > BUG=677976 > > Committed: https://crrev.com/49d24a0cc2a73773f3ee72b4d242d6fad8c57254 > Cr-Commit-Position: refs/heads/master@{#441487} TBR=rkaplow@chromium.org,jwd@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=677976 Review-Url: https://codereview.chromium.org/2615763002 Cr-Commit-Position: refs/heads/master@{#441504} [modify] https://crrev.com/582227f037556baea1e228ced47eefed03758cb1/components/variations/processed_study.cc [modify] https://crrev.com/582227f037556baea1e228ced47eefed03758cb1/components/variations/processed_study.h [modify] https://crrev.com/582227f037556baea1e228ced47eefed03758cb1/components/variations/proto/study.proto [modify] https://crrev.com/582227f037556baea1e228ced47eefed03758cb1/components/variations/study_filtering.cc [modify] https://crrev.com/582227f037556baea1e228ced47eefed03758cb1/components/variations/study_filtering.h [modify] https://crrev.com/582227f037556baea1e228ced47eefed03758cb1/components/variations/study_filtering_unittest.cc [modify] https://crrev.com/582227f037556baea1e228ced47eefed03758cb1/components/variations/variations_seed_processor.cc [modify] https://crrev.com/582227f037556baea1e228ced47eefed03758cb1/components/variations/variations_seed_processor_unittest.cc |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Jan 4 2017