New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677955 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

new MediaMetadata() should not fail

Project Member Reported by fbeaufort@chromium.org, Jan 3 2017

Issue description

Chrome Version       : 57.0.2951.0
OS Version: 9086.0.0

Steps to reproduce:

Open DevTools and type "new MediaMetadata();"


What is the expected result?

A stunning rainbow crosses the sky.


What happens instead of that?

VM62:1 Uncaught TypeError: Failed to construct 'MediaMetadata': 1 argument required, but only 0 present.
    at <anonymous>:1:1


According to https://wicg.github.io/mediasession/#the-mediametadata-interface,  MediaMetadataInit init object should be optional. 
 
Labels: -Pri-3 M-57 Pri-2
Owner: mlamouri@chromium.org
Status: Assigned (was: Unconfirmed)
Cc: zqzh...@chromium.org
Status: Started (was: Assigned)
https://codereview.chromium.org/2614463002
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1d78b4038dcf9d3d21f1045dcf1a2244a3118e3b

commit 1d78b4038dcf9d3d21f1045dcf1a2244a3118e3b
Author: mlamouri <mlamouri@chromium.org>
Date: Wed Jan 04 09:42:59 2017

Media Session: MediaMetadata constructor may have 0 parameters.

Per spec. Also, because the dictionary has a default value for each
field so passing {} or no parameter should have the same effect.

BUG= 677955 
R=zqzhang@chromium.org

Review-Url: https://codereview.chromium.org/2614463002
Cr-Commit-Position: refs/heads/master@{#441349}

[modify] https://crrev.com/1d78b4038dcf9d3d21f1045dcf1a2244a3118e3b/third_party/WebKit/LayoutTests/media/mediasession/mediasessionmetadata.html
[modify] https://crrev.com/1d78b4038dcf9d3d21f1045dcf1a2244a3118e3b/third_party/WebKit/Source/modules/mediasession/MediaMetadata.idl

Status: Fixed (was: Started)

Sign in to add a comment