New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677950 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Feb 2018
Cc:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Rebalance menu icon left/right padding (Mac 57 Canary)

Project Member Reported by ainslie@chromium.org, Jan 3 2017

Issue description

Padding to the left/right of the menu icon in Mac Canary (57.0.2969.0 canary) is uneven.

 
mac-canary-57-menu-padding.png
261 KB View Download
Labels: Needs-Feedback
I am unable to reproduce this in 57.0.2969.0 (using --disable-extensions to prevent extension icons from getting in the way). I think we'll need more info to be able to reproduce it.

HoverSpacing.png
26.4 KB View Download
Ahh. I still see the extra-left-padding in 57.0.2970.0 canary (64-bit) OSX 10.11.6 (15G1212) when I launch without any flags. With --disable-extensions it's even again (like in your screenshot #1).

Cc: rdevlin....@chromium.org
The browser actions container adds some padding in toolbar.  When --disable-extensions is added, the browser actions container is always hidden.  We also have a "grippy" area for the browser actions container to allow resizing; this area is to the left of the browser actions container.

My guess is that what's happening is that with the browser actions container visible, we over-compensate by adding both the grippy rect and the normal toolbar padding.  We'd probably just need to adjust pinLocationBarToLeftOfBrowserActionsContainerAndAnimate in ToolbarController.
Owner: shrike@chromium.org
Status: Assigned (was: Untriaged)
I'm guessing my fix for  Issue 634918  may have created this regression.

Comment 6 by shrike@chromium.org, Jan 23 2018

Cc: -shrike@chromium.org
Labels: -Pri-1 Pri-2
Owner: ----
Status: Untriaged (was: Assigned)
Back to triage (not sure if it's still an issue).

Comment 7 by meh...@chromium.org, Jan 24 2018

It is looking centered now in latest Canary Version 66.0.3330.0 (NonRetina Device). Please see the screenshot.

ainslie@ Can we close this issue?


Bildschirmfoto 2018-01-24 um 18.23.54.png
18.3 KB View Download
Cc: -hwi@chromium.org -rdevlin....@chromium.org -bettes@chromium.org
It looks more balanced to me (squint-test). But I'll defer to maxwalker@'s judgement.
Labels: -Pri-2 -Needs-Feedback Hotlist-CocoaBrowser Pri-3
Status: Available (was: Untriaged)
Looks good to me and matches the specs on retina and regular screens in Canary Version 66.0.3344.0 (see attachment).
Current and Specs.png
138 KB View Download
Status: Fixed (was: Available)
Thanks for your feedback. Closing then as fixed for now.
Status: Verified (was: Fixed)
And +Verified per comment 11.

Sign in to add a comment