Issue metadata
Sign in to add a comment
|
Rebalance menu icon left/right padding (Mac 57 Canary) |
||||||||||||||||||||
Issue descriptionPadding to the left/right of the menu icon in Mac Canary (57.0.2969.0 canary) is uneven.
,
Jan 3 2017
Ahh. I still see the extra-left-padding in 57.0.2970.0 canary (64-bit) OSX 10.11.6 (15G1212) when I launch without any flags. With --disable-extensions it's even again (like in your screenshot #1).
,
Jan 4 2017
,
Jan 4 2017
The browser actions container adds some padding in toolbar. When --disable-extensions is added, the browser actions container is always hidden. We also have a "grippy" area for the browser actions container to allow resizing; this area is to the left of the browser actions container. My guess is that what's happening is that with the browser actions container visible, we over-compensate by adding both the grippy rect and the normal toolbar padding. We'd probably just need to adjust pinLocationBarToLeftOfBrowserActionsContainerAndAnimate in ToolbarController.
,
Jan 6 2017
I'm guessing my fix for Issue 634918 may have created this regression.
,
Jan 23 2018
Back to triage (not sure if it's still an issue).
,
Jan 24 2018
It is looking centered now in latest Canary Version 66.0.3330.0 (NonRetina Device). Please see the screenshot. ainslie@ Can we close this issue?
,
Jan 24 2018
It looks more balanced to me (squint-test). But I'll defer to maxwalker@'s judgement.
,
Jan 30 2018
,
Jan 30 2018
,
Feb 9 2018
Looks good to me and matches the specs on retina and regular screens in Canary Version 66.0.3344.0 (see attachment).
,
Feb 9 2018
Thanks for your feedback. Closing then as fixed for now.
,
Feb 9 2018
And +Verified per comment 11. |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by shrike@chromium.org
, Jan 3 201726.4 KB
26.4 KB View Download