New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677948 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Feature



Sign in to add a comment

Remove src/third_party/libjingle

Project Member Reported by kjellander@chromium.org, Jan 3 2017

Issue description

A lot of work has been happening in https://bugs.chromium.org/p/webrtc/issues/detail?id=4256 for moving the talk/ code into webrtc/. The talk/ dir in WebRTC is now gone but there are still GN targets left in src/third_party/libjingle.

This bug tracks the final removal of that in Chromium.
There's an ongoing CL https://codereview.chromium.org/2413103004/ for this.
 
Cc: tfarina@chromium.org
Project Member

Comment 2 by bugdroid1@chromium.org, Feb 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e3cbd6d64e02369e691f65f791ab99258305243d

commit e3cbd6d64e02369e691f65f791ab99258305243d
Author: kjellander <kjellander@chromium.org>
Date: Tue Feb 28 06:49:46 2017

Remove third_party/libjingle and update GN targets.

In order to keep actual changes to a minimum, this CL
just moves the targets:
//third_party/libjingle:libjingle -> //third_party/webrtc_overrides
//third_party/libjingle/webrtc:libjingle_webrtc -> //third_party/webrtc_overrides:init_webrtc
and updates the paths to the webrtc_overrides sources.

References to the old targets are updated to the new ones, with no
additional changes.

The //third_party/libjingle:libstunprober target is no longer referenced
in Chrome (it's been replaced by //third_party/webrtc/p2p:libstunprober)
so it was removed.

BUG= 677948 

Review-Url: https://codereview.chromium.org/2413103004
Cr-Commit-Position: refs/heads/master@{#453530}

[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/chrome/browser/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/chrome/browser/chromeos/DEPS
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/chrome/service/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/chrome/test/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/chrome/tools/service_discovery_sniffer/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/content/DEPS
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/content/browser/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/content/common/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/content/public/renderer/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/content/renderer/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/content/renderer/DEPS
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/content/test/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/extensions/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/jingle/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/jingle/DEPS
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/remoting/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/remoting/DEPS
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/remoting/host/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/remoting/host/it2me/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/remoting/protocol/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/remoting/signaling/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/remoting/test/BUILD.gn
[delete] https://crrev.com/27809c875f0856484aeb26e7378e68f8569f325b/third_party/libjingle/BUILD.gn
[delete] https://crrev.com/27809c875f0856484aeb26e7378e68f8569f325b/third_party/libjingle/OWNERS
[delete] https://crrev.com/27809c875f0856484aeb26e7378e68f8569f325b/third_party/libjingle/README.chromium
[delete] https://crrev.com/27809c875f0856484aeb26e7378e68f8569f325b/third_party/libjingle/webrtc/BUILD.gn
[add] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/third_party/webrtc_overrides/BUILD.gn
[modify] https://crrev.com/e3cbd6d64e02369e691f65f791ab99258305243d/tools/ipc_fuzzer/message_lib/BUILD.gn

Status: Fixed (was: Started)
Forgot to close this. src/third_party/libjingle is deleted since Feb 28. Some of the stuff is basically moved into src/third_party/webrtc_overrides though, but that should be cleaned up in a larger refactoring effort (currently not yet planned).

Sign in to add a comment