This code does not need to be in a namespace at all.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/922b7111cd690c0b278ef0aebd9b98a77309d0d1 commit 922b7111cd690c0b278ef0aebd9b98a77309d0d1 Author: rohitrao <rohitrao@chromium.org> Date: Tue Jan 03 14:31:05 2017 Moves overscroll code out of the ios_internal namespace. Most of this CL was automated using the following commands: tools/git/mffr.py -f ios_internal::OverscrollAction OverscrollAction tools/git/mffr.py -f ios_internal::OverscrollState OverscrollState tools/git/mffr.py -f ios_internal::OverscrollStyle OverscrollStyle Also fixes a typo in the overscroll notification names. BUG= 677941 Review-Url: https://codereview.chromium.org/2611673002 Cr-Commit-Position: refs/heads/master@{#441120} [modify] https://crrev.com/922b7111cd690c0b278ef0aebd9b98a77309d0d1/ios/chrome/browser/tabs/tab.mm [modify] https://crrev.com/922b7111cd690c0b278ef0aebd9b98a77309d0d1/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/922b7111cd690c0b278ef0aebd9b98a77309d0d1/ios/chrome/browser/ui/fullscreen_controller.mm [modify] https://crrev.com/922b7111cd690c0b278ef0aebd9b98a77309d0d1/ios/chrome/browser/ui/ntp/google_landing_controller.mm [modify] https://crrev.com/922b7111cd690c0b278ef0aebd9b98a77309d0d1/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.h [modify] https://crrev.com/922b7111cd690c0b278ef0aebd9b98a77309d0d1/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm [modify] https://crrev.com/922b7111cd690c0b278ef0aebd9b98a77309d0d1/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.h [modify] https://crrev.com/922b7111cd690c0b278ef0aebd9b98a77309d0d1/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_view.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a3666d04c66f90be65160936b5a1a16e0db54f6e commit a3666d04c66f90be65160936b5a1a16e0db54f6e Author: rohitrao <rohitrao@chromium.org> Date: Tue Jan 03 18:25:15 2017 [ios] Deletes tab_util.h and tab_util.mm. This file contains tab drawing routines that are no longer used. BUG= 677941 Review-Url: https://codereview.chromium.org/2603363002 Cr-Commit-Position: refs/heads/master@{#441163} [modify] https://crrev.com/a3666d04c66f90be65160936b5a1a16e0db54f6e/ios/chrome/browser/ui/stack_view/card_view.mm [modify] https://crrev.com/a3666d04c66f90be65160936b5a1a16e0db54f6e/ios/chrome/browser/ui/tabs/BUILD.gn [delete] https://crrev.com/51f1cd9460c0e166805ceb6d47a4380408c9fae6/ios/chrome/browser/ui/tabs/tab_util.h [delete] https://crrev.com/51f1cd9460c0e166805ceb6d47a4380408c9fae6/ios/chrome/browser/ui/tabs/tab_util.mm [modify] https://crrev.com/a3666d04c66f90be65160936b5a1a16e0db54f6e/ios/chrome/browser/ui/tabs/tab_view.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aa323161b7a81feae271ad6b4f2d21a613380367 commit aa323161b7a81feae271ad6b4f2d21a613380367 Author: rohitrao <rohitrao@chromium.org> Date: Wed Jan 04 14:29:13 2017 [ios] Moves tab_switcher code out of the ios_internal namespace. Most of this CL was automated using the following commands: tools/git/mffr.py -f ios_internal::SessionChanges SessionChanges tools/git/mffr.py -f ios_internal::SessionType TabSwitcherSessionType Also renames some methods to have less generic names, now that they are no longer in the ios_internal namespace. BUG= 677941 Review-Url: https://codereview.chromium.org/2608253003 Cr-Commit-Position: refs/heads/master@{#441369} [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/ntp/recent_tabs/views/session_tab_data_view.mm [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/session_changes.h [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/session_changes.mm [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_model.h [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_model.mm [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_model_unittest.mm [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.h [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_cell.mm [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.h [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_controller.mm [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_view.h [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_view.mm [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_session_cell_data.h [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_session_cell_data.mm [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.h [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_utils.mm [modify] https://crrev.com/aa323161b7a81feae271ad6b4f2d21a613380367/ios/chrome/browser/ui/tab_switcher/tab_switcher_utils_unittest.mm
Issue 675580 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/54e58e7497dd6bb13d0d3bfb93054b2a17ebd282 commit 54e58e7497dd6bb13d0d3bfb93054b2a17ebd282 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Mon Jun 26 12:53:30 2017 Remove FILE thread dependency in memory_monitor.mm. The named thread API is deprecated in favor of the post_task.h API. Change the public API of memory monitor to move all the code dealing with task sequencer API into memory_monitor.mm. Fix variable naming that were not following the Style guide and move the code from ios_namespace to the global namespace. BUG= 689520 , 677941 Change-Id: I234a4bce680f580d4fba231e4f50d7ebe24d79d9 Reviewed-on: https://chromium-review.googlesource.com/548036 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#482251} [modify] https://crrev.com/54e58e7497dd6bb13d0d3bfb93054b2a17ebd282/ios/chrome/app/main_controller.mm [modify] https://crrev.com/54e58e7497dd6bb13d0d3bfb93054b2a17ebd282/ios/chrome/app/memory_monitor.h [modify] https://crrev.com/54e58e7497dd6bb13d0d3bfb93054b2a17ebd282/ios/chrome/app/memory_monitor.mm
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a commit ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a Author: Sylvain Defresne <sdefresne@chromium.org> Date: Thu Aug 31 16:29:52 2017 Remove ios_internal & ios_internal_settings namespaces from ios/. Move the code from ios_internal and ios_internal_settings namespaces to the global namespace as those namespace are left over from the upstreaming effort. Notable changes: - moved code from ios_internal::sync namespace to global namespace as all the methods have "Sync" in their name and sync is already a symbol from unistd.h (causing an error) - converted SizeClassForReporting and NewTabButtonStyle enumeration to "enum class" to avoid polution of the global namespace with the enumerators - renamed kToolbarAnimationDuration as the name is too generic to be in the global namespace - renamed displaySyncErrors function to follow c++ style - added a forwarding function for BlockToOpenURL() as the downstream code calls this function (temporary, will be removed once the downstream code is fixed to use the new name) Bug: 677941 Change-Id: Id9f046ee246ab9aba994a86b51cead6ecad2a62d Reviewed-on: https://chromium-review.googlesource.com/645807 Reviewed-by: Eric Noyau <noyau@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#498887} [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/app/main_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/app/safe_mode/safe_mode_view_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/crash_report/crash_report_helper.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/crash_report/crash_report_helper.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/metrics/size_class_recorder.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/metrics/size_class_recorder_private.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/metrics/size_class_recorder_unittest.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/authentication/authentication_flow_performer.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/authentication/authentication_ui_util.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/authentication/authentication_ui_util.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/authentication/authentication_ui_util_unittest.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/authentication/chrome_signin_view_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/authentication/signin_interaction_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/browser_view_controller.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/browser_view_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/collection_view/cells/collection_view_footer_item_unittest.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/collection_view/cells/test_utils.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/collection_view/cells/test_utils.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/dialogs/dialog_presenter.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/first_run/first_run_chrome_signin_view_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/first_run/first_run_util.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/first_run/first_run_util.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/first_run/first_run_util_unittest.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/first_run/welcome_to_chrome_view.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/fullscreen_controller.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/fullscreen_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/main/browser_view_wrangler.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/ntp/google_landing_mediator.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/ntp/recent_tabs/views/signed_in_sync_off_view.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/overscroll_actions/overscroll_actions_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/payments/cells/accepted_payment_methods_item_unittest.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/payments/cells/page_info_item_unittest.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/payments/cells/payment_method_item_unittest.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/payments/cells/payments_text_item_unittest.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/settings/about_chrome_collection_view_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/settings/accounts_collection_view_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/settings/password_details_collection_view_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/settings/settings_collection_view_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/settings/settings_utils.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/settings/settings_utils.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/settings/sync_create_passphrase_collection_view_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/settings/sync_encryption_passphrase_collection_view_controller_unittest.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/settings/sync_settings_collection_view_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/side_swipe/side_swipe_controller.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/side_swipe/side_swipe_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/stack_view/card_view.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/stack_view/page_animation_util.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/stack_view/page_animation_util.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/stack_view/stack_view_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/sync/sync_error_infobar_delegate.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/sync/sync_util.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/sync/sync_util.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/tab_switcher/tab_switcher_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/tab_switcher/tab_switcher_panel_overlay_view.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/tab_switcher/tab_switcher_view.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/tab_switcher/tab_switcher_view.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/chrome/browser/ui/tabs/tab_strip_controller.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/shared/chrome/browser/ui/dialogs/nsurl_protection_space_util.h [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/shared/chrome/browser/ui/dialogs/nsurl_protection_space_util.mm [modify] https://crrev.com/ed8c0dbbb9f836c5ee09eab83361d1b3030eaa7a/ios/shared/chrome/browser/ui/dialogs/nsurl_protection_space_util_unittest.mm
The following revision refers to this bug: https://chrome-internal.googlesource.com/chrome/ios_internal.git/+/e9eb519ccf85b2c85be345cff297f6d8d4616396 commit e9eb519ccf85b2c85be345cff297f6d8d4616396 Author: Sylvain Defresne <sdefresne@google.com> Date: Fri Sep 01 13:22:21 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/415c7de5f341f6ae55bb1335507e56f278adaa50 commit 415c7de5f341f6ae55bb1335507e56f278adaa50 Author: Sylvain Defresne <sdefresne@chromium.org> Date: Fri Sep 01 13:23:54 2017 Remove ios_internal & ios_internal_settings namespaces from ios/. Remove the forwarding-function ios_internal_settings::BlockToOpenURL as the downstream code has been fixed to use the new name. Bug: 677941 Change-Id: I108c9c8f1a662544350cb9a960458417426aae97 Reviewed-on: https://chromium-review.googlesource.com/646330 Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by: Eric Noyau <noyau@chromium.org> Cr-Commit-Position: refs/heads/master@{#499177} [modify] https://crrev.com/415c7de5f341f6ae55bb1335507e56f278adaa50/ios/chrome/browser/ui/settings/settings_utils.h [modify] https://crrev.com/415c7de5f341f6ae55bb1335507e56f278adaa50/ios/chrome/browser/ui/settings/settings_utils.mm
Comment 1 by rohitrao@chromium.org
, Jan 3 2017