New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677926 link

Starred by 2 users

Issue metadata

Status: Verified
Owner:
Closed: Feb 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression : 'Proxy' Settings icon is seen enabled even Wi-Fi is disabled in Sign out screen

Project Member Reported by mmanchala@chromium.org, Jan 3 2017

Issue description

Chrome Version: 57.0.2969.0/9145.0.0 dev-channel Candy,Daisy and Peppy
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User ->Now Go to Uber Tray -> Click on 'Sign out'
(2)In Sign out screen -> Go to Uber tray and select 'Network' option 
(3)Now disable Wi-Fi and observe 'Proxy' Settings icon(Please refer video and screenshot)

Expected:'Proxy' Settings icon should be seen as disabled 
Actual: Instead 'Proxy' Settings icon is seen enabled 

This is Regression issue as same is working fine in 55.0.2883.103/8872.73.0 Stable-channel Butterfly

@tbuckley: Please confirm the Issue
 
Actual_EnabledIcon.jpg
355 KB View Download
Actual_EnabledIcon.mp4
7.6 MB View Download
Expected_Disabled.jpg
289 KB View Download
Expected_Disabled.mp4
6.3 MB View Download
Labels: -Pri-1 -ReleaseBlock-Stable Proj-MaterialDesign-CrOS Pri-2
Owner: varkha@chromium.org
Not a release-blocker for M-57, and I'd say this is OK to even punt to m-58 if needed.
Labels: -M-57 M-58

Comment 3 by varkha@chromium.org, Feb 13 2017

Status: Started (was: Assigned)
Draft CL at https://codereview.chromium.org/2692943005.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 16 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7009b6753eccab02d997e91702bccb9041442a5c

commit 7009b6753eccab02d997e91702bccb9041442a5c
Author: varkha <varkha@chromium.org>
Date: Thu Feb 16 03:34:46 2017

[ash-md] Disables proxy settings button when there are no networks

When converting to MD the code that updated the proxy settings
button became lost. This CL restores it.

BUG= 677926 
TEST=visual per bug description

Review-Url: https://codereview.chromium.org/2692943005
Cr-Commit-Position: refs/heads/master@{#450862}

[modify] https://crrev.com/7009b6753eccab02d997e91702bccb9041442a5c/ash/common/system/chromeos/network/network_state_list_detailed_view.cc
[modify] https://crrev.com/7009b6753eccab02d997e91702bccb9041442a5c/ash/common/system/chromeos/network/network_state_list_detailed_view.h

Comment 5 by varkha@chromium.org, Feb 16 2017

Status: Fixed (was: Started)
Status: Verified (was: Fixed)

Sign in to add a comment