New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677919 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 1
Type: Feature

Blocking:
issue 646841



Sign in to add a comment

In ClickBasedCategoryRanker make dismissed category penalty a variational parameter.

Project Member Reported by vitaliii@chromium.org, Jan 3 2017

Issue description

Currently it is hardcoded to 2 (i.e. the dismissed category jumps 2 positions down). However, jkrcal@ raised a concern that this may be too dramatic and, thus, it would be nice to control it.
 
Labels: zine-17-01-02
Owner: vitaliii@chromium.org
Status: Started (was: Available)
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecbf607e7aced540428687d67a9991d97d115e6e

commit ecbf607e7aced540428687d67a9991d97d115e6e
Author: vitaliii <vitaliii@chromium.org>
Date: Tue Jan 17 06:59:11 2017

[NTP::SectionOrder] Make dismissed category penalty a variation param.

Make dismissed category penalty a variation param instead of simply
hardcoding the value. Handle penalty equal to 0 correctly (ignore
OnCategoryDismissed call).

We may want to change the value or to disable it completely (by setting
to 0) later.

BUG= 677919 

Review-Url: https://codereview.chromium.org/2612773003
Cr-Commit-Position: refs/heads/master@{#443996}

[modify] https://crrev.com/ecbf607e7aced540428687d67a9991d97d115e6e/components/ntp_snippets/category_rankers/click_based_category_ranker.cc
[modify] https://crrev.com/ecbf607e7aced540428687d67a9991d97d115e6e/components/ntp_snippets/category_rankers/click_based_category_ranker_unittest.cc

Labels: zine-17-01-16
Status: Fixed (was: Started)

Sign in to add a comment