New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677918 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Factory: Hard to debug / test wiping due to factory,par

Project Member Reported by hungte@chromium.org, Jan 3 2017

Issue description

Example:
 https://code.google.com/p/chrome-os-partner/issues/detail?id=60898#c9

Currently we invoke factory.par for wipe-in-place, however it's easy for partners (sometimes even ourselves) to remember / figure out that we have to rebuild toolkit for factory.par.

I wonder if there's some easy way to allow using the source in /usr/local/factory instead of factory.par (i.e., only use factory.par if needed, like station-based), or at least check and alert that local wipe program is different from factory.par.
 
Maybe we can just copy the entire factory folder to tmp rootfs?

Comment 2 by hungte@chromium.org, Jan 25 2017

Owner: yllin@chromium.org
Status: Assigned (was: Untriaged)
Temporarily assign to Nooger. yllin, you can try to see if there's something can be improved here.
 Issue 659351  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/2838b9c2288ee502a168497ba9a83cc1d9114e65

commit 2838b9c2288ee502a168497ba9a83cc1d9114e65
Author: Wei-Han Chen <stimim@google.com>
Date: Thu Feb 09 11:10:22 2017

deploy_utils: FactoryBin for using local factory toolkit.

To generalize testing flow, it would be better to have a common API for
'gooftool' and 'hwid' provided by either a factory python archive or
local factory toolkit.

FactoryBin is a counterpart of FactoryPythonArchive, which invokes
python scripts under factory/bin rather than a factory python archive.

And class FactoryTools is an abstract class to unify APIs of FactoryBin
and FactoryPythonArchive.

BUG=chromium:677918
TEST=None

Change-Id: I835c2c9dcb4032932e94166a901b3a762c11e411
Reviewed-on: https://chromium-review.googlesource.com/330990
Commit-Ready: Wei-Han Chen <stimim@chromium.org>
Tested-by: Wei-Han Chen <stimim@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/2838b9c2288ee502a168497ba9a83cc1d9114e65/py/test/utils/deploy_utils.py

Project Member

Comment 5 by bugdroid1@chromium.org, Feb 9 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/58658febe87ed34cfb20063101e1e1ccd51b82bd

commit 58658febe87ed34cfb20063101e1e1ccd51b82bd
Author: Wei-Han Chen <stimim@google.com>
Date: Thu Feb 09 17:21:45 2017

deploy_utils: add Run function

Run function is a wrapper of Call, in addition to return_code, this
function returns a (stdout, stderr, return_code) tuple, allow callers to
get these three results in an easier way.

BUG=chromium:677918
TEST=make test, manual test

Change-Id: Ia057d184d315bcb501589c18fec2f4129017dd35
Reviewed-on: https://chromium-review.googlesource.com/331500
Commit-Ready: Wei-Han Chen <stimim@chromium.org>
Tested-by: Wei-Han Chen <stimim@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/58658febe87ed34cfb20063101e1e1ccd51b82bd/py/test/utils/deploy_utils.py

Comment 6 by hungte@chromium.org, Feb 16 2017

Cc: yllin@chromium.org
Owner: stimim@chromium.org
Hi Stimim, is this finished, or are there any pending items?

Comment 8 by hungte@chromium.org, Jul 26 2017

Cc: -phoenixshen@chromium.org -yllin@chromium.org -stimim@chromium.org -shunhsingou@chromium.org chromeos-factory-eng@google.com
We are still using factory.par for wipe_init, right?
> We are still using factory.par for wipe_init, right?
yes
So what should we do here? copy /usr/local/factory to wiping env instead of using factory.par?
Yes, and maybe some external deps too.

(reply to the email thread doesn't work...)

Sign in to add a comment