Factory: Hard to debug / test wiping due to factory,par |
||||
Issue descriptionExample: https://code.google.com/p/chrome-os-partner/issues/detail?id=60898#c9 Currently we invoke factory.par for wipe-in-place, however it's easy for partners (sometimes even ourselves) to remember / figure out that we have to rebuild toolkit for factory.par. I wonder if there's some easy way to allow using the source in /usr/local/factory instead of factory.par (i.e., only use factory.par if needed, like station-based), or at least check and alert that local wipe program is different from factory.par.
,
Jan 25 2017
Temporarily assign to Nooger. yllin, you can try to see if there's something can be improved here.
,
Feb 8 2017
Issue 659351 has been merged into this issue.
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/2838b9c2288ee502a168497ba9a83cc1d9114e65 commit 2838b9c2288ee502a168497ba9a83cc1d9114e65 Author: Wei-Han Chen <stimim@google.com> Date: Thu Feb 09 11:10:22 2017 deploy_utils: FactoryBin for using local factory toolkit. To generalize testing flow, it would be better to have a common API for 'gooftool' and 'hwid' provided by either a factory python archive or local factory toolkit. FactoryBin is a counterpart of FactoryPythonArchive, which invokes python scripts under factory/bin rather than a factory python archive. And class FactoryTools is an abstract class to unify APIs of FactoryBin and FactoryPythonArchive. BUG=chromium:677918 TEST=None Change-Id: I835c2c9dcb4032932e94166a901b3a762c11e411 Reviewed-on: https://chromium-review.googlesource.com/330990 Commit-Ready: Wei-Han Chen <stimim@chromium.org> Tested-by: Wei-Han Chen <stimim@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/2838b9c2288ee502a168497ba9a83cc1d9114e65/py/test/utils/deploy_utils.py
,
Feb 9 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/58658febe87ed34cfb20063101e1e1ccd51b82bd commit 58658febe87ed34cfb20063101e1e1ccd51b82bd Author: Wei-Han Chen <stimim@google.com> Date: Thu Feb 09 17:21:45 2017 deploy_utils: add Run function Run function is a wrapper of Call, in addition to return_code, this function returns a (stdout, stderr, return_code) tuple, allow callers to get these three results in an easier way. BUG=chromium:677918 TEST=make test, manual test Change-Id: Ia057d184d315bcb501589c18fec2f4129017dd35 Reviewed-on: https://chromium-review.googlesource.com/331500 Commit-Ready: Wei-Han Chen <stimim@chromium.org> Tested-by: Wei-Han Chen <stimim@chromium.org> Reviewed-by: Hung-Te Lin <hungte@chromium.org> [modify] https://crrev.com/58658febe87ed34cfb20063101e1e1ccd51b82bd/py/test/utils/deploy_utils.py
,
Feb 16 2017
Hi Stimim, is this finished, or are there any pending items?
,
Mar 14 2017
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform/factory/+/dd3dfa29019b5c39ed157e6be49e1cd9ba3fb3a2 commit dd3dfa29019b5c39ed157e6be49e1cd9ba3fb3a2 Author: Ting Shen <phoenixshen@google.com> Date: Tue Mar 14 17:32:38 2017 pytest: use local factory toolkit if possible CL:330990 implements CreateFactoryTools to switch between factory.par and local toolkit. Use this in all pytests except offline test. BUG=chromium:677918 TEST=None Change-Id: I08491ceadcbf7961580ad9c7e32224c0ee4cf4ce Reviewed-on: https://chromium-review.googlesource.com/448476 Commit-Ready: Ting Shen <phoenixshen@chromium.org> Tested-by: Ting Shen <phoenixshen@chromium.org> Reviewed-by: Wei-Han Chen <stimim@chromium.org> [modify] https://crrev.com/dd3dfa29019b5c39ed157e6be49e1cd9ba3fb3a2/py/test/pytests/finalize/finalize.py [modify] https://crrev.com/dd3dfa29019b5c39ed157e6be49e1cd9ba3fb3a2/py/test/pytests/check_image_version.py [modify] https://crrev.com/dd3dfa29019b5c39ed157e6be49e1cd9ba3fb3a2/py/test/pytests/verify_components.py [modify] https://crrev.com/dd3dfa29019b5c39ed157e6be49e1cd9ba3fb3a2/py/test/pytests/i2c_probe.py [modify] https://crrev.com/dd3dfa29019b5c39ed157e6be49e1cd9ba3fb3a2/py/test/pytests/hwid_v3.py [modify] https://crrev.com/dd3dfa29019b5c39ed157e6be49e1cd9ba3fb3a2/py/test/pytests/probe/probe.py
,
Jul 26 2017
We are still using factory.par for wipe_init, right?
,
Jul 26 2017
> We are still using factory.par for wipe_init, right? yes
,
Sep 7
So what should we do here? copy /usr/local/factory to wiping env instead of using factory.par?
,
Sep 7
Yes, and maybe some external deps too. (reply to the email thread doesn't work...) |
||||
►
Sign in to add a comment |
||||
Comment 1 by shunhsingou@chromium.org
, Jan 4 2017