New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677902 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Not on Chrome
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: 'You can clear your browsing data from this menu' tool tip of chrome://history is misplaced.

Reported by jshan...@etouch.net, Jan 3 2017

Issue description

Chrome Version: 57.0.2970.0 eafbd71d2e7eda209965d66a540d596038edd68c-refs/heads/master@{#441083} (64-bit)
OS: Windows(7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.11.6, 10.12.1)

Steps:
1. Freshly launch Chrome and navigate to chrome://history
2. Resize the browser window such that 'You can clear your browsing data from this menu' tool tip is seen.
3. Observe

Actual: 'You can clear your browsing data from this menu' tool tip is seen misplaced i.e moved upward.

Expected: 'You can clear your browsing data from this menu' tool tip should be seen properly.

This is regression issue broken in M 57 and will soon update bisect info :

Good build:57.0.2957.0
Bad build: 57.0.2959.0


 
Actual_Expected_result.jpg
94.3 KB View Download
Cc: brajkumar@chromium.org
Labels: hasbisect-per-revision
Owner: tsergeant@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,

You are probably looking for a change made after 439709 (known good), but no later than 439710 (first known bad).

CHANGE-LOG URL:
----------------
https://chromium.googlesource.com/chromium/src/+log/477ef171bbd8a21249a65d28b4693552a0a1def9..abaa208feeda5799c50d802f2ebc5e8b81aa00b2

From the CL above, assigning the issue to the concern owner

@tsergeant : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 4 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4df758bcc8a02b815277caf9979e2d7dabc4d36f

commit 4df758bcc8a02b815277caf9979e2d7dabc4d36f
Author: tsergeant <tsergeant@chromium.org>
Date: Wed Jan 04 20:01:52 2017

MD History: Fix position of Clear Browsing Data menu promo

The positioning of the menu promo in MD History was accidentally broken
in crrev.com/439710 when the layout of the left section of the toolbar
was changed.

BUG= 677902 
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2609933003
Cr-Commit-Position: refs/heads/master@{#441439}

[modify] https://crrev.com/4df758bcc8a02b815277caf9979e2d7dabc4d36f/chrome/browser/resources/md_downloads/vulcanized.html
[modify] https://crrev.com/4df758bcc8a02b815277caf9979e2d7dabc4d36f/chrome/browser/resources/md_history/app.vulcanized.html
[modify] https://crrev.com/4df758bcc8a02b815277caf9979e2d7dabc4d36f/ui/webui/resources/cr_elements/cr_toolbar/cr_toolbar.html

Status: Fixed (was: Assigned)

Sign in to add a comment