New issue
Advanced search Search tips

Issue 677901 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Factory: Think about the right way to configure per-device components.

Project Member Reported by hungte@chromium.org, Jan 3 2017

Issue description

This issue is for brain storming.

Currently we have several ways to implement board-specific components:

 1. Device API, via writing new code (for example LED)
 2. Device API, via external config (see device.audio).
 3. Args in test list (see usb-storage tests, also button tests)

There are pros and cons, but maybe we want to have some definition or guide line for what to use.

For example, LED & buttons are very similar - usually implemented via gpio or some sysfs node. What if we implement a generic GPIO driver and extend with configs (like audio) so that we can do something like dut.button.GetAllNames(), dut.button.GetStatus(name), dut.led.GetAllNames(), dut.led.GetStatus(name); then we can move the ectool/gpio/input driver code in pytests into board level and simply request the name of button/led in dargs.
 
 

Comment 1 by hungte@chromium.org, Jan 25 2017

Owner: youcheng@chromium.org
Status: Assigned (was: Untriaged)
Summary: Factory: Think about the right way to configure per-device components. (was: Factory: Think about the right way to configure pre-device components.)
temporary assign to youcheng - let me know if you have some thoughts on this, thanks!

Comment 2 by hungte@chromium.org, Jul 26 2017

Cc: -stimim@chromium.org chromeos-factory-eng@google.com
Owner: ----
Status: Untriaged (was: Assigned)
This is probably case-by-base.
Owner: stimim@google.com
Status: Assigned (was: Untriaged)
Assign to TL stimim@ to create a guideline.

Sign in to add a comment