New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677889 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Jan 2017
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Info icon in Clear browsing data overlay is chopped.

Reported by vvishwak...@etouch.net, Jan 3 2017

Issue description

Chrome Version: 57.0.2969.0 (Official Build) canary 9d1a05815549df9a90f4383645564d7160850901-refs/heads/master@{#441040} (64-bit)
OS: Mac (10.12.1)

What steps will reproduce the problem?
1) Launch chrome and navigate to chrome://settings/clearBrowserData.
2) Observe the info icon at the bottom.

Info icon seems chopped.

Info icon should not be chopped.

This is a Regression issue broken in M-57, will soon update other info
Manual bisect:
Good build: 57.0.2951.0
Bad build: 57.0.2952.0

Note: Issue is specific to Mac OS (10.12.1). Issue is not seen on Windows (7,8,10), Linux (14.04 LTS) and Mac (10.11.6).

 
Info_icon.jpg
139 KB View Download
Labels: hasbisect-per-revision
Owner: jvanverth@chromium.org
Status: Assigned (was: Unconfirmed)
Using the per-revision bisect providing the bisect results,
Good build: 57.0.2951.0 (Revision : 438385)
Bad build: 57.0.2952.0 (Revision : 438707)

You are probably looking for a change made after 438498 (known good), but no later than 438499 (first known bad).

CHANGELOG URL:

The script might not always return single CL as suspect as some perf builds might get missing due to failure.

  https://chromium.googlesource.com/chromium/src/+log/8734aac57d4f724768a53326542d911f1836ad45..bcd68bcb14206d4f26c5798ed714a0878ac09b28

From the above CL , suspecting the change and assigning it to concerned owner

https://skia.googlesource.com/skia.git/+/ecdb686a5cae733ecd914c8bd5fd407b45ee2594

@Jim Van Verth- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!

I've verified that it also happens on Mac OS 10.11.6. My guess is that the other 10.11 machine has a Retina display.
This was verified with the 57.0.2973.0 canary.
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/d081ff314f07104adacaadc3d0f8f13dc741f016

commit d081ff314f07104adacaadc3d0f8f13dc741f016
Author: Jim Van Verth <jvanverth@google.com>
Date: Wed Jan 11 17:21:43 2017

More fixes for distance field paths

Disables use of SDFs for very small paths (because of blurring) and
adds a border of 1 pixel in device space to handle antialiasing.

BUG= chromium:677889 

Change-Id: I81e49477c943d41523fd836e55abd696a985491f
Reviewed-on: https://skia-review.googlesource.com/6832
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Brian Salomon <bsalomon@google.com>

[modify] https://crrev.com/d081ff314f07104adacaadc3d0f8f13dc741f016/gm/pathfill.cpp
[modify] https://crrev.com/d081ff314f07104adacaadc3d0f8f13dc741f016/src/gpu/ops/GrAADistanceFieldPathRenderer.cpp
[modify] https://crrev.com/d081ff314f07104adacaadc3d0f8f13dc741f016/src/gpu/ops/GrAADistanceFieldPathRenderer.h

Project Member

Comment 5 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/000ca636e6de2e2b8bf9c82e3dee2d7ad8e1bed8

commit 000ca636e6de2e2b8bf9c82e3dee2d7ad8e1bed8
Author: Jim Van Verth <jvanverth@google.com>
Date: Wed Jan 11 18:35:02 2017

Revert "More fixes for distance field paths"

This reverts commit d081ff314f07104adacaadc3d0f8f13dc741f016.

Reason for revert: Failing unit tests.

Original change's description:
> More fixes for distance field paths
> 
> Disables use of SDFs for very small paths (because of blurring) and
> adds a border of 1 pixel in device space to handle antialiasing.
> 
> BUG= chromium:677889 
> 
> Change-Id: I81e49477c943d41523fd836e55abd696a985491f
> Reviewed-on: https://skia-review.googlesource.com/6832
> Commit-Queue: Jim Van Verth <jvanverth@google.com>
> Reviewed-by: Brian Salomon <bsalomon@google.com>
> 

TBR=jvanverth@google.com,bsalomon@google.com,robertphillips@google.com,reviews@skia.org
BUG= chromium:677889 
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Change-Id: I4a6a698fa2e9e58c1c98a5a89f54bed724527951
Reviewed-on: https://skia-review.googlesource.com/6890
Commit-Queue: Jim Van Verth <jvanverth@google.com>
Reviewed-by: Jim Van Verth <jvanverth@google.com>

[modify] https://crrev.com/000ca636e6de2e2b8bf9c82e3dee2d7ad8e1bed8/gm/pathfill.cpp
[modify] https://crrev.com/000ca636e6de2e2b8bf9c82e3dee2d7ad8e1bed8/src/gpu/ops/GrAADistanceFieldPathRenderer.cpp
[modify] https://crrev.com/000ca636e6de2e2b8bf9c82e3dee2d7ad8e1bed8/src/gpu/ops/GrAADistanceFieldPathRenderer.h

Project Member

Comment 6 by bugdroid1@chromium.org, Jan 11 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/7704754049cac4794f27496efa90acea963b8881

commit 7704754049cac4794f27496efa90acea963b8881
Author: Jim Van Verth <jvanverth@google.com>
Date: Wed Jan 11 19:17:00 2017

More fixes for distance field paths

Disables use of SDFs for very small paths (because of blurring) and
adds a border of 1 pixel in device space to handle antialiasing.

BUG= chromium:677889 

Change-Id: Icd2f7e80323b1255f8de52b97360e9a2d995c765
Reviewed-on: https://skia-review.googlesource.com/6895
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

[modify] https://crrev.com/7704754049cac4794f27496efa90acea963b8881/gm/pathfill.cpp
[modify] https://crrev.com/7704754049cac4794f27496efa90acea963b8881/src/gpu/ops/GrAADistanceFieldPathRenderer.cpp
[modify] https://crrev.com/7704754049cac4794f27496efa90acea963b8881/src/gpu/ops/GrAADistanceFieldPathRenderer.h

Project Member

Comment 7 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d1307068024c943814b1a8da9013c25b13892f70

commit d1307068024c943814b1a8da9013c25b13892f70
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Thu Jan 12 00:20:11 2017

Roll src/third_party/skia/ a5494f117..8d80bb5f2 (17 commits).

https://skia.googlesource.com/skia.git/+log/a5494f117086..8d80bb5f20d8

$ git log a5494f117..8d80bb5f2 --date=short --no-merges --format='%ad %ae %s'
2017-01-11 herb Revert "Introduce SkArenaAlloc - should be fast for POD types and RAII for types with dtors."
2017-01-11 halcanary SkUTF8_CountUnichars(s,l) and SkUTF8_NextUnichar(s,l) now safe.
2017-01-11 bsalomon Fix undefined GrIORef test method on Chrome win bot
2017-01-11 herb Introduce SkArenaAlloc - should be fast for POD types and RAII for types with dtors.
2017-01-11 jvanverth More fixes for distance field paths
2017-01-11 bsalomon Make GrPaints move their GrProcessor ownership into GrPipelineBuilder.
2017-01-11 reed move SkTRegister.h into tools
2017-01-11 bungeman Remove SK_LEGACY_FONTMGR_FACTORY.
2017-01-11 reed remove dead file: PathOpsSkpClipTest.cpp
2017-01-11 mtklein SkSplicer: start on Windows support
2017-01-11 halcanary SkTestTypeface: correct encoding
2017-01-11 halcanary SkTypes.h : move SkAutoMalloc into SkAutoMalloc.h
2017-01-11 jvanverth Revert "More fixes for distance field paths"
2017-01-11 scroggo Make SkColorToHSV and SkHSVToColor "perfect" inverses
2017-01-11 jvanverth More fixes for distance field paths
2017-01-11 kjlubick Revert "SkTypes.h : move SkAutoMalloc into SkAutoMalloc.h"
2017-01-11 bsalomon Add test for processor->resource ref/io counts

BUG= 677889 , 677889 ,b/33737498,677889

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2623123003
Cr-Commit-Position: refs/heads/master@{#443075}

[modify] https://crrev.com/d1307068024c943814b1a8da9013c25b13892f70/DEPS

Labels: TE-Verified-57.0.2979.0 TE-Verified-M57
Verified the issue on Mac 10.12.2 using chrome version #57.0.2979.0 as per the comment #0.
Observed that the fix is working as expected.

Attaching screenshot for reference

Hence, adding the verified labels.

Thanks...!!
677889.png
120 KB View Download
This change introduced a perf regression on the Skia bots. I'm reverting one piece which shouldn't have much of an effect on visual quality, but it may be worth reverifying when that lands.
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/062990bc7a8a667d6282ff73188589e57c7607ed

commit 062990bc7a8a667d6282ff73188589e57c7607ed
Author: Jim Van Verth <jvanverth@google.com>
Date: Thu Jan 12 15:00:16 2017

Fix perf regression with SDF paths

BUG= skia:6113 , chromium:677889 

Change-Id: I13d012a92e4d0371138f5ed4b92c7850f9b773a5
Reviewed-on: https://skia-review.googlesource.com/6945
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

[modify] https://crrev.com/062990bc7a8a667d6282ff73188589e57c7607ed/src/gpu/ops/GrAADistanceFieldPathRenderer.cpp

Status: Fixed (was: Assigned)
Labels: Merge-Request-56
The change that introduced this regression was cherry-picked back into M56 (in  bug 668550 ), so requesting merge of both of these patches.
Project Member

Comment 13 by bugdroid1@chromium.org, Jan 12 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6f3aed6635e3d07484f02e0d8fa7037a1ce312a0

commit 6f3aed6635e3d07484f02e0d8fa7037a1ce312a0
Author: skia-deps-roller <skia-deps-roller@chromium.org>
Date: Thu Jan 12 18:18:28 2017

Roll src/third_party/skia/ d32303e72..693fdbd6b (4 commits).

https://skia.googlesource.com/skia.git/+log/d32303e7276b..693fdbd6b81a

$ git log d32303e72..693fdbd6b --date=short --no-merges --format='%ad %ae %s'
2017-01-12 reed refFoo variant for getters that naturally have a sk_sp
2017-01-12 mtklein skia_android_serial = "auto"
2017-01-12 brianosman Cleanup GrPixelConfig helper functions
2017-01-12 jvanverth Fix perf regression with SDF paths

BUG= 677889 

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
TBR=kjlubick@google.com

Review-Url: https://codereview.chromium.org/2627953004
Cr-Commit-Position: refs/heads/master@{#443294}

[modify] https://crrev.com/6f3aed6635e3d07484f02e0d8fa7037a1ce312a0/DEPS

Project Member

Comment 14 by sheriffbot@chromium.org, Jan 13 2017

Labels: -Merge-Request-56 Merge-Review-56 Hotlist-Merge-Review
This bug requires manual review: DEPS changes referenced in bugdroid comments.
Please contact the milestone owner if you have questions.
Owners: amineer@(clank), cmasso@(bling), gkihumba@(cros), bustamante@(desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Review-56 Merge-Approved-56
Re: #12 sounds good to me approving those changes for merge into M56
Please merge your change to M56 ASAP, we are cutting Stable RC soon.
Project Member

Comment 17 by bugdroid1@chromium.org, Jan 23 2017

Labels: merge-merged-m56
The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/87d51117eb171a38f910eccf24621d14774eb9c6

commit 87d51117eb171a38f910eccf24621d14774eb9c6
Author: Jim Van Verth <jvanverth@google.com>
Date: Wed Jan 11 19:17:00 2017

[M56] More fixes for distance field paths

Disables use of SDFs for very small paths (because of blurring) and
adds a border of 1 pixel in device space to handle antialiasing.

BUG= chromium:677889 

Change-Id: Icd2f7e80323b1255f8de52b97360e9a2d995c765
Reviewed-on: https://skia-review.googlesource.com/6895
Reviewed-by: Brian Salomon <bsalomon@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

[modify] https://crrev.com/87d51117eb171a38f910eccf24621d14774eb9c6/gm/pathfill.cpp
[modify] https://crrev.com/87d51117eb171a38f910eccf24621d14774eb9c6/src/gpu/batches/GrAADistanceFieldPathRenderer.cpp
[modify] https://crrev.com/87d51117eb171a38f910eccf24621d14774eb9c6/src/gpu/batches/GrAADistanceFieldPathRenderer.h

Project Member

Comment 18 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://skia.googlesource.com/skia.git/+/00c8b7fa42bea2a623b4f07e353c15949212c4b6

commit 00c8b7fa42bea2a623b4f07e353c15949212c4b6
Author: Jim Van Verth <jvanverth@google.com>
Date: Thu Jan 12 15:00:16 2017

Fix perf regression with SDF paths

BUG= skia:6113 , chromium:677889 

Change-Id: I13d012a92e4d0371138f5ed4b92c7850f9b773a5
Reviewed-on: https://skia-review.googlesource.com/6945
Reviewed-by: Robert Phillips <robertphillips@google.com>
Commit-Queue: Jim Van Verth <jvanverth@google.com>

[modify] https://crrev.com/00c8b7fa42bea2a623b4f07e353c15949212c4b6/src/gpu/batches/GrAADistanceFieldPathRenderer.cpp

Project Member

Comment 19 by sheriffbot@chromium.org, Jan 24 2017

This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible!

If all merges have been completed, please remove any remaining Merge-Approved labels from this issue.

Thanks for your time! To disable nags, add the Disable-Nags label.

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
Labels: -Merge-Approved-56

Sign in to add a comment