New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 677884 link

Starred by 4 users
Status: Fixed
Owner:
█ ktyliu@chromium.org
Last visit > 30 days ago
Closed: Feb 2017
Cc:
danakj@chromium.org
█ sashab@chromium.org
█ ktyliu@chromium.org
█ meade@chromium.org
dpranke@chromium.org
lukasza@chromium.org
dcheng@chromium.org
alancutter@chromium.org
█ nasko@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Feature



Sign in to add a comment

Convert *.in files to use JSON5 format

Project Member Reported by sashab@chromium.org, Jan 3 2017 
Convert all Blink *.in files to the standard format  JSON5.

Design doc here: https://docs.google.com/document/d/1gJanTJmakqd_HAm5GqnnfUxfG2G1koqSEZ8A-Q9Nhao/edit

Comment 1 by sashab@chromium.org, Jan 3 2017

Cc: meade@chromium.org alancutter@chromium.org

Comment 2 by shans@chromium.org, Jan 3 2017

Labels: -Type-Bug Objective Type-Feature
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 6 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/950a485a2b8a36beefe4bb7140274399390745c3

commit 950a485a2b8a36beefe4bb7140274399390745c3
Author: ktyliu <ktyliu@chromium.org>
Date: Fri Jan 06 06:37:30 2017

Use switches for CSSPropertyMetadata::isDescriptorOnly.
This allows CSSProperties.in to have unordered entries.

Generated code is now:

namespace blink {

bool CSSPropertyMetadata::isDescriptorOnly(CSSPropertyID property) {
  switch(property) {
    case CSSPropertyInvalid:
      ASSERT_NOT_REACHED();
      return false;
    case CSSPropertyFontDisplay:
    case CSSPropertyMinZoom:
    case CSSPropertyOrientation:
    case CSSPropertyUnicodeRange:
    case CSSPropertyMaxZoom:
    case CSSPropertyUserZoom:
    case CSSPropertySrc:
      return true;
    default:
      return false;
  }
}

BUG= 677884 

Review-Url: https://codereview.chromium.org/2614773007
Cr-Commit-Position: refs/heads/master@{#441894}

[modify] https://crrev.com/950a485a2b8a36beefe4bb7140274399390745c3/third_party/WebKit/Source/build/scripts/css_properties.py
[modify] https://crrev.com/950a485a2b8a36beefe4bb7140274399390745c3/third_party/WebKit/Source/build/scripts/make_css_property_metadata.py
[modify] https://crrev.com/950a485a2b8a36beefe4bb7140274399390745c3/third_party/WebKit/Source/build/scripts/templates/CSSPropertyMetadata.cpp.tmpl

Comment 5 by dcheng@chromium.org, Jan 9 2017

Cc: dcheng@chromium.org danakj@chromium.org nasko@chromium.org lukasza@chromium.org

Comment 6 by dpranke@chromium.org, Jan 10 2017

Cc: dpranke@chromium.org
There is no built-in support for YAML in Python, and we already have an annoying number of different configuration file formats in the repo. And, YAML is a potentially large and complex format.

Would you be willing to use the "PYthon Literal" format instead? This is the format we use in //tools/mb/mb_config.pyl and a number of other places. It's basically the subset of Python parsable by ast.literal_eval.

Or, failing that, maybe json5? 

I do understand that YAML can be nice and readable, perhaps more so than the others ...

Comment 7 by ktyliu@chromium.org, Jan 11 2017

Description: Show this description

Comment 8 by alancutter@chromium.org, Jan 11 2017

Summary: Convert *.in files to use PYthon Literal format (was: Convert *.in files to YAML)
Project Member

Comment 9 by bugdroid1@chromium.org, Jan 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/be6d3f418dca5f76954e3e04108364fb6ce3be29

commit be6d3f418dca5f76954e3e04108364fb6ce3be29
Author: sashab <sashab@chromium.org>
Date: Mon Jan 16 04:32:16 2017

Add 'priority' key to CSSProperties.in

Add a 'priority' key to CSSProperties.in, rather than relying on the
file order. This removes the requirement that properties defined in this
file have to be in a certain order.

BUG= 677884 

Review-Url: https://codereview.chromium.org/2620233002
Cr-Commit-Position: refs/heads/master@{#443845}

[modify] https://crrev.com/be6d3f418dca5f76954e3e04108364fb6ce3be29/third_party/WebKit/Source/build/scripts/css_properties.py
[modify] https://crrev.com/be6d3f418dca5f76954e3e04108364fb6ce3be29/third_party/WebKit/Source/core/css/CSSProperties.in
[modify] https://crrev.com/be6d3f418dca5f76954e3e04108364fb6ce3be29/third_party/WebKit/Source/core/css/resolver/CSSPropertyPriority.h
Project Member

Comment 10 by bugdroid1@chromium.org, Jan 16 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/4a9064a99588486772c9c2ec88e84e2a4f444f65

commit 4a9064a99588486772c9c2ec88e84e2a4f444f65
Author: ktyliu <ktyliu@chromium.org>
Date: Mon Jan 16 21:57:58 2017

Convert Settings.in, CSSValueKeywords.in, SVGCSSValueKeywords.in to json5

Add json5_generator similar to in_generator and in_file to read json5
configs with default and valid_value&valid_type support.

Link to design doc in bug.

BUG= 677884 

Review-Url: https://codereview.chromium.org/2620883002
Cr-Commit-Position: refs/heads/master@{#443949}

[add] https://crrev.com/4a9064a99588486772c9c2ec88e84e2a4f444f65/third_party/WebKit/Source/build/scripts/json5_generator.py
[modify] https://crrev.com/4a9064a99588486772c9c2ec88e84e2a4f444f65/third_party/WebKit/Source/build/scripts/make_css_value_keywords.py
[modify] https://crrev.com/4a9064a99588486772c9c2ec88e84e2a4f444f65/third_party/WebKit/Source/build/scripts/make_internal_settings.py
[modify] https://crrev.com/4a9064a99588486772c9c2ec88e84e2a4f444f65/third_party/WebKit/Source/build/scripts/make_settings.py
[modify] https://crrev.com/4a9064a99588486772c9c2ec88e84e2a4f444f65/third_party/WebKit/Source/build/scripts/name_utilities.py
[modify] https://crrev.com/4a9064a99588486772c9c2ec88e84e2a4f444f65/third_party/WebKit/Source/build/scripts/templates/SettingsMacros.h.tmpl
[modify] https://crrev.com/4a9064a99588486772c9c2ec88e84e2a4f444f65/third_party/WebKit/Source/core/BUILD.gn
[delete] https://crrev.com/8dffb3c9d60eabf71c44980fbbab1d61d7e9640f/third_party/WebKit/Source/core/css/CSSValueKeywords.in
[add] https://crrev.com/4a9064a99588486772c9c2ec88e84e2a4f444f65/third_party/WebKit/Source/core/css/CSSValueKeywords.json5
[delete] https://crrev.com/8dffb3c9d60eabf71c44980fbbab1d61d7e9640f/third_party/WebKit/Source/core/css/SVGCSSValueKeywords.in
[add] https://crrev.com/4a9064a99588486772c9c2ec88e84e2a4f444f65/third_party/WebKit/Source/core/css/SVGCSSValueKeywords.json5
[delete] https://crrev.com/8dffb3c9d60eabf71c44980fbbab1d61d7e9640f/third_party/WebKit/Source/core/frame/Settings.in
[add] https://crrev.com/4a9064a99588486772c9c2ec88e84e2a4f444f65/third_party/WebKit/Source/core/frame/Settings.json5

Comment 11 by sashab@chromium.org, Jan 19 2017

Cc: sashab@chromium.org
Owner: ktyliu@chromium.org

Comment 12 by ktyliu@chromium.org, Jan 24 2017

Summary: Convert *.in files to use JSON5 format (was: Convert *.in files to use PYthon Literal format)

Comment 13 by ktyliu@chromium.org, Jan 24 2017

Description: Show this description
Project Member

Comment 14 by bugdroid1@chromium.org, Jan 25 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94a7540e73efd7ba5e99436188c0d00562657b5c

commit 94a7540e73efd7ba5e99436188c0d00562657b5c
Author: ktyliu <ktyliu@chromium.org>
Date: Wed Jan 25 00:44:26 2017

Convert make_names and make_event_factory to use json5 config format.

Subsequently converted make_media_feature_names and make_media_features
as well and these config files:
  Source/core/css/MediaFeatureNames.json5
  Source/core/css/MediaTypeNames.json5
  Source/core/editing/InputModeNames.json5
  Source/core/events/EventAliases.json5
  Source/core/events/EventTargetFactory.json5
  Source/core/events/EventTypeNames.json5
  Source/core/html/forms/InputTypeNames.json5
  Source/core/html/parser/HTMLTokenizerNames.json5
  Source/modules/EventTargetModulesFactory.json5
  Source/modules/indexeddb/IndexedDBNames.json5
  Source/platform/fonts/FontFamilyNames.json5
  Source/platform/loader/fetch/FetchInitiatorTypeNames.in
  Source/platform/network/HTTPNames.json5

Small fixes to json5_generator to support the above make_* scripts
and allow default_parameters to be specified within .py scripts.

BUG= 677884 

Review-Url: https://codereview.chromium.org/2638233002
Cr-Commit-Position: refs/heads/master@{#445879}

[modify] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/bindings/modules/BUILD.gn
[modify] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/bindings/scripts/generate_event_interfaces.py
[modify] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/build/scripts/json5_generator.py
[modify] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/build/scripts/make_event_factory.py
[modify] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/build/scripts/make_media_feature_names.py
[modify] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/build/scripts/make_media_features.py
[modify] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/build/scripts/make_names.py
[modify] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/core/BUILD.gn
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/core/css/MediaFeatureNames.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/core/css/MediaFeatureNames.json5
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/core/css/MediaTypeNames.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/core/css/MediaTypeNames.json5
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/core/editing/InputModeNames.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/core/editing/InputModeNames.json5
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/core/events/EventAliases.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/core/events/EventAliases.json5
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/core/events/EventTargetFactory.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/core/events/EventTargetFactory.json5
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/core/events/EventTypeNames.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/core/events/EventTypeNames.json5
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/core/html/forms/InputTypeNames.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/core/html/forms/InputTypeNames.json5
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/core/html/parser/HTMLTokenizerNames.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/core/html/parser/HTMLTokenizerNames.json5
[modify] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/modules/BUILD.gn
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/modules/EventTargetModulesFactory.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/modules/EventTargetModulesFactory.json5
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/modules/indexeddb/IndexedDBNames.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/modules/indexeddb/IndexedDBNames.json5
[modify] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/platform/BUILD.gn
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/platform/fonts/FontFamilyNames.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/platform/fonts/FontFamilyNames.json5
[modify] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/platform/loader/BUILD.gn
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/platform/loader/fetch/FetchInitiatorTypeNames.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/platform/loader/fetch/FetchInitiatorTypeNames.json5
[delete] https://crrev.com/d903639cc3c5c078b62cb0e04926d8a1f10d7b73/third_party/WebKit/Source/platform/network/HTTPNames.in
[add] https://crrev.com/94a7540e73efd7ba5e99436188c0d00562657b5c/third_party/WebKit/Source/platform/network/HTTPNames.json5
Project Member

Comment 16 by bugdroid1@chromium.org, Jan 27 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65

commit 6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65
Author: ktyliu <ktyliu@chromium.org>
Date: Fri Jan 27 03:35:19 2017

Convert CSSProperties.in to JSON5 format

Update generate_supported_css to process JSON5 format.

Remove unnecessary CSSProperties.in input to Tools/Scripts/webkitpy/w3c/ since
it only requires -webkit-text-emphasis-* now (thanks to tkent@ for info)

BUG= 677884 ,  614955 

Review-Url: https://codereview.chromium.org/2633223003
Cr-Commit-Position: refs/heads/master@{#446574}

[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/css_properties.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/make_computed_style_base.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/make_css_property_apis.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/make_css_property_metadata.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/make_css_property_names.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/make_style_builder.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/make_style_shorthands.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/build/scripts/scripts.gni
[delete] https://crrev.com/8607d9dbd5cc0fc0af61580e7af0f92509bec5d0/third_party/WebKit/Source/core/css/CSSProperties.in
[add] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/core/css/CSSProperties.json5
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/devtools/BUILD.gn
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/devtools/scripts/build/generate_supported_css.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Source/devtools/scripts/gulp/gulpfile.js
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_converter_unittest.py
[modify] https://crrev.com/6a5bbaea71e02af0b0bd60c7ba3ed61f77179b65/third_party/WebKit/Tools/Scripts/webkitpy/w3c/test_copier_unittest.py
Project Member

Comment 17 by bugdroid1@chromium.org, Feb 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/701ccf95a0ec04657b59ad240e28be4085fe033f

commit 701ccf95a0ec04657b59ad240e28be4085fe033f
Author: ktyliu <ktyliu@chromium.org>
Date: Fri Feb 03 00:07:06 2017

Convert make_qualified_names and make_element_factory to use JSON5.

Convert make_qualified_names.py, make_element_factory.py,
make_element_type_helpers.py, and make_element_lookup_trie.py
to use JSON5 config format.

Converted these config files accordingly:
  Source/core/html/HTMLAttributeNames.in
  Source/core/html/HTMLTagNames.in
  Source/core/html/parser/MathMLAttributeNames.in
  Source/core/html/parser/MathMLTagNames.in
  Source/core/svg/SVGAttributeNames.in
  Source/core/svg/SVGTagNames.in
  Source/core/svg/xlinkattrs.in
  Source/core/xml/xmlattrs.in
  Source/core/xml/xmlnsattrs.in

Note that these files are updated together because:
1. make_element_factory.py depends on make_qualified_names.py
2. HTMLTagNames.in is common input to the scripts make_element_factory,
make_element_type_helpers and make_element_lookup_trie

Removed FIXME in make_element_type_helpers.py since that case
no longer occurs.

Also fixed bug in json5_generator where parameters should not be
validated if default_parameters is not provided.
(caught when I had typo on default_parameters in the script)

BUG= 677884 

Review-Url: https://codereview.chromium.org/2645283006
Cr-Original-Commit-Position: refs/heads/master@{#447450}
Committed: https://chromium.googlesource.com/chromium/src/+/f5ca5654596eeda38c2a796bbbad299d92b7f008
Review-Url: https://codereview.chromium.org/2645283006
Cr-Commit-Position: refs/heads/master@{#447891}

[modify] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/build/scripts/json5_generator.py
[modify] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/build/scripts/make_element_factory.py
[modify] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/build/scripts/make_element_lookup_trie.py
[modify] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/build/scripts/make_element_type_helpers.py
[modify] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/build/scripts/make_qualified_names.py
[modify] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/build/scripts/scripts.gni
[modify] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/core/BUILD.gn
[delete] https://crrev.com/36fa3dee1690ef5561ee86c653fc9b56fcba73e1/third_party/WebKit/Source/core/html/HTMLAttributeNames.in
[add] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[delete] https://crrev.com/36fa3dee1690ef5561ee86c653fc9b56fcba73e1/third_party/WebKit/Source/core/html/HTMLTagNames.in
[add] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/core/html/HTMLTagNames.json5
[delete] https://crrev.com/36fa3dee1690ef5561ee86c653fc9b56fcba73e1/third_party/WebKit/Source/core/html/parser/MathMLAttributeNames.in
[add] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/core/html/parser/MathMLAttributeNames.json5
[delete] https://crrev.com/36fa3dee1690ef5561ee86c653fc9b56fcba73e1/third_party/WebKit/Source/core/html/parser/MathMLTagNames.in
[add] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/core/html/parser/MathMLTagNames.json5
[delete] https://crrev.com/36fa3dee1690ef5561ee86c653fc9b56fcba73e1/third_party/WebKit/Source/core/svg/SVGAttributeNames.in
[add] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/core/svg/SVGAttributeNames.json5
[delete] https://crrev.com/36fa3dee1690ef5561ee86c653fc9b56fcba73e1/third_party/WebKit/Source/core/svg/SVGTagNames.in
[add] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/core/svg/SVGTagNames.json5
[delete] https://crrev.com/36fa3dee1690ef5561ee86c653fc9b56fcba73e1/third_party/WebKit/Source/core/svg/xlinkattrs.in
[add] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/core/svg/xlinkattrs.json5
[delete] https://crrev.com/36fa3dee1690ef5561ee86c653fc9b56fcba73e1/third_party/WebKit/Source/core/xml/xmlattrs.in
[add] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/core/xml/xmlattrs.json5
[delete] https://crrev.com/36fa3dee1690ef5561ee86c653fc9b56fcba73e1/third_party/WebKit/Source/core/xml/xmlnsattrs.in
[add] https://crrev.com/701ccf95a0ec04657b59ad240e28be4085fe033f/third_party/WebKit/Source/core/xml/xmlnsattrs.json5
Project Member

Comment 18 by bugdroid1@chromium.org, Feb 3 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d50208a95a17148ec119745d20ceba483da71672

commit d50208a95a17148ec119745d20ceba483da71672
Author: ktyliu <ktyliu@chromium.org>
Date: Fri Feb 03 02:15:00 2017

Revert of Convert make_qualified_names and make_element_factory to use JSON5. (patchset #5 id:80001 of https://codereview.chromium.org/2645283006/ )

Reason for revert:
Unexpected compile failure --
https://build.chromium.org/p/chromium/builders/Linux%20x64/builds/32431

Original issue's description:
> Convert make_qualified_names and make_element_factory to use JSON5.
>
> Convert make_qualified_names.py, make_element_factory.py,
> make_element_type_helpers.py, and make_element_lookup_trie.py
> to use JSON5 config format.
>
> Converted these config files accordingly:
>   Source/core/html/HTMLAttributeNames.in
>   Source/core/html/HTMLTagNames.in
>   Source/core/html/parser/MathMLAttributeNames.in
>   Source/core/html/parser/MathMLTagNames.in
>   Source/core/svg/SVGAttributeNames.in
>   Source/core/svg/SVGTagNames.in
>   Source/core/svg/xlinkattrs.in
>   Source/core/xml/xmlattrs.in
>   Source/core/xml/xmlnsattrs.in
>
> Note that these files are updated together because:
> 1. make_element_factory.py depends on make_qualified_names.py
> 2. HTMLTagNames.in is common input to the scripts make_element_factory,
> make_element_type_helpers and make_element_lookup_trie
>
> Removed FIXME in make_element_type_helpers.py since that case
> no longer occurs.
>
> Also fixed bug in json5_generator where parameters should not be
> validated if default_parameters is not provided.
> (caught when I had typo on default_parameters in the script)
>
> BUG= 677884 
>
> Review-Url: https://codereview.chromium.org/2645283006
> Cr-Original-Commit-Position: refs/heads/master@{#447450}
> Committed: https://chromium.googlesource.com/chromium/src/+/f5ca5654596eeda38c2a796bbbad299d92b7f008
> Review-Url: https://codereview.chromium.org/2645283006
> Cr-Commit-Position: refs/heads/master@{#447891}
> Committed: https://chromium.googlesource.com/chromium/src/+/701ccf95a0ec04657b59ad240e28be4085fe033f

TBR=nainar@chromium.org,sashab@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 677884 

Review-Url: https://codereview.chromium.org/2677603002
Cr-Commit-Position: refs/heads/master@{#447896}

[modify] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/build/scripts/json5_generator.py
[modify] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/build/scripts/make_element_factory.py
[modify] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/build/scripts/make_element_lookup_trie.py
[modify] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/build/scripts/make_element_type_helpers.py
[modify] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/build/scripts/make_qualified_names.py
[modify] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/build/scripts/scripts.gni
[modify] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/core/BUILD.gn
[add] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/core/html/HTMLAttributeNames.in
[delete] https://crrev.com/169e1ad7aeb6cf86dda8912fbf7e2ef3e2321344/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[add] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/core/html/HTMLTagNames.in
[delete] https://crrev.com/169e1ad7aeb6cf86dda8912fbf7e2ef3e2321344/third_party/WebKit/Source/core/html/HTMLTagNames.json5
[add] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/core/html/parser/MathMLAttributeNames.in
[delete] https://crrev.com/169e1ad7aeb6cf86dda8912fbf7e2ef3e2321344/third_party/WebKit/Source/core/html/parser/MathMLAttributeNames.json5
[add] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/core/html/parser/MathMLTagNames.in
[delete] https://crrev.com/169e1ad7aeb6cf86dda8912fbf7e2ef3e2321344/third_party/WebKit/Source/core/html/parser/MathMLTagNames.json5
[add] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/core/svg/SVGAttributeNames.in
[delete] https://crrev.com/169e1ad7aeb6cf86dda8912fbf7e2ef3e2321344/third_party/WebKit/Source/core/svg/SVGAttributeNames.json5
[add] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/core/svg/SVGTagNames.in
[delete] https://crrev.com/169e1ad7aeb6cf86dda8912fbf7e2ef3e2321344/third_party/WebKit/Source/core/svg/SVGTagNames.json5
[add] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/core/svg/xlinkattrs.in
[delete] https://crrev.com/169e1ad7aeb6cf86dda8912fbf7e2ef3e2321344/third_party/WebKit/Source/core/svg/xlinkattrs.json5
[add] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/core/xml/xmlattrs.in
[delete] https://crrev.com/169e1ad7aeb6cf86dda8912fbf7e2ef3e2321344/third_party/WebKit/Source/core/xml/xmlattrs.json5
[add] https://crrev.com/d50208a95a17148ec119745d20ceba483da71672/third_party/WebKit/Source/core/xml/xmlnsattrs.in
[delete] https://crrev.com/169e1ad7aeb6cf86dda8912fbf7e2ef3e2321344/third_party/WebKit/Source/core/xml/xmlnsattrs.json5
Project Member

Comment 19 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5821741047894731b6527b607edfb8ddef33fd1b

commit 5821741047894731b6527b607edfb8ddef33fd1b
Author: ktyliu <ktyliu@chromium.org>
Date: Thu Feb 09 02:26:20 2017

Convert RuntimeEnabledFeatures.in config file to JSON5 format.

The allowed parameters and their default and valid values/types are
now in the config file itself rather than in separate .py script.

Added comments for parameters "feature_policy" and "custom".
And removed obsolete "condition" parameter.

BUG= 677884 
TBR=jam@chromium.org

Review-Url: https://codereview.chromium.org/2656163005
Cr-Commit-Position: refs/heads/master@{#449191}

[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/components/test_runner/test_interfaces.cc
[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/content/public/common/content_switches.cc
[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/third_party/WebKit/Source/bindings/IDLExtendedAttributes.md
[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/third_party/WebKit/Source/bindings/IDLExtendedAttributes.txt
[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/third_party/WebKit/Source/build/scripts/make_internal_runtime_flags.py
[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/third_party/WebKit/Source/build/scripts/make_origin_trials.py
[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/third_party/WebKit/Source/build/scripts/make_runtime_features.py
[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/third_party/WebKit/Source/build/scripts/scripts.gni
[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/third_party/WebKit/Source/build/scripts/templates/RuntimeEnabledFeatures.h.tmpl
[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/third_party/WebKit/Source/core/BUILD.gn
[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/third_party/WebKit/Source/core/origin_trials/OriginTrialContext.h
[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/third_party/WebKit/Source/platform/BUILD.gn
[modify] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/third_party/WebKit/Source/platform/OWNERS
[delete] https://crrev.com/b93cbcadc5af7f922dd3ae2e379d39e06e7c4f93/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in
[add] https://crrev.com/5821741047894731b6527b607edfb8ddef33fd1b/third_party/WebKit/Source/platform/RuntimeEnabledFeatures.json5
Project Member

Comment 20 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/013b234ed4fc6fd9a999bc2bd5f156a17c810356

commit 013b234ed4fc6fd9a999bc2bd5f156a17c810356
Author: ktyliu <ktyliu@chromium.org>
Date: Thu Feb 09 06:36:54 2017

Convert make_qualified_names and make_element_factory to use JSON5.

Convert make_qualified_names.py, make_element_factory.py,
make_element_type_helpers.py, and make_element_lookup_trie.py
to use JSON5 config format.

Converted these config files accordingly:
  Source/core/html/HTMLAttributeNames.in
  Source/core/html/HTMLTagNames.in
  Source/core/html/parser/MathMLAttributeNames.in
  Source/core/html/parser/MathMLTagNames.in
  Source/core/svg/SVGAttributeNames.in
  Source/core/svg/SVGTagNames.in
  Source/core/svg/xlinkattrs.in
  Source/core/xml/xmlattrs.in
  Source/core/xml/xmlnsattrs.in

Note that these files are updated together because:
1. make_element_factory.py depends on make_qualified_names.py
2. HTMLTagNames.in is common input to the scripts make_element_factory,
make_element_type_helpers and make_element_lookup_trie

Removed FIXME in make_element_type_helpers.py since that case
no longer occurs.

Also fixed bug in json5_generator where parameters should not be
validated if default_parameters is not provided.
(caught when I had typo on default_parameters in the script)

BUG= 677884 

Review-Url: https://codereview.chromium.org/2645283006
Cr-Original-Original-Commit-Position: refs/heads/master@{#447450}
Committed: https://chromium.googlesource.com/chromium/src/+/f5ca5654596eeda38c2a796bbbad299d92b7f008
Review-Url: https://codereview.chromium.org/2645283006
Cr-Original-Commit-Position: refs/heads/master@{#447891}
Committed: https://chromium.googlesource.com/chromium/src/+/701ccf95a0ec04657b59ad240e28be4085fe033f
Review-Url: https://codereview.chromium.org/2645283006
Cr-Commit-Position: refs/heads/master@{#449229}

[modify] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/build/scripts/json5_generator.py
[modify] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/build/scripts/make_element_factory.py
[modify] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/build/scripts/make_element_lookup_trie.py
[modify] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/build/scripts/make_element_type_helpers.py
[modify] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/build/scripts/make_qualified_names.py
[modify] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/core/BUILD.gn
[delete] https://crrev.com/36218827374706794314c50713b5614a78562e54/third_party/WebKit/Source/core/html/HTMLAttributeNames.in
[add] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[delete] https://crrev.com/36218827374706794314c50713b5614a78562e54/third_party/WebKit/Source/core/html/HTMLTagNames.in
[add] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/core/html/HTMLTagNames.json5
[delete] https://crrev.com/36218827374706794314c50713b5614a78562e54/third_party/WebKit/Source/core/html/parser/MathMLAttributeNames.in
[add] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/core/html/parser/MathMLAttributeNames.json5
[delete] https://crrev.com/36218827374706794314c50713b5614a78562e54/third_party/WebKit/Source/core/html/parser/MathMLTagNames.in
[add] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/core/html/parser/MathMLTagNames.json5
[delete] https://crrev.com/36218827374706794314c50713b5614a78562e54/third_party/WebKit/Source/core/svg/SVGAttributeNames.in
[add] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/core/svg/SVGAttributeNames.json5
[delete] https://crrev.com/36218827374706794314c50713b5614a78562e54/third_party/WebKit/Source/core/svg/SVGTagNames.in
[add] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/core/svg/SVGTagNames.json5
[delete] https://crrev.com/36218827374706794314c50713b5614a78562e54/third_party/WebKit/Source/core/svg/xlinkattrs.in
[add] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/core/svg/xlinkattrs.json5
[delete] https://crrev.com/36218827374706794314c50713b5614a78562e54/third_party/WebKit/Source/core/xml/xmlattrs.in
[add] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/core/xml/xmlattrs.json5
[delete] https://crrev.com/36218827374706794314c50713b5614a78562e54/third_party/WebKit/Source/core/xml/xmlnsattrs.in
[add] https://crrev.com/013b234ed4fc6fd9a999bc2bd5f156a17c810356/third_party/WebKit/Source/core/xml/xmlnsattrs.json5
Project Member

Comment 21 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ae47ac5b301ab24bd9c2385952a36e84826caeae

commit ae47ac5b301ab24bd9c2385952a36e84826caeae
Author: haraken <haraken@chromium.org>
Date: Thu Feb 09 07:28:09 2017

Revert of Convert make_qualified_names and make_element_factory to use JSON5. (patchset #7 id:120001 of https://codereview.chromium.org/2645283006/ )

Reason for revert:
This broke compile on Android

https://build.chromium.org/p/chromium/builders/Android/builds/68034

Original issue's description:
> Convert make_qualified_names and make_element_factory to use JSON5.
>
> Convert make_qualified_names.py, make_element_factory.py,
> make_element_type_helpers.py, and make_element_lookup_trie.py
> to use JSON5 config format.
>
> Converted these config files accordingly:
>   Source/core/html/HTMLAttributeNames.in
>   Source/core/html/HTMLTagNames.in
>   Source/core/html/parser/MathMLAttributeNames.in
>   Source/core/html/parser/MathMLTagNames.in
>   Source/core/svg/SVGAttributeNames.in
>   Source/core/svg/SVGTagNames.in
>   Source/core/svg/xlinkattrs.in
>   Source/core/xml/xmlattrs.in
>   Source/core/xml/xmlnsattrs.in
>
> Note that these files are updated together because:
> 1. make_element_factory.py depends on make_qualified_names.py
> 2. HTMLTagNames.in is common input to the scripts make_element_factory,
> make_element_type_helpers and make_element_lookup_trie
>
> Removed FIXME in make_element_type_helpers.py since that case
> no longer occurs.
>
> Also fixed bug in json5_generator where parameters should not be
> validated if default_parameters is not provided.
> (caught when I had typo on default_parameters in the script)
>
> BUG= 677884 
>
> Review-Url: https://codereview.chromium.org/2645283006
> Cr-Original-Original-Commit-Position: refs/heads/master@{#447450}
> Committed: https://chromium.googlesource.com/chromium/src/+/f5ca5654596eeda38c2a796bbbad299d92b7f008
> Review-Url: https://codereview.chromium.org/2645283006
> Cr-Original-Commit-Position: refs/heads/master@{#447891}
> Committed: https://chromium.googlesource.com/chromium/src/+/701ccf95a0ec04657b59ad240e28be4085fe033f
> Review-Url: https://codereview.chromium.org/2645283006
> Cr-Commit-Position: refs/heads/master@{#449229}
> Committed: https://chromium.googlesource.com/chromium/src/+/013b234ed4fc6fd9a999bc2bd5f156a17c810356

TBR=nainar@chromium.org,sashab@chromium.org,ktyliu@chromium.org
# Skipping CQ checks because original CL landed less than 1 days ago.
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG= 677884 

Review-Url: https://codereview.chromium.org/2684973006
Cr-Commit-Position: refs/heads/master@{#449231}

[modify] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/build/scripts/json5_generator.py
[modify] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/build/scripts/make_element_factory.py
[modify] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/build/scripts/make_element_lookup_trie.py
[modify] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/build/scripts/make_element_type_helpers.py
[modify] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/build/scripts/make_qualified_names.py
[modify] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/core/BUILD.gn
[add] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/core/html/HTMLAttributeNames.in
[delete] https://crrev.com/2019b9e075c501a4f7fb3a4a05a6f31c0a485468/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[add] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/core/html/HTMLTagNames.in
[delete] https://crrev.com/2019b9e075c501a4f7fb3a4a05a6f31c0a485468/third_party/WebKit/Source/core/html/HTMLTagNames.json5
[add] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/core/html/parser/MathMLAttributeNames.in
[delete] https://crrev.com/2019b9e075c501a4f7fb3a4a05a6f31c0a485468/third_party/WebKit/Source/core/html/parser/MathMLAttributeNames.json5
[add] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/core/html/parser/MathMLTagNames.in
[delete] https://crrev.com/2019b9e075c501a4f7fb3a4a05a6f31c0a485468/third_party/WebKit/Source/core/html/parser/MathMLTagNames.json5
[add] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/core/svg/SVGAttributeNames.in
[delete] https://crrev.com/2019b9e075c501a4f7fb3a4a05a6f31c0a485468/third_party/WebKit/Source/core/svg/SVGAttributeNames.json5
[add] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/core/svg/SVGTagNames.in
[delete] https://crrev.com/2019b9e075c501a4f7fb3a4a05a6f31c0a485468/third_party/WebKit/Source/core/svg/SVGTagNames.json5
[add] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/core/svg/xlinkattrs.in
[delete] https://crrev.com/2019b9e075c501a4f7fb3a4a05a6f31c0a485468/third_party/WebKit/Source/core/svg/xlinkattrs.json5
[add] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/core/xml/xmlattrs.in
[delete] https://crrev.com/2019b9e075c501a4f7fb3a4a05a6f31c0a485468/third_party/WebKit/Source/core/xml/xmlattrs.json5
[add] https://crrev.com/ae47ac5b301ab24bd9c2385952a36e84826caeae/third_party/WebKit/Source/core/xml/xmlnsattrs.in
[delete] https://crrev.com/2019b9e075c501a4f7fb3a4a05a6f31c0a485468/third_party/WebKit/Source/core/xml/xmlnsattrs.json5
Project Member

Comment 22 by bugdroid1@chromium.org, Feb 9 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5df01277cc419f8b19d266412738704022cda5d3

commit 5df01277cc419f8b19d266412738704022cda5d3
Author: ktyliu <ktyliu@chromium.org>
Date: Thu Feb 09 19:18:54 2017

Convert make_qualified_names and make_element_factory to use JSON5.

Convert make_qualified_names.py, make_element_factory.py,
make_element_type_helpers.py, and make_element_lookup_trie.py
to use JSON5 config format.

Converted these config files accordingly:
  Source/core/html/HTMLAttributeNames.in
  Source/core/html/HTMLTagNames.in
  Source/core/html/parser/MathMLAttributeNames.in
  Source/core/html/parser/MathMLTagNames.in
  Source/core/svg/SVGAttributeNames.in
  Source/core/svg/SVGTagNames.in
  Source/core/svg/xlinkattrs.in
  Source/core/xml/xmlattrs.in
  Source/core/xml/xmlnsattrs.in

Note that these files are updated together because:
1. make_element_factory.py depends on make_qualified_names.py
2. HTMLTagNames.in is common input to the scripts make_element_factory,
make_element_type_helpers and make_element_lookup_trie

Removed FIXME in make_element_type_helpers.py since that case
no longer occurs.

Also fixed bug in json5_generator where parameters should not be
validated if default_parameters is not provided.
(caught when I had typo on default_parameters in the script)

BUG= 677884 

Review-Url: https://codereview.chromium.org/2645283006
Cr-Original-Original-Original-Commit-Position: refs/heads/master@{#447450}
Committed: https://chromium.googlesource.com/chromium/src/+/f5ca5654596eeda38c2a796bbbad299d92b7f008
Review-Url: https://codereview.chromium.org/2645283006
Cr-Original-Original-Commit-Position: refs/heads/master@{#447891}
Committed: https://chromium.googlesource.com/chromium/src/+/701ccf95a0ec04657b59ad240e28be4085fe033f
Review-Url: https://codereview.chromium.org/2645283006
Cr-Original-Commit-Position: refs/heads/master@{#449229}
Committed: https://chromium.googlesource.com/chromium/src/+/013b234ed4fc6fd9a999bc2bd5f156a17c810356
Review-Url: https://codereview.chromium.org/2645283006
Cr-Commit-Position: refs/heads/master@{#449371}

[modify] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/build/scripts/json5_generator.py
[modify] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/build/scripts/make_element_factory.py
[modify] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/build/scripts/make_element_lookup_trie.py
[modify] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/build/scripts/make_element_type_helpers.py
[modify] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/build/scripts/make_qualified_names.py
[modify] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/core/BUILD.gn
[delete] https://crrev.com/02b0f69f8de747dbd9ac6d66a2b2248e650e40db/third_party/WebKit/Source/core/html/HTMLAttributeNames.in
[add] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/core/html/HTMLAttributeNames.json5
[delete] https://crrev.com/02b0f69f8de747dbd9ac6d66a2b2248e650e40db/third_party/WebKit/Source/core/html/HTMLTagNames.in
[add] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/core/html/HTMLTagNames.json5
[delete] https://crrev.com/02b0f69f8de747dbd9ac6d66a2b2248e650e40db/third_party/WebKit/Source/core/html/parser/MathMLAttributeNames.in
[add] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/core/html/parser/MathMLAttributeNames.json5
[delete] https://crrev.com/02b0f69f8de747dbd9ac6d66a2b2248e650e40db/third_party/WebKit/Source/core/html/parser/MathMLTagNames.in
[add] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/core/html/parser/MathMLTagNames.json5
[delete] https://crrev.com/02b0f69f8de747dbd9ac6d66a2b2248e650e40db/third_party/WebKit/Source/core/svg/SVGAttributeNames.in
[add] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/core/svg/SVGAttributeNames.json5
[delete] https://crrev.com/02b0f69f8de747dbd9ac6d66a2b2248e650e40db/third_party/WebKit/Source/core/svg/SVGTagNames.in
[add] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/core/svg/SVGTagNames.json5
[delete] https://crrev.com/02b0f69f8de747dbd9ac6d66a2b2248e650e40db/third_party/WebKit/Source/core/svg/xlinkattrs.in
[add] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/core/svg/xlinkattrs.json5
[delete] https://crrev.com/02b0f69f8de747dbd9ac6d66a2b2248e650e40db/third_party/WebKit/Source/core/xml/xmlattrs.in
[add] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/core/xml/xmlattrs.json5
[delete] https://crrev.com/02b0f69f8de747dbd9ac6d66a2b2248e650e40db/third_party/WebKit/Source/core/xml/xmlnsattrs.in
[add] https://crrev.com/5df01277cc419f8b19d266412738704022cda5d3/third_party/WebKit/Source/core/xml/xmlnsattrs.json5

Comment 23 by panicker@chromium.org, Feb 9 2017 

As part of this effort would it make sense to fix up major documentation links that most chromium / blink developers depend on.
For instance the links and instructions in runtime-enabled-features doc are now outdated: https://www.chromium.org/blink/runtime-enabled-features

Comment 24 by ktyliu@chromium.org, Feb 9 2017 

Thanks for the reminder, panicker@

Fixed  https://www.chromium.org/blink/runtime-enabled-features . Searching on that site reveals there's no further reference to RuntimeEnabledFeatures.in or CSSProperties.in

Please help point out any other docs that need to be updated.
Project Member

Comment 25 by bugdroid1@chromium.org, Feb 10 2017 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1e03a5fea4e8dad12f91457dd2240fd0025cfd8d

commit 1e03a5fea4e8dad12f91457dd2240fd0025cfd8d
Author: ktyliu <ktyliu@chromium.org>
Date: Fri Feb 10 09:28:07 2017

Convert last CSSPrimitiveValueUnits.in to json5 format

* Convert CSSPrimitiveValueUnits.in to json5 format which is the last
* Update make_cssom_types.py to use json5_generator
* Remove script references from build and renamed scripts_for_in_files
  to scripts_for_json5_files

BUG= 677884 

Review-Url: https://codereview.chromium.org/2659283002
Cr-Commit-Position: refs/heads/master@{#449571}

[modify] https://crrev.com/1e03a5fea4e8dad12f91457dd2240fd0025cfd8d/third_party/WebKit/Source/build/scripts/in_generator.py
[modify] https://crrev.com/1e03a5fea4e8dad12f91457dd2240fd0025cfd8d/third_party/WebKit/Source/build/scripts/make_css_primitive_value_unit_trie.py
[modify] https://crrev.com/1e03a5fea4e8dad12f91457dd2240fd0025cfd8d/third_party/WebKit/Source/build/scripts/make_cssom_types.py
[modify] https://crrev.com/1e03a5fea4e8dad12f91457dd2240fd0025cfd8d/third_party/WebKit/Source/build/scripts/scripts.gni
[modify] https://crrev.com/1e03a5fea4e8dad12f91457dd2240fd0025cfd8d/third_party/WebKit/Source/core/BUILD.gn
[delete] https://crrev.com/1fe4b50ee936e74cf7f9428dc17555574ae67f43/third_party/WebKit/Source/core/css/CSSPrimitiveValueUnits.in
[add] https://crrev.com/1e03a5fea4e8dad12f91457dd2240fd0025cfd8d/third_party/WebKit/Source/core/css/CSSPrimitiveValueUnits.json5
[modify] https://crrev.com/1e03a5fea4e8dad12f91457dd2240fd0025cfd8d/third_party/WebKit/Source/platform/BUILD.gn

Comment 26 by ktyliu@chromium.org, Feb 11 2017

Status: Fixed (was: Assigned)
►

Sign in to add a comment