New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 677867 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Apr 2018
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

pytests: Merge all *_probe into the new probe test

Project Member Reported by hungte@chromium.org, Jan 3 2017

Issue description

The new pytests/probe is now more powerful that I'd recommend to merge other "probe" tests to it, including:
 - usb_probe
 - i2c_probe
 - hwmon_probe

Meanwhile, I'd also recommend to improve probe test itself so that:
 - There can be a simple UI listing components it is checking and have found or not. For example
 
 | Category| Name | Status | Info          |
 +---------+------+--------+---------------+
 | Battery | AXX  | Pass   |               |
 | Touch   | Syn1 | Failed |Mismatch: manid|
 | FPC     | FXX  | Failed |Not found      |


 
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 20 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/2a8c7517ef0fc9a78e4f694151e56ec121dedcec

commit 2a8c7517ef0fc9a78e4f694151e56ec121dedcec
Author: Chih-Yu Huang <akahuang@google.com>
Date: Mon Jan 16 04:23:08 2017

pytest: merge `i2c_probe` pytest into `probe` pytest.

We plan to merge all probe into the new probe pytest. In this CL we
created the README.md to describe how to use new pytest to verify
I2C components. Will deprecate all other probe pytests later.

BUG= chromium:677867 
TEST=none

Change-Id: I2c0cb15be1e38f8bec7fd4c421e0fbd781596ef2
Reviewed-on: https://chromium-review.googlesource.com/428650
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>

[add] https://crrev.com/2a8c7517ef0fc9a78e4f694151e56ec121dedcec/py/test/pytests/probe/probe_sample_i2c.json
[add] https://crrev.com/2a8c7517ef0fc9a78e4f694151e56ec121dedcec/py/test/pytests/probe/README.md
[rename] https://crrev.com/2a8c7517ef0fc9a78e4f694151e56ec121dedcec/py/test/pytests/probe/probe_sample.json
[modify] https://crrev.com/2a8c7517ef0fc9a78e4f694151e56ec121dedcec/py/test/pytests/i2c_probe.py

Project Member

Comment 2 by bugdroid1@chromium.org, Jan 23 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/3c275b6e0e7a5096cfbbd452016b80a3aa2755c2

commit 3c275b6e0e7a5096cfbbd452016b80a3aa2755c2
Author: Chih-Yu Huang <akahuang@google.com>
Date: Mon Jan 16 10:09:56 2017

pytest: add UI in probe pytest.

We generate a table to show the probed component for each category
and passes the rule or not for better debugging.

BUG= chromium:677867 
TEST=manually test at device

Change-Id: Ie82b332548bc3ee14a24ae210903b22c4ccf94ca
Reviewed-on: https://chromium-review.googlesource.com/428613
Commit-Ready: Chih-Yu Huang <akahuang@chromium.org>
Tested-by: Chih-Yu Huang <akahuang@chromium.org>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>
Reviewed-by: Pi-Hsun Shih <pihsun@chromium.org>

[modify] https://crrev.com/3c275b6e0e7a5096cfbbd452016b80a3aa2755c2/py/test/pytests/probe/probe.py

Project Member

Comment 3 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/72c9af04579b478e5bc85a86f8e48ecb6c81d8d6

commit 72c9af04579b478e5bc85a86f8e48ecb6c81d8d6
Author: Chih-Yu Huang <akahuang@google.com>
Date: Tue Mar 28 07:44:44 2017

Project Member

Comment 4 by bugdroid1@chromium.org, Mar 28 2017

The following revision refers to this bug:
  https://chrome-internal.googlesource.com/chromeos/overlays/overlay-eve-private/+/e453165eb5034657c6a24f09384ad8f064d6af89

commit e453165eb5034657c6a24f09384ad8f064d6af89
Author: Chih-Yu Huang <akahuang@google.com>
Date: Tue Mar 28 10:47:46 2017

Comment 5 by hungte@chromium.org, Jul 26 2017

Cc: -stimim@chromium.org chromeos-factory-eng@google.com
Owner: yhong@chromium.org
Status: Assigned (was: Untriaged)
Assign to yhong. I think this is roughly done, and we should not change test lists to only use the single probe, removing individual probe_* tests.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 9 2017

Comment 7 Deleted

Comment 8 Deleted

Project Member

Comment 9 by bugdroid1@chromium.org, Sep 19 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/8ae05062bb55221c101d2ec740084de021b4f1fb

commit 8ae05062bb55221c101d2ec740084de021b4f1fb
Author: Yong Hong <yhong@chromium.org>
Date: Tue Sep 19 12:25:10 2017

probe: Load the probe statement file by `config_utils.LoadConfig`.

This CL modifies `probe_cmdline.py` to load the given config file
by config_utils.LoadConfig instead of type_utils + json loader so
that the features such as inheritance and overridden can be applied
in probe statement file.

BUG= chromium:677867 
TEST=manually test on DUT

Change-Id: I7d1931cfd5d915c5a316f1eb4aa34e5366abe56a
Reviewed-on: https://chromium-review.googlesource.com/666856
Commit-Ready: Yong Hong <yhong@google.com>
Tested-by: Yong Hong <yhong@google.com>
Reviewed-by: Chih-Yu Huang <akahuang@chromium.org>

[modify] https://crrev.com/8ae05062bb55221c101d2ec740084de021b4f1fb/py/probe/statement.schema.json
[modify] https://crrev.com/8ae05062bb55221c101d2ec740084de021b4f1fb/py/probe/probe_cmdline.py
[add] https://crrev.com/8ae05062bb55221c101d2ec740084de021b4f1fb/py/probe/generic_statement.schema.json
[modify] https://crrev.com/8ae05062bb55221c101d2ec740084de021b4f1fb/py/probe/common.py
[modify] https://crrev.com/8ae05062bb55221c101d2ec740084de021b4f1fb/py/test/utils/goofy_plugin_utils.py
[modify] https://crrev.com/8ae05062bb55221c101d2ec740084de021b4f1fb/py/utils/testdata/config_utils_unittest.json
[modify] https://crrev.com/8ae05062bb55221c101d2ec740084de021b4f1fb/py/utils/config_utils.py
[modify] https://crrev.com/8ae05062bb55221c101d2ec740084de021b4f1fb/py/test/test_lists/manager.py
[modify] https://crrev.com/8ae05062bb55221c101d2ec740084de021b4f1fb/py/test/pytests/blocking_charge.py
[add] https://crrev.com/8ae05062bb55221c101d2ec740084de021b4f1fb/py/utils/testdata/extra_dir/config_utils_unittest_extra_dir.json
[modify] https://crrev.com/8ae05062bb55221c101d2ec740084de021b4f1fb/py/utils/config_utils_unittest.py

Project Member

Comment 10 by bugdroid1@chromium.org, Sep 19 2017

pytest 'verify_touch_device_fw' should be fine to use the new probe framework as well.
Project Member

Comment 12 by bugdroid1@chromium.org, Sep 27 2017

Project Member

Comment 13 by bugdroid1@chromium.org, Sep 28 2017

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/factory/+/addd4c89ae04d705567b72de0e9c6111bce846fc

commit addd4c89ae04d705567b72de0e9c6111bce846fc
Author: Yong Hong <yhong@chromium.org>
Date: Thu Sep 28 10:59:26 2017

probe: Removes the legacy *_probe pytests.

This CL deprecates the legacy probe pytests:
* i2c_probe
* usb_probe

In the future, all probing related tasks should be implemented by
the new probe framework.

BUG= chromium:677867 
TEST=manually test on DUT

Change-Id: I90343de794968f23f3a2c6d2e4d92497fb9255b9
Reviewed-on: https://chromium-review.googlesource.com/689414
Commit-Ready: Yong Hong <yhong@google.com>
Tested-by: Yong Hong <yhong@google.com>
Reviewed-by: Hung-Te Lin <hungte@chromium.org>

[modify] https://crrev.com/addd4c89ae04d705567b72de0e9c6111bce846fc/po/zh-CN.po
[modify] https://crrev.com/addd4c89ae04d705567b72de0e9c6111bce846fc/py/test/test_lists/generic_common.test_list.json
[delete] https://crrev.com/e74783dc9831f136f5cf901e1ab98d80034b29e2/py/test/pytests/probe/probe_sample_i2c.json
[delete] https://crrev.com/e74783dc9831f136f5cf901e1ab98d80034b29e2/py/test/pytests/usb_probe.py
[delete] https://crrev.com/e74783dc9831f136f5cf901e1ab98d80034b29e2/py/test/pytests/i2c_probe.py

Comment 15 by yhong@chromium.org, Apr 13 2018

Status: Fixed (was: Assigned)
re #11,

"verify_touch_device_fw" has already been listed in chromium:740513 so let's mark this bug fixed first and remove that pytest in that bug.

Sign in to add a comment